linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: alanx.chiang@intel.com
To: linux-i2c@vger.kernel.org
Cc: andy.yeh@intel.com, sakari.ailus@linux.intel.com,
	andriy.shevchenko@linux.intel.com, andriy.shevchenko@intel.com,
	rajmohan.mani@intel.com, andy.shevchenko@gmail.com,
	tfiga@chromium.org, jcliang@chromium.org, brgl@bgdev.pl,
	robh+dt@kernel.org, mark.rutland@arm.com, arnd@arndb.de,
	gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, Alan Chiang <alanx.chiang@intel.com>
Subject: [RESEND PATCH v4 2/2] eeprom: at24: Add support for address-width property
Date: Mon,  2 Jul 2018 17:12:20 +0800	[thread overview]
Message-ID: <1530522740-2798-3-git-send-email-alanx.chiang@intel.com> (raw)
In-Reply-To: <1530522740-2798-1-git-send-email-alanx.chiang@intel.com>

From: Alan Chiang <alanx.chiang@intel.com>

Provide a flexible way to determine the addressing bits of eeprom.
Pass the addressing bits to driver through address-width property.

Signed-off-by: Alan Chiang <alanx.chiang@intel.com>
Signed-off-by: Andy Yeh <andy.yeh@intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>

---
since v1
-- Add a warn message for 8-bit addressing.
since v2
-- Modify the warning message for clear.
-- Move the clearing bit operation outside of a statement.
since v3
-- Merge the warning message into one line.

---
 drivers/misc/eeprom/at24.c | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c
index 0c125f2..7ea640b 100644
--- a/drivers/misc/eeprom/at24.c
+++ b/drivers/misc/eeprom/at24.c
@@ -478,6 +478,23 @@ static void at24_properties_to_pdata(struct device *dev,
 	if (device_property_present(dev, "no-read-rollover"))
 		chip->flags |= AT24_FLAG_NO_RDROL;
 
+	err = device_property_read_u32(dev, "address-width", &val);
+	if (!err) {
+		switch (val) {
+		case 8:
+			if (chip->flags & AT24_FLAG_ADDR16)
+				dev_warn(dev, "Override address width to be 8, while default is 16\n");
+			chip->flags &= ~AT24_FLAG_ADDR16;
+			break;
+		case 16:
+			chip->flags |= AT24_FLAG_ADDR16;
+			break;
+		default:
+			dev_warn(dev, "Bad \"address-width\" property: %u\n",
+				 val);
+		}
+	}
+
 	err = device_property_read_u32(dev, "size", &val);
 	if (!err)
 		chip->byte_len = val;
-- 
2.7.4


  parent reply	other threads:[~2018-07-02  9:12 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-02  9:12 [RESEND PATCH v4 0/2] Add a property in at24.c alanx.chiang
2018-07-02  9:12 ` [RESEND PATCH v4 1/2] dt-bindings: at24: Add address-width property alanx.chiang
2018-07-05 21:22   ` Rob Herring
2018-07-05 20:24     ` Robert P. J. Day
2018-07-09  3:12       ` Chiang, AlanX
2018-07-09  8:52         ` Bartosz Golaszewski
2018-07-17  8:01           ` Bartosz Golaszewski
2018-07-24 11:07             ` sakari.ailus
2018-07-24 14:10               ` Bartosz Golaszewski
2018-07-02  9:12 ` alanx.chiang [this message]
2018-07-02 11:59 ` [RESEND PATCH v4 0/2] Add a property in at24.c Bartosz Golaszewski
2018-07-25  3:20 [RESEND PATCH v4 0/2] Add aproperty " alanx.chiang
2018-07-25  3:20 ` [RESEND PATCH v4 2/2] eeprom: at24: Add support for address-width property alanx.chiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1530522740-2798-3-git-send-email-alanx.chiang@intel.com \
    --to=alanx.chiang@intel.com \
    --cc=andriy.shevchenko@intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=andy.yeh@intel.com \
    --cc=arnd@arndb.de \
    --cc=brgl@bgdev.pl \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jcliang@chromium.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=rajmohan.mani@intel.com \
    --cc=robh+dt@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=tfiga@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).