From: "Robert P. J. Day" <rpjday@crashcourse.ca>
To: Rob Herring <robh@kernel.org>
Cc: alanx.chiang@intel.com, linux-i2c@vger.kernel.org,
andy.yeh@intel.com, sakari.ailus@linux.intel.com,
andriy.shevchenko@linux.intel.com, andriy.shevchenko@intel.com,
rajmohan.mani@intel.com, andy.shevchenko@gmail.com,
tfiga@chromium.org, jcliang@chromium.org, brgl@bgdev.pl,
mark.rutland@arm.com, arnd@arndb.de, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [RESEND PATCH v4 1/2] dt-bindings: at24: Add address-width property
Date: Thu, 5 Jul 2018 16:24:16 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.2.21.1807051623400.12206@localhost.localdomain> (raw)
In-Reply-To: <20180705212204.GA10449@rob-hp-laptop>
On Thu, 5 Jul 2018, Rob Herring wrote:
> On Mon, Jul 02, 2018 at 05:12:19PM +0800, alanx.chiang@intel.com wrote:
> > From: Alan Chiang <alanx.chiang@intel.com>
> >
> > The AT24 series chips use 8-bit address by default. If some
> > chips would like to support more than 8 bits, the at24 driver
> > should be added the compatible field for specfic chips.
> >
> > Provide a flexible way to determine the addressing bits through
> > address-width in this patch.
> >
> > Signed-off-by: Alan Chiang <alanx.chiang@intel.com>
> > Signed-off-by: Andy Yeh <andy.yeh@intel.com>
> > Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> >
> > ---
> > since v1:
> > -- Remove the address-width field in the example.
> > since v2:
> > -- Remove redundant space.
> > since v3:
> > -- Add Acked-by.
> >
> > ---
> > Documentation/devicetree/bindings/eeprom/at24.txt | 2 ++
> > 1 file changed, 2 insertions(+)
>
> Reviewed-by: Rob Herring <robh@kernel.org>
"... should be added the compatible field ..."??
rday
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca/dokuwiki
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
next prev parent reply other threads:[~2018-07-05 21:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-02 9:12 [RESEND PATCH v4 0/2] Add a property in at24.c alanx.chiang
2018-07-02 9:12 ` [RESEND PATCH v4 1/2] dt-bindings: at24: Add address-width property alanx.chiang
2018-07-05 21:22 ` Rob Herring
2018-07-05 20:24 ` Robert P. J. Day [this message]
2018-07-09 3:12 ` Chiang, AlanX
2018-07-09 8:52 ` Bartosz Golaszewski
2018-07-17 8:01 ` Bartosz Golaszewski
2018-07-24 11:07 ` sakari.ailus
2018-07-24 14:10 ` Bartosz Golaszewski
2018-07-02 9:12 ` [RESEND PATCH v4 2/2] eeprom: at24: Add support for " alanx.chiang
2018-07-02 11:59 ` [RESEND PATCH v4 0/2] Add a property in at24.c Bartosz Golaszewski
2018-07-25 3:20 [RESEND PATCH v4 0/2] Add aproperty " alanx.chiang
2018-07-25 3:20 ` [RESEND PATCH v4 1/2] dt-bindings: at24: Add address-width property alanx.chiang
2018-07-25 7:35 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.21.1807051623400.12206@localhost.localdomain \
--to=rpjday@crashcourse.ca \
--cc=alanx.chiang@intel.com \
--cc=andriy.shevchenko@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=andy.yeh@intel.com \
--cc=arnd@arndb.de \
--cc=brgl@bgdev.pl \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jcliang@chromium.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=rajmohan.mani@intel.com \
--cc=robh@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).