* [PATCH] ext4: remove abnormal set for I_DATA_SEM subclass
@ 2018-07-09 6:08 Junil Lee
0 siblings, 0 replies; 4+ messages in thread
From: Junil Lee @ 2018-07-09 6:08 UTC (permalink / raw)
To: tytso, adilger.kernel; +Cc: linux-ext4, linux-kernel, junil0814.lee
The -EBUSY return value of dquot_enable() function means that just
want to update flags. If some users make a duplicate request to update
flags, lockdep could catch the false positive casued by needing to
allocate a quota block from inside ext4_map_blocks(), while holding
i_data_sem for a data inode. This results in this comlaint:
CPU0 CPU1
---- ----
lock(&s->s_dquot.dqio_mutex);
lock(&ei->i_data_sem);
lock(&s->s_dquot.dqio_mutex);
lock(&ei->i_data_sem);
Signed-off-by: Junil Lee <junil0814.lee@lge.com>
---
fs/ext4/super.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 13d2706..f16c92d 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -5637,7 +5637,7 @@ static int ext4_quota_enable(struct super_block *sb, int type, int format_id,
lockdep_set_quota_inode(qf_inode, I_DATA_SEM_QUOTA);
err = dquot_enable(qf_inode, type, format_id, flags);
iput(qf_inode);
- if (err)
+ if (err != -EBUSY)
lockdep_set_quota_inode(qf_inode, I_DATA_SEM_NORMAL);
return err;
--
2.6.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] ext4: remove abnormal set for I_DATA_SEM subclass
@ 2018-07-09 7:58 Junil Lee
2018-07-22 22:08 ` Theodore Y. Ts'o
0 siblings, 1 reply; 4+ messages in thread
From: Junil Lee @ 2018-07-09 7:58 UTC (permalink / raw)
To: tytso, adilger.kernel; +Cc: linux-ext4, linux-kernel, junil0814.lee, Junil Lee
The -EBUSY return value of dquot_enable() function means that just
want to update flags. If some users make a duplicate request to update
flags, lockdep could catch the false positive casued by needing to
allocate a quota block from inside ext4_map_blocks(), while holding
i_data_sem for a data inode. This results in this complaint:
CPU0 CPU1
---- ----
lock(&s->s_dquot.dqio_mutex);
lock(&ei->i_data_sem);
lock(&s->s_dquot.dqio_mutex);
lock(&ei->i_data_sem);
Signed-off-by: Junil Lee <junil0814.lee@lge.com>
---
fs/ext4/super.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 13d2706..0757c9a 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -5637,7 +5637,7 @@ static int ext4_quota_enable(struct super_block *sb, int type, int format_id,
lockdep_set_quota_inode(qf_inode, I_DATA_SEM_QUOTA);
err = dquot_enable(qf_inode, type, format_id, flags);
iput(qf_inode);
- if (err)
+ if (err && err != -EBUSY)
lockdep_set_quota_inode(qf_inode, I_DATA_SEM_NORMAL);
return err;
--
2.6.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ext4: remove abnormal set for I_DATA_SEM subclass
2018-07-09 7:58 Junil Lee
@ 2018-07-22 22:08 ` Theodore Y. Ts'o
[not found] ` <ccb7943b-44af-5031-8410-f1c0851e70c2@lge.com>
0 siblings, 1 reply; 4+ messages in thread
From: Theodore Y. Ts'o @ 2018-07-22 22:08 UTC (permalink / raw)
To: Junil Lee; +Cc: adilger.kernel, linux-ext4, linux-kernel, junil0814.lee
On Mon, Jul 09, 2018 at 04:58:28PM +0900, Junil Lee wrote:
> The -EBUSY return value of dquot_enable() function means that just
> want to update flags. If some users make a duplicate request to update
> flags, lockdep could catch the false positive casued by needing to
> allocate a quota block from inside ext4_map_blocks(), while holding
> i_data_sem for a data inode. This results in this complaint:
>
> CPU0 CPU1
> ---- ----
> lock(&s->s_dquot.dqio_mutex);
> lock(&ei->i_data_sem);
> lock(&s->s_dquot.dqio_mutex);
> lock(&ei->i_data_sem);
How does this happen in practice? The function ext4_quota_enable() is
only called by ext4_enable_quotas(), and I don't see the code path
where this would happen. And if it does it would be resulting an
EXT4-fs warning message getting printing indicating that a failure to
enable quotas with an error of EBUSY. So how does this happen that
"users would make a duplicate request to update flags"?
- Ted
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-07-23 16:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-09 6:08 [PATCH] ext4: remove abnormal set for I_DATA_SEM subclass Junil Lee
2018-07-09 7:58 Junil Lee
2018-07-22 22:08 ` Theodore Y. Ts'o
[not found] ` <ccb7943b-44af-5031-8410-f1c0851e70c2@lge.com>
2018-07-23 16:23 ` Theodore Y. Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).