* [PATCH] arm64: dts: allwinner: activate spi flash on pine64 LTS board
@ 2018-07-26 6:51 Akash Gajjar
2018-07-26 7:29 ` Maxime Ripard
0 siblings, 1 reply; 4+ messages in thread
From: Akash Gajjar @ 2018-07-26 6:51 UTC (permalink / raw)
To: icenowy
Cc: Maxime Ripard, Chen-Yu Tsai, Rob Herring, Mark Rutland,
Catalin Marinas, Will Deacon, linux-arm-kernel, devicetree,
linux-kernel
This board has SPI flash. add spi flash support in device tree.
Tested on pine64 LTS.
Signed-off-by: Akash Gajjar <Akash_Gajjar@mentor.com>
---
.../arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
index abe179d..9af07db 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
@@ -134,6 +134,18 @@
regulator-name = "vcc-wifi";
};
+&spi0 {
+ status = "okay";
+
+ flash@0 {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ compatible = "winbond,w25q128", "jedec,spi-nor";
+ reg = <0x0>;
+ spi-max-frequency = <40000000>;
+ };
+};
+
&uart0 {
pinctrl-names = "default";
pinctrl-0 = <&uart0_pins_a>;
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: activate spi flash on pine64 LTS board
2018-07-26 6:51 [PATCH] arm64: dts: allwinner: activate spi flash on pine64 LTS board Akash Gajjar
@ 2018-07-26 7:29 ` Maxime Ripard
2018-07-26 7:31 ` Maxime Ripard
0 siblings, 1 reply; 4+ messages in thread
From: Maxime Ripard @ 2018-07-26 7:29 UTC (permalink / raw)
To: Akash Gajjar
Cc: icenowy, Chen-Yu Tsai, Rob Herring, Mark Rutland,
Catalin Marinas, Will Deacon, linux-arm-kernel, devicetree,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 382 bytes --]
1;5202;0c
On Thu, Jul 26, 2018 at 12:21:46PM +0530, Akash Gajjar wrote:
> This board has SPI flash. add spi flash support in device tree.
> Tested on pine64 LTS.
>
> Signed-off-by: Akash Gajjar <Akash_Gajjar@mentor.com>
Queued for 4.20, thanks!
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: activate spi flash on pine64 LTS board
2018-07-26 7:29 ` Maxime Ripard
@ 2018-07-26 7:31 ` Maxime Ripard
2018-07-26 8:00 ` Emmanuel Vadot
0 siblings, 1 reply; 4+ messages in thread
From: Maxime Ripard @ 2018-07-26 7:31 UTC (permalink / raw)
To: Akash Gajjar
Cc: icenowy, Chen-Yu Tsai, Rob Herring, Mark Rutland,
Catalin Marinas, Will Deacon, linux-arm-kernel, devicetree,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 615 bytes --]
On Thu, Jul 26, 2018 at 09:29:24AM +0200, Maxime Ripard wrote:
> 1;5202;0c
> On Thu, Jul 26, 2018 at 12:21:46PM +0530, Akash Gajjar wrote:
> > This board has SPI flash. add spi flash support in device tree.
> > Tested on pine64 LTS.
> >
> > Signed-off-by: Akash Gajjar <Akash_Gajjar@mentor.com>
>
> Queued for 4.20, thanks!
No, sorry, I ended up droping that patch.
You mention that the Pine64 LTS has an SPI flash, yet you change the
sopine baseboard dts. Why is that?
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: activate spi flash on pine64 LTS board
2018-07-26 7:31 ` Maxime Ripard
@ 2018-07-26 8:00 ` Emmanuel Vadot
0 siblings, 0 replies; 4+ messages in thread
From: Emmanuel Vadot @ 2018-07-26 8:00 UTC (permalink / raw)
To: Maxime Ripard
Cc: Akash Gajjar, Mark Rutland, devicetree, Catalin Marinas,
Will Deacon, linux-kernel, Chen-Yu Tsai, Rob Herring, icenowy,
linux-arm-kernel
On Thu, 26 Jul 2018 09:31:38 +0200
Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> On Thu, Jul 26, 2018 at 09:29:24AM +0200, Maxime Ripard wrote:
> > 1;5202;0c
> > On Thu, Jul 26, 2018 at 12:21:46PM +0530, Akash Gajjar wrote:
> > > This board has SPI flash. add spi flash support in device tree.
> > > Tested on pine64 LTS.
> > >
> > > Signed-off-by: Akash Gajjar <Akash_Gajjar@mentor.com>
> >
> > Queued for 4.20, thanks!
>
> No, sorry, I ended up droping that patch.
>
> You mention that the Pine64 LTS has an SPI flash, yet you change the
> sopine baseboard dts. Why is that?
There is still no dts for Pine64-LTS (Andre latest serie address that).
Note that the sopine.dtsi already have the SPI node, the patch is
present in sunxi/dt64-for-4.19
> Maxime
>
> --
> Maxime Ripard, Bootlin (formerly Free Electrons)
> Embedded Linux and Kernel engineering
> https://bootlin.com
--
Emmanuel Vadot <manu@bidouilliste.com> <manu@freebsd.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-07-26 8:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-26 6:51 [PATCH] arm64: dts: allwinner: activate spi flash on pine64 LTS board Akash Gajjar
2018-07-26 7:29 ` Maxime Ripard
2018-07-26 7:31 ` Maxime Ripard
2018-07-26 8:00 ` Emmanuel Vadot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).