* [PATCH] clk: samsung: Remove unused mout_user_aclk400_mcuisp_p4x12 variable
@ 2018-07-18 19:56 Krzysztof Kozlowski
2018-07-18 20:33 ` Tobias Jakobi
2018-07-26 15:17 ` Stephen Boyd
0 siblings, 2 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2018-07-18 19:56 UTC (permalink / raw)
To: Sylwester Nawrocki, Tomasz Figa, Chanwoo Choi, Michael Turquette,
Stephen Boyd, Krzysztof Kozlowski, linux-samsung-soc, linux-clk,
linux-arm-kernel, linux-kernel
Remove unused 'mout_user_aclk400_mcuisp_p4x12' variable to fix GCC warning:
drivers/clk/samsung/clk-exynos4412-isp.c:40:27: warning:
'mout_user_aclk400_mcuisp_p4x12' defined but not used [-Wunused-const-variable=]
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/clk/samsung/clk-exynos4412-isp.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/clk/samsung/clk-exynos4412-isp.c b/drivers/clk/samsung/clk-exynos4412-isp.c
index d5f1ccb36300..cfaa057035ad 100644
--- a/drivers/clk/samsung/clk-exynos4412-isp.c
+++ b/drivers/clk/samsung/clk-exynos4412-isp.c
@@ -37,8 +37,6 @@ static const unsigned long exynos4x12_clk_isp_save[] __initconst = {
E4X12_GATE_ISP1,
};
-PNAME(mout_user_aclk400_mcuisp_p4x12) = { "fin_pll", "div_aclk400_mcuisp", };
-
static struct samsung_div_clock exynos4x12_isp_div_clks[] = {
DIV(CLK_ISP_DIV_ISP0, "div_isp0", "aclk200", E4X12_DIV_ISP0, 0, 3),
DIV(CLK_ISP_DIV_ISP1, "div_isp1", "aclk200", E4X12_DIV_ISP0, 4, 3),
--
2.14.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] clk: samsung: Remove unused mout_user_aclk400_mcuisp_p4x12 variable
2018-07-18 19:56 [PATCH] clk: samsung: Remove unused mout_user_aclk400_mcuisp_p4x12 variable Krzysztof Kozlowski
@ 2018-07-18 20:33 ` Tobias Jakobi
2018-07-19 6:34 ` Krzysztof Kozlowski
2018-07-26 15:17 ` Stephen Boyd
1 sibling, 1 reply; 4+ messages in thread
From: Tobias Jakobi @ 2018-07-18 20:33 UTC (permalink / raw)
To: Krzysztof Kozlowski, Sylwester Nawrocki, Tomasz Figa,
Chanwoo Choi, Michael Turquette, Stephen Boyd, linux-samsung-soc,
linux-clk, linux-arm-kernel, linux-kernel
Speaking of the ISP clocks driver, I wonder why this one was never merged?
https://patches.linaro.org/patch/115531/
- Tobias
Krzysztof Kozlowski wrote:
> Remove unused 'mout_user_aclk400_mcuisp_p4x12' variable to fix GCC warning:
>
> drivers/clk/samsung/clk-exynos4412-isp.c:40:27: warning:
> 'mout_user_aclk400_mcuisp_p4x12' defined but not used [-Wunused-const-variable=]
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> drivers/clk/samsung/clk-exynos4412-isp.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/clk/samsung/clk-exynos4412-isp.c b/drivers/clk/samsung/clk-exynos4412-isp.c
> index d5f1ccb36300..cfaa057035ad 100644
> --- a/drivers/clk/samsung/clk-exynos4412-isp.c
> +++ b/drivers/clk/samsung/clk-exynos4412-isp.c
> @@ -37,8 +37,6 @@ static const unsigned long exynos4x12_clk_isp_save[] __initconst = {
> E4X12_GATE_ISP1,
> };
>
> -PNAME(mout_user_aclk400_mcuisp_p4x12) = { "fin_pll", "div_aclk400_mcuisp", };
> -
> static struct samsung_div_clock exynos4x12_isp_div_clks[] = {
> DIV(CLK_ISP_DIV_ISP0, "div_isp0", "aclk200", E4X12_DIV_ISP0, 0, 3),
> DIV(CLK_ISP_DIV_ISP1, "div_isp1", "aclk200", E4X12_DIV_ISP0, 4, 3),
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] clk: samsung: Remove unused mout_user_aclk400_mcuisp_p4x12 variable
2018-07-18 20:33 ` Tobias Jakobi
@ 2018-07-19 6:34 ` Krzysztof Kozlowski
0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2018-07-19 6:34 UTC (permalink / raw)
To: Tobias Jakobi
Cc: Sylwester Nawrocki, Tomasz Figa, Chanwoo Choi, Michael Turquette,
Stephen Boyd, linux-samsung-soc, linux-clk, linux-arm-kernel,
linux-kernel
On 18 July 2018 at 22:33, Tobias Jakobi <tjakobi@math.uni-bielefeld.de> wrote:
> Speaking of the ISP clocks driver, I wonder why this one was never merged?
> https://patches.linaro.org/patch/115531/
Thanks for reminding this!
It seems that Sylwester is out of office so we'll have to wait for reply.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] clk: samsung: Remove unused mout_user_aclk400_mcuisp_p4x12 variable
2018-07-18 19:56 [PATCH] clk: samsung: Remove unused mout_user_aclk400_mcuisp_p4x12 variable Krzysztof Kozlowski
2018-07-18 20:33 ` Tobias Jakobi
@ 2018-07-26 15:17 ` Stephen Boyd
1 sibling, 0 replies; 4+ messages in thread
From: Stephen Boyd @ 2018-07-26 15:17 UTC (permalink / raw)
To: Chanwoo Choi, Krzysztof Kozlowski, Michael Turquette,
Sylwester Nawrocki, Tomasz Figa, linux-arm-kernel, linux-clk,
linux-kernel, linux-samsung-soc
Quoting Krzysztof Kozlowski (2018-07-18 12:56:20)
> Remove unused 'mout_user_aclk400_mcuisp_p4x12' variable to fix GCC warning:
>
> drivers/clk/samsung/clk-exynos4412-isp.c:40:27: warning:
> 'mout_user_aclk400_mcuisp_p4x12' defined but not used [-Wunused-const-variable=]
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
Applied to clk-next
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-07-26 15:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-18 19:56 [PATCH] clk: samsung: Remove unused mout_user_aclk400_mcuisp_p4x12 variable Krzysztof Kozlowski
2018-07-18 20:33 ` Tobias Jakobi
2018-07-19 6:34 ` Krzysztof Kozlowski
2018-07-26 15:17 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).