LKML Archive on lore.kernel.org
 help / Atom feed
* [PATCH] net: Provide stub for __netif_set_xps_queue if there is no CONFIG_XPS
@ 2018-08-10  8:47 Krzysztof Kozlowski
  2018-08-10 17:22 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Kozlowski @ 2018-08-10  8:47 UTC (permalink / raw)
  To: David S. Miller, netdev, linux-kernel; +Cc: Andrei Vagin, Krzysztof Kozlowski

Building virtio_net driver without CONFIG_XPS fails with:

    drivers/net/virtio_net.c: In function ‘virtnet_set_affinity’:
    drivers/net/virtio_net.c:1910:3: error: implicit declaration of function ‘__netif_set_xps_queue’ [-Werror=implicit-function-declaration]
       __netif_set_xps_queue(vi->dev, mask, i, false);
       ^
Fixes: 4d99f6602cb5 ("net: allow to call netif_reset_xps_queues() under cpus_read_lock")
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 include/linux/netdevice.h | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 282e2e95ad5b..c38e774494a3 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -3412,6 +3412,12 @@ static inline int netif_set_xps_queue(struct net_device *dev,
 {
 	return 0;
 }
+static inline int __netif_set_xps_queue(struct net_device *dev,
+					const unsigned long *mask,
+					u16 index, bool is_rxqs_map)
+{
+	return 0;
+}
 #endif
 
 /**
-- 
2.7.4


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] net: Provide stub for __netif_set_xps_queue if there is no CONFIG_XPS
  2018-08-10  8:47 [PATCH] net: Provide stub for __netif_set_xps_queue if there is no CONFIG_XPS Krzysztof Kozlowski
@ 2018-08-10 17:22 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-08-10 17:22 UTC (permalink / raw)
  To: krzk; +Cc: netdev, linux-kernel, avagin

From: Krzysztof Kozlowski <krzk@kernel.org>
Date: Fri, 10 Aug 2018 10:47:43 +0200

> Building virtio_net driver without CONFIG_XPS fails with:
> 
>     drivers/net/virtio_net.c: In function ‘virtnet_set_affinity’:
>     drivers/net/virtio_net.c:1910:3: error: implicit declaration of function ‘__netif_set_xps_queue’ [-Werror=implicit-function-declaration]
>        __netif_set_xps_queue(vi->dev, mask, i, false);
>        ^
> Fixes: 4d99f6602cb5 ("net: allow to call netif_reset_xps_queues() under cpus_read_lock")
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

Applied, thank you.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-10  8:47 [PATCH] net: Provide stub for __netif_set_xps_queue if there is no CONFIG_XPS Krzysztof Kozlowski
2018-08-10 17:22 ` David Miller

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org linux-kernel@archiver.kernel.org
	public-inbox-index lkml


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox