* [PATCH 0/2] rtc: Use PTR_ERR_OR_ZERO to replace the open code @ 2018-08-13 11:31 zhong jiang 2018-08-13 11:31 ` [PATCH 1/2] rtc:rtc-digicolor: " zhong jiang 2018-08-13 11:31 ` [PATCH 2/2] rtc:rtc-ds1347: " zhong jiang 0 siblings, 2 replies; 8+ messages in thread From: zhong jiang @ 2018-08-13 11:31 UTC (permalink / raw) To: a.zummo, alexandre.belloni, baruch, linux-rtc, linux-kernel The issue is detected with the help of Coccinelle. zhong jiang (2): rtc:rtc-digicolor: Use PTR_ERR_OR_ZERO to replace the open code rtc:rtc-ds1347: Use PTR_ERR_OR_ZERO to replace the open code drivers/rtc/rtc-digicolor.c | 4 +--- drivers/rtc/rtc-ds1347.c | 5 +---- 2 files changed, 2 insertions(+), 7 deletions(-) -- 1.7.12.4 ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/2] rtc:rtc-digicolor: Use PTR_ERR_OR_ZERO to replace the open code 2018-08-13 11:31 [PATCH 0/2] rtc: Use PTR_ERR_OR_ZERO to replace the open code zhong jiang @ 2018-08-13 11:31 ` zhong jiang 2018-08-14 4:18 ` Baruch Siach 2018-08-14 16:15 ` Alexandre Belloni 2018-08-13 11:31 ` [PATCH 2/2] rtc:rtc-ds1347: " zhong jiang 1 sibling, 2 replies; 8+ messages in thread From: zhong jiang @ 2018-08-13 11:31 UTC (permalink / raw) To: a.zummo, alexandre.belloni, baruch, linux-rtc, linux-kernel PTR_ERR_OR_ZERO has implemented the if(IS_ERR(...)) + PTR_ERR, So just replace them rather than duplicating its implement. Signed-off-by: zhong jiang <zhongjiang@huawei.com> --- drivers/rtc/rtc-digicolor.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/rtc/rtc-digicolor.c b/drivers/rtc/rtc-digicolor.c index b253bf1..fd6850c 100644 --- a/drivers/rtc/rtc-digicolor.c +++ b/drivers/rtc/rtc-digicolor.c @@ -202,10 +202,8 @@ static int __init dc_rtc_probe(struct platform_device *pdev) platform_set_drvdata(pdev, rtc); rtc->rtc_dev = devm_rtc_device_register(&pdev->dev, pdev->name, &dc_rtc_ops, THIS_MODULE); - if (IS_ERR(rtc->rtc_dev)) - return PTR_ERR(rtc->rtc_dev); - return 0; + return PTR_ERR_OR_ZERO(rtc->rtc_dev); } static const struct of_device_id dc_dt_ids[] = { -- 1.7.12.4 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] rtc:rtc-digicolor: Use PTR_ERR_OR_ZERO to replace the open code 2018-08-13 11:31 ` [PATCH 1/2] rtc:rtc-digicolor: " zhong jiang @ 2018-08-14 4:18 ` Baruch Siach 2018-08-14 16:15 ` Alexandre Belloni 1 sibling, 0 replies; 8+ messages in thread From: Baruch Siach @ 2018-08-14 4:18 UTC (permalink / raw) To: zhong jiang; +Cc: a.zummo, alexandre.belloni, linux-rtc, linux-kernel Hi zhong, On Mon, Aug 13, 2018 at 07:31:24PM +0800, zhong jiang wrote: > PTR_ERR_OR_ZERO has implemented the if(IS_ERR(...)) + PTR_ERR, So > just replace them rather than duplicating its implement. > > Signed-off-by: zhong jiang <zhongjiang@huawei.com> Acked-by: Baruch Siach <baruch@tkos.co.il> Thanks, baruch > --- > drivers/rtc/rtc-digicolor.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/rtc/rtc-digicolor.c b/drivers/rtc/rtc-digicolor.c > index b253bf1..fd6850c 100644 > --- a/drivers/rtc/rtc-digicolor.c > +++ b/drivers/rtc/rtc-digicolor.c > @@ -202,10 +202,8 @@ static int __init dc_rtc_probe(struct platform_device *pdev) > platform_set_drvdata(pdev, rtc); > rtc->rtc_dev = devm_rtc_device_register(&pdev->dev, pdev->name, > &dc_rtc_ops, THIS_MODULE); > - if (IS_ERR(rtc->rtc_dev)) > - return PTR_ERR(rtc->rtc_dev); > > - return 0; > + return PTR_ERR_OR_ZERO(rtc->rtc_dev); > } > > static const struct of_device_id dc_dt_ids[] = { -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il - ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] rtc:rtc-digicolor: Use PTR_ERR_OR_ZERO to replace the open code 2018-08-13 11:31 ` [PATCH 1/2] rtc:rtc-digicolor: " zhong jiang 2018-08-14 4:18 ` Baruch Siach @ 2018-08-14 16:15 ` Alexandre Belloni 2018-08-15 7:16 ` zhong jiang 1 sibling, 1 reply; 8+ messages in thread From: Alexandre Belloni @ 2018-08-14 16:15 UTC (permalink / raw) To: zhong jiang; +Cc: a.zummo, baruch, linux-rtc, linux-kernel Hi, On 13/08/2018 19:31:24+0800, zhong jiang wrote: > PTR_ERR_OR_ZERO has implemented the if(IS_ERR(...)) + PTR_ERR, So > just replace them rather than duplicating its implement. > > Signed-off-by: zhong jiang <zhongjiang@huawei.com> > --- > drivers/rtc/rtc-digicolor.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/rtc/rtc-digicolor.c b/drivers/rtc/rtc-digicolor.c > index b253bf1..fd6850c 100644 > --- a/drivers/rtc/rtc-digicolor.c > +++ b/drivers/rtc/rtc-digicolor.c > @@ -202,10 +202,8 @@ static int __init dc_rtc_probe(struct platform_device *pdev) > platform_set_drvdata(pdev, rtc); > rtc->rtc_dev = devm_rtc_device_register(&pdev->dev, pdev->name, > &dc_rtc_ops, THIS_MODULE); > - if (IS_ERR(rtc->rtc_dev)) > - return PTR_ERR(rtc->rtc_dev); > > - return 0; > + return PTR_ERR_OR_ZERO(rtc->rtc_dev); As many other maintainers, I don't find that kind of change useful and I'm not taking them unless there are other improvements in the driver. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] rtc:rtc-digicolor: Use PTR_ERR_OR_ZERO to replace the open code 2018-08-14 16:15 ` Alexandre Belloni @ 2018-08-15 7:16 ` zhong jiang 2018-08-15 8:20 ` Alexandre Belloni 0 siblings, 1 reply; 8+ messages in thread From: zhong jiang @ 2018-08-15 7:16 UTC (permalink / raw) To: Alexandre Belloni; +Cc: a.zummo, baruch, linux-rtc, linux-kernel On 2018/8/15 0:15, Alexandre Belloni wrote: > Hi, > > On 13/08/2018 19:31:24+0800, zhong jiang wrote: >> PTR_ERR_OR_ZERO has implemented the if(IS_ERR(...)) + PTR_ERR, So >> just replace them rather than duplicating its implement. >> >> Signed-off-by: zhong jiang <zhongjiang@huawei.com> >> --- >> drivers/rtc/rtc-digicolor.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/drivers/rtc/rtc-digicolor.c b/drivers/rtc/rtc-digicolor.c >> index b253bf1..fd6850c 100644 >> --- a/drivers/rtc/rtc-digicolor.c >> +++ b/drivers/rtc/rtc-digicolor.c >> @@ -202,10 +202,8 @@ static int __init dc_rtc_probe(struct platform_device *pdev) >> platform_set_drvdata(pdev, rtc); >> rtc->rtc_dev = devm_rtc_device_register(&pdev->dev, pdev->name, >> &dc_rtc_ops, THIS_MODULE); >> - if (IS_ERR(rtc->rtc_dev)) >> - return PTR_ERR(rtc->rtc_dev); >> >> - return 0; >> + return PTR_ERR_OR_ZERO(rtc->rtc_dev); > As many other maintainers, I don't find that kind of change useful and > I'm not taking them unless there are other improvements in the driver. > > Hi, Alexandre The issue is detected with the help of Coccinelle. It simplify the code with specific function rather than duplicating its implementation. The patch clean up the code. of course, it is not a bug. if you do not care about it. I am ok with that. Thanks, zhong jiang ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] rtc:rtc-digicolor: Use PTR_ERR_OR_ZERO to replace the open code 2018-08-15 7:16 ` zhong jiang @ 2018-08-15 8:20 ` Alexandre Belloni 0 siblings, 0 replies; 8+ messages in thread From: Alexandre Belloni @ 2018-08-15 8:20 UTC (permalink / raw) To: zhong jiang; +Cc: a.zummo, baruch, linux-rtc, linux-kernel On 15/08/2018 15:16:56+0800, zhong jiang wrote: > On 2018/8/15 0:15, Alexandre Belloni wrote: > > Hi, > > > > On 13/08/2018 19:31:24+0800, zhong jiang wrote: > >> PTR_ERR_OR_ZERO has implemented the if(IS_ERR(...)) + PTR_ERR, So > >> just replace them rather than duplicating its implement. > >> > >> Signed-off-by: zhong jiang <zhongjiang@huawei.com> > >> --- > >> drivers/rtc/rtc-digicolor.c | 4 +--- > >> 1 file changed, 1 insertion(+), 3 deletions(-) > >> > >> diff --git a/drivers/rtc/rtc-digicolor.c b/drivers/rtc/rtc-digicolor.c > >> index b253bf1..fd6850c 100644 > >> --- a/drivers/rtc/rtc-digicolor.c > >> +++ b/drivers/rtc/rtc-digicolor.c > >> @@ -202,10 +202,8 @@ static int __init dc_rtc_probe(struct platform_device *pdev) > >> platform_set_drvdata(pdev, rtc); > >> rtc->rtc_dev = devm_rtc_device_register(&pdev->dev, pdev->name, > >> &dc_rtc_ops, THIS_MODULE); > >> - if (IS_ERR(rtc->rtc_dev)) > >> - return PTR_ERR(rtc->rtc_dev); > >> > >> - return 0; > >> + return PTR_ERR_OR_ZERO(rtc->rtc_dev); > > As many other maintainers, I don't find that kind of change useful and > > I'm not taking them unless there are other improvements in the driver. > > > > > Hi, Alexandre > > The issue is detected with the help of Coccinelle. It simplify the code with specific > function rather than duplicating its implementation. > > The patch clean up the code. of course, it is not a bug. if you do not care about it. > I am ok with that. > But this does not simplify or make the code clearer and as soon as you need to add code between the devm_rtc_device_register call and the end of the function, the patch will need to be undone. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 2/2] rtc:rtc-ds1347: Use PTR_ERR_OR_ZERO to replace the open code 2018-08-13 11:31 [PATCH 0/2] rtc: Use PTR_ERR_OR_ZERO to replace the open code zhong jiang 2018-08-13 11:31 ` [PATCH 1/2] rtc:rtc-digicolor: " zhong jiang @ 2018-08-13 11:31 ` zhong jiang 2018-08-14 4:18 ` Baruch Siach 1 sibling, 1 reply; 8+ messages in thread From: zhong jiang @ 2018-08-13 11:31 UTC (permalink / raw) To: a.zummo, alexandre.belloni, baruch, linux-rtc, linux-kernel PTR_ERR_OR_ZERO has implemented the if(IS_ERR(...)) + PTR_ERR, So just replace them rather than duplicating its implement. Signed-off-by: zhong jiang <zhongjiang@huawei.com> --- drivers/rtc/rtc-ds1347.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/rtc/rtc-ds1347.c b/drivers/rtc/rtc-ds1347.c index 938512c..b97b67f 100644 --- a/drivers/rtc/rtc-ds1347.c +++ b/drivers/rtc/rtc-ds1347.c @@ -155,10 +155,7 @@ static int ds1347_probe(struct spi_device *spi) rtc = devm_rtc_device_register(&spi->dev, "ds1347", &ds1347_rtc_ops, THIS_MODULE); - if (IS_ERR(rtc)) - return PTR_ERR(rtc); - - return 0; + return PTR_ERR_OR_ZERO(rtc); } static struct spi_driver ds1347_driver = { -- 1.7.12.4 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] rtc:rtc-ds1347: Use PTR_ERR_OR_ZERO to replace the open code 2018-08-13 11:31 ` [PATCH 2/2] rtc:rtc-ds1347: " zhong jiang @ 2018-08-14 4:18 ` Baruch Siach 0 siblings, 0 replies; 8+ messages in thread From: Baruch Siach @ 2018-08-14 4:18 UTC (permalink / raw) To: zhong jiang; +Cc: a.zummo, alexandre.belloni, linux-rtc, linux-kernel Hi zhong, On Mon, Aug 13, 2018 at 07:31:25PM +0800, zhong jiang wrote: > PTR_ERR_OR_ZERO has implemented the if(IS_ERR(...)) + PTR_ERR, So > just replace them rather than duplicating its implement. > > Signed-off-by: zhong jiang <zhongjiang@huawei.com> Acked-by: Baruch Siach <baruch@tkos.co.il> Thanks, baruch > --- > drivers/rtc/rtc-ds1347.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/rtc/rtc-ds1347.c b/drivers/rtc/rtc-ds1347.c > index 938512c..b97b67f 100644 > --- a/drivers/rtc/rtc-ds1347.c > +++ b/drivers/rtc/rtc-ds1347.c > @@ -155,10 +155,7 @@ static int ds1347_probe(struct spi_device *spi) > rtc = devm_rtc_device_register(&spi->dev, "ds1347", > &ds1347_rtc_ops, THIS_MODULE); > > - if (IS_ERR(rtc)) > - return PTR_ERR(rtc); > - > - return 0; > + return PTR_ERR_OR_ZERO(rtc); > } > > static struct spi_driver ds1347_driver = { -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il - ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2018-08-15 8:21 UTC | newest] Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-08-13 11:31 [PATCH 0/2] rtc: Use PTR_ERR_OR_ZERO to replace the open code zhong jiang 2018-08-13 11:31 ` [PATCH 1/2] rtc:rtc-digicolor: " zhong jiang 2018-08-14 4:18 ` Baruch Siach 2018-08-14 16:15 ` Alexandre Belloni 2018-08-15 7:16 ` zhong jiang 2018-08-15 8:20 ` Alexandre Belloni 2018-08-13 11:31 ` [PATCH 2/2] rtc:rtc-ds1347: " zhong jiang 2018-08-14 4:18 ` Baruch Siach
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).