* [PATCH] x86: i8259: Add missing include file
@ 2018-08-15 20:22 Guenter Roeck
2018-08-15 20:45 ` Linus Torvalds
0 siblings, 1 reply; 2+ messages in thread
From: Guenter Roeck @ 2018-08-15 20:22 UTC (permalink / raw)
To: Thomas Gleixner
Cc: x86, linux-kernel, Linus Torvalds, Greg Kroah-Hartman,
Nicolai Stange, Sebastian Gottschall, Sven Joachim,
Guenter Roeck
i8259.h uses inb/outb and thus needs to include asm/io.h to avoid the
following build error, as seen with x86_64:defconfig and CONFIG_SMP=n.
In file included from drivers/rtc/rtc-cmos.c:45:0:
arch/x86/include/asm/i8259.h: In function 'inb_pic':
arch/x86/include/asm/i8259.h:32:24: error:
implicit declaration of function 'inb'
arch/x86/include/asm/i8259.h: In function 'outb_pic':
arch/x86/include/asm/i8259.h:45:2: error:
implicit declaration of function 'outb'
Reported-by: Sebastian Gottschall <s.gottschall@dd-wrt.com>
Suggested-by: Sebastian Gottschall <s.gottschall@dd-wrt.com>
Fixes: 447ae3166702 ("x86: Don't include linux/irq.h from asm/hardirq.h")
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
I have not seen a patch fly by, so here it is.
arch/x86/include/asm/i8259.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/include/asm/i8259.h b/arch/x86/include/asm/i8259.h
index 5cdcdbd4d892..89789e8c80f6 100644
--- a/arch/x86/include/asm/i8259.h
+++ b/arch/x86/include/asm/i8259.h
@@ -3,6 +3,7 @@
#define _ASM_X86_I8259_H
#include <linux/delay.h>
+#include <asm/io.h>
extern unsigned int cached_irq_mask;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] x86: i8259: Add missing include file
2018-08-15 20:22 [PATCH] x86: i8259: Add missing include file Guenter Roeck
@ 2018-08-15 20:45 ` Linus Torvalds
0 siblings, 0 replies; 2+ messages in thread
From: Linus Torvalds @ 2018-08-15 20:45 UTC (permalink / raw)
To: Guenter Roeck
Cc: Thomas Gleixner, the arch/x86 maintainers,
Linux Kernel Mailing List, Greg Kroah-Hartman, nstange,
s.gottschall, Sven Joachim
On Wed, Aug 15, 2018 at 1:22 PM Guenter Roeck <linux@roeck-us.net> wrote:
>
> I have not seen a patch fly by, so here it is.
Applied.
Linus
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-08-15 20:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-15 20:22 [PATCH] x86: i8259: Add missing include file Guenter Roeck
2018-08-15 20:45 ` Linus Torvalds
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).