* [PATCH] mailbox: mediatek: Add check for possible failure of kzalloc
@ 2018-08-21 10:22 Houlong Wei
2018-08-21 15:06 ` Philipp Zabel
0 siblings, 1 reply; 2+ messages in thread
From: Houlong Wei @ 2018-08-21 10:22 UTC (permalink / raw)
To: Jassi Brar, Matthias Brugger
Cc: Daniel Kurtz, linux-kernel, linux-arm-kernel, linux-mediatek,
srv_heupstream, Sascha Hauer, Philipp Zabel, Nicolas Boichat,
CK HU, Bibby Hsieh, YT Shen, Daoyuan Huang, Jiaguang Zhang,
Dennis-YC Hsieh, Monica Wang, Houlong Wei, HS Liao, ginny.chen,
enzhu.wang, Dan Carpenter
The patch 623a6143a845("mailbox: mediatek: Add Mediatek CMDQ driver")
introduce the following static checker warning:
drivers/mailbox/mtk-cmdq-mailbox.c:366 cmdq_mbox_send_data()
error: potential null dereference 'task'. (kzalloc returns null)
Fixes: 623a6143a845 ("mailbox: mediatek: Add Mediatek CMDQ driver")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Houlong Wei <houlong.wei@mediatek.com>
---
drivers/mailbox/mtk-cmdq-mailbox.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c
index aec46d5..f7cc29c 100644
--- a/drivers/mailbox/mtk-cmdq-mailbox.c
+++ b/drivers/mailbox/mtk-cmdq-mailbox.c
@@ -363,6 +363,9 @@ static int cmdq_mbox_send_data(struct mbox_chan *chan, void *data)
WARN_ON(cmdq->suspended);
task = kzalloc(sizeof(*task), GFP_ATOMIC);
+ if (!task)
+ return -ENOMEM;
+
task->cmdq = cmdq;
INIT_LIST_HEAD(&task->list_entry);
task->pa_base = pkt->pa_base;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mailbox: mediatek: Add check for possible failure of kzalloc
2018-08-21 10:22 [PATCH] mailbox: mediatek: Add check for possible failure of kzalloc Houlong Wei
@ 2018-08-21 15:06 ` Philipp Zabel
0 siblings, 0 replies; 2+ messages in thread
From: Philipp Zabel @ 2018-08-21 15:06 UTC (permalink / raw)
To: Houlong Wei, Jassi Brar, Matthias Brugger
Cc: Dan Carpenter, Nicolas Boichat, srv_heupstream, Daoyuan Huang,
linux-kernel, Daniel Kurtz, HS Liao, Dennis-YC Hsieh, YT Shen,
Monica Wang, linux-mediatek, Sascha Hauer, enzhu.wang, CK HU,
Jiaguang Zhang, Bibby Hsieh, linux-arm-kernel, ginny.chen
On Tue, 2018-08-21 at 18:22 +0800, Houlong Wei wrote:
> The patch 623a6143a845("mailbox: mediatek: Add Mediatek CMDQ driver")
> introduce the following static checker warning:
> drivers/mailbox/mtk-cmdq-mailbox.c:366 cmdq_mbox_send_data()
> error: potential null dereference 'task'. (kzalloc returns null)
>
> Fixes: 623a6143a845 ("mailbox: mediatek: Add Mediatek CMDQ driver")
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Houlong Wei <houlong.wei@mediatek.com>
> ---
> drivers/mailbox/mtk-cmdq-mailbox.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c
> index aec46d5..f7cc29c 100644
> --- a/drivers/mailbox/mtk-cmdq-mailbox.c
> +++ b/drivers/mailbox/mtk-cmdq-mailbox.c
> @@ -363,6 +363,9 @@ static int cmdq_mbox_send_data(struct mbox_chan *chan, void *data)
> WARN_ON(cmdq->suspended);
>
> task = kzalloc(sizeof(*task), GFP_ATOMIC);
> + if (!task)
> + return -ENOMEM;
> +
> task->cmdq = cmdq;
> INIT_LIST_HEAD(&task->list_entry);
> task->pa_base = pkt->pa_base;
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
regards
Philipp
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-08-21 15:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-21 10:22 [PATCH] mailbox: mediatek: Add check for possible failure of kzalloc Houlong Wei
2018-08-21 15:06 ` Philipp Zabel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).