linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] x86/intel_rdt: Show missing resctrl mount options
@ 2018-09-05  1:29 Fenghua Yu
  2018-09-08 12:07 ` Thomas Gleixner
  0 siblings, 1 reply; 3+ messages in thread
From: Fenghua Yu @ 2018-09-05  1:29 UTC (permalink / raw)
  To: Thomas Gleixner, Ingo Molnar, H Peter Anvin, Tony Luck
  Cc: linux-kernel, x86, Fenghua Yu, Xiaochen Shen

In resctrl filesystem, we have some mount options to enable
L3/L2 CDP and MBA Software Controller features if platform supports them:
     mount -t resctrl resctrl [-o cdp[,cdpl2][,mba_MBps]] /sys/fs/resctrl

But currently only "cdp" option can be displayed. "cdpl2" and "mba_MBps"
options are not showed even when they are active mount options.

Before this patch:
     #mount -t resctrl resctrl -o cdp,mba_MBps /sys/fs/resctrl
     #grep resctrl /proc/mounts
     /sys/fs/resctrl /sys/fs/resctrl resctrl rw,relatime,cdp 0 0
After this patch:
     #mount -t resctrl resctrl -o cdp,mba_MBps /sys/fs/resctrl
     #grep resctrl /proc/mountts
     /sys/fs/resctrl /sys/fs/resctrl resctrl rw,relatime,cdp,mba_MBps 0 0

Signed-off-by: Xiaochen Shen <xiaochen.shen@intel.com>
Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
---
 arch/x86/kernel/cpu/intel_rdt_rdtgroup.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c b/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c
index b799c00bef09..82459a41fa84 100644
--- a/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c
+++ b/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c
@@ -2760,6 +2760,13 @@ static int rdtgroup_show_options(struct seq_file *seq, struct kernfs_root *kf)
 {
 	if (rdt_resources_all[RDT_RESOURCE_L3DATA].alloc_enabled)
 		seq_puts(seq, ",cdp");
+
+	if (rdt_resources_all[RDT_RESOURCE_L2DATA].alloc_enabled)
+		seq_puts(seq, ",cdpl2");
+
+	if (is_mba_sc(&rdt_resources_all[RDT_RESOURCE_MBA]))
+		seq_puts(seq, ",mba_MBps");
+
 	return 0;
 }
 
-- 
2.18.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] x86/intel_rdt: Show missing resctrl mount options
  2018-09-05  1:29 [PATCH] x86/intel_rdt: Show missing resctrl mount options Fenghua Yu
@ 2018-09-08 12:07 ` Thomas Gleixner
  2018-09-12 23:54   ` Fenghua Yu
  0 siblings, 1 reply; 3+ messages in thread
From: Thomas Gleixner @ 2018-09-08 12:07 UTC (permalink / raw)
  To: Fenghua Yu
  Cc: Ingo Molnar, H Peter Anvin, Tony Luck, linux-kernel, x86, Xiaochen Shen

On Tue, 4 Sep 2018, Fenghua Yu wrote:
> 
> Signed-off-by: Xiaochen Shen <xiaochen.shen@intel.com>
> Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>

Sigh. Am I supposed to assume that this patch is authored by Xiaochen?

Come on, you are around long enough to do it proper.

Thanks,

	tglx

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] x86/intel_rdt: Show missing resctrl mount options
  2018-09-08 12:07 ` Thomas Gleixner
@ 2018-09-12 23:54   ` Fenghua Yu
  0 siblings, 0 replies; 3+ messages in thread
From: Fenghua Yu @ 2018-09-12 23:54 UTC (permalink / raw)
  To: Thomas Gleixner
  Cc: Fenghua Yu, Ingo Molnar, H Peter Anvin, Tony Luck, linux-kernel,
	x86, Xiaochen Shen

On Sat, Sep 08, 2018 at 02:07:41PM +0200, Thomas Gleixner wrote:
> On Tue, 4 Sep 2018, Fenghua Yu wrote:
> > 
> > Signed-off-by: Xiaochen Shen <xiaochen.shen@intel.com>
> > Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
> 
> Sigh. Am I supposed to assume that this patch is authored by Xiaochen?

Yes, Xiaochen is the author. Sorry for the mistake.

I just now sent out v2 patch to use right author Xiaochen in the patch.

Thanks.

-Fenghua

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-09-12 23:56 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-05  1:29 [PATCH] x86/intel_rdt: Show missing resctrl mount options Fenghua Yu
2018-09-08 12:07 ` Thomas Gleixner
2018-09-12 23:54   ` Fenghua Yu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).