linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] usb: dwc2: disable power_down on Amlogic devices
@ 2018-09-05 14:55 Christian Hewitt
  2018-09-06  8:36 ` Minas Harutyunyan
  0 siblings, 1 reply; 2+ messages in thread
From: Christian Hewitt @ 2018-09-05 14:55 UTC (permalink / raw)
  Cc: christianshewitt, hal, arthur.petrosyan, Minas Harutyunyan,
	Greg Kroah-Hartman, linux-usb, linux-kernel

USB devices work when connected to Amlogic GXBB hardware before power
on, but not when connected after boot (hotplugged). With this patch
hotplugging works again. This change was copied from the Rockchip
patch here: (https://marc.info/?l=linux-usb&m=153205711616460&w=2)

Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
---
 drivers/usb/dwc2/params.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
index bf7052e..93561a2 100644
--- a/drivers/usb/dwc2/params.c
+++ b/drivers/usb/dwc2/params.c
@@ -110,6 +110,7 @@ static void dwc2_set_amlogic_params(struct dwc2_hsotg *hsotg)
 	p->phy_type = DWC2_PHY_TYPE_PARAM_UTMI;
 	p->ahbcfg = GAHBCFG_HBSTLEN_INCR8 <<
 		GAHBCFG_HBSTLEN_SHIFT;
+	p->power_down = false;
 }
 
 static void dwc2_set_amcc_params(struct dwc2_hsotg *hsotg)
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] usb: dwc2: disable power_down on Amlogic devices
  2018-09-05 14:55 [PATCH] usb: dwc2: disable power_down on Amlogic devices Christian Hewitt
@ 2018-09-06  8:36 ` Minas Harutyunyan
  0 siblings, 0 replies; 2+ messages in thread
From: Minas Harutyunyan @ 2018-09-06  8:36 UTC (permalink / raw)
  To: Christian Hewitt
  Cc: hal, arthur.petrosyan, Minas Harutyunyan, Greg Kroah-Hartman,
	linux-usb, linux-kernel

On 9/5/2018 6:56 PM, Christian Hewitt wrote:
> USB devices work when connected to Amlogic GXBB hardware before power
> on, but not when connected after boot (hotplugged). With this patch
> hotplugging works again. This change was copied from the Rockchip
> patch here: (https://urldefense.proofpoint.com/v2/url?u=https-3A__marc.info_-3Fl-3Dlinux-2Dusb-26m-3D153205711616460-26w-3D2&d=DwIBAg&c=DPL6_X_6JkXFx7AXWqB0tg&r=cQBKt4q-qzNVC53rNAwuwplH23V61rHQhhULvdLA0U8&m=m5T_SsLG-_isQDyjrHuiVqJWdEqZ21Lcr70lObiPwrg&s=D26wJzWeREBz6_XcmdTqo8k69mPRqGaIbRWl_77Ns3c&e=)
> 
> Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>

Acked-by: Minas Harutyunyan <hminas@synopsys.com>

> ---
>   drivers/usb/dwc2/params.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
> index bf7052e..93561a2 100644
> --- a/drivers/usb/dwc2/params.c
> +++ b/drivers/usb/dwc2/params.c
> @@ -110,6 +110,7 @@ static void dwc2_set_amlogic_params(struct dwc2_hsotg *hsotg)
>   	p->phy_type = DWC2_PHY_TYPE_PARAM_UTMI;
>   	p->ahbcfg = GAHBCFG_HBSTLEN_INCR8 <<
>   		GAHBCFG_HBSTLEN_SHIFT;
> +	p->power_down = false;
>   }
>   
>   static void dwc2_set_amcc_params(struct dwc2_hsotg *hsotg)
> 


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-09-06  8:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-05 14:55 [PATCH] usb: dwc2: disable power_down on Amlogic devices Christian Hewitt
2018-09-06  8:36 ` Minas Harutyunyan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).