From: "Heiko Stübner" <heiko@sntech.de>
To: Elaine Zhang <zhangqing@rock-chips.com>
Cc: cl@rock-chips.com, robh+dt@kernel.org, mark.rutland@arm.com,
zhengxing@rock-chips.com, andy.yan@rock-chips.com,
jay.xu@rock-chips.com, matthias.bgg@gmail.com,
paweljarosz3691@gmail.com, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
wsa@the-dreams.de, linux-i2c@vger.kernel.org, jic23@kernel.org,
knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
wxt@rock-chips.com, david.wu@rock-chips.com,
linux-iio@vger.kernel.org, shawn.lin@rock-chips.com,
akpm@linux-foundation.org, dianders@chromium.org,
yamada.masahiro@socionext.com, catalin.marinas@arm.com,
will.deacon@arm.com, afaerber@suse.de, shawnguo@kernel.org,
khilman@baylibre.com, arnd@arndb.de, fabio.estevam@nxp.com,
kever.yang@rock-chips.com, tony.xie@rock-chips.com,
huangtao@rock-chips.com, yhx@rock-chips.com,
rocky.hao@rock-chips.com
Subject: Re: [PATCH v2 4/6] arm64: dts: rockchip: add core dtsi file for RK3328 SoCs
Date: Wed, 22 Mar 2017 12:06:46 +0100 [thread overview]
Message-ID: <1536448.abPucmTQ1N@diego> (raw)
In-Reply-To: <58D250BC.4040609@rock-chips.com>
Am Mittwoch, 22. März 2017, 18:23:56 CET schrieb Elaine Zhang:
> On 03/21/2017 04:55 PM, Heiko Stübner wrote:
> > Am Donnerstag, 16. März 2017, 21:17:22 CET schrieb cl@rock-chips.com:
> >> + cru: clock-controller@ff440000 {
> >> + compatible = "rockchip,rk3328-cru", "rockchip,cru", "syscon";
> >> + reg = <0x0 0xff440000 0x0 0x1000>;
> >> + rockchip,grf = <&grf>;
> >> + #clock-cells = <1>;
> >> + #reset-cells = <1>;
> >> + assigned-clocks =
> >> + <&cru DCLK_LCDC>, <&cru SCLK_PDM>,
> >> + <&cru SCLK_RTC32K>, <&cru SCLK_UART0>,
> >> + <&cru SCLK_UART1>, <&cru SCLK_UART2>,
> >> + <&cru ACLK_BUS_PRE>, <&cru ACLK_PERI_PRE>,
> >> + <&cru ACLK_VIO_PRE>, <&cru ACLK_RGA_PRE>,
> >> + <&cru ACLK_VOP_PRE>, <&cru ACLK_RKVDEC_PRE>,
> >> + <&cru ACLK_RKVENC>, <&cru ACLK_VPU_PRE>,
> >> + <&cru SCLK_VDEC_CABAC>, <&cru SCLK_VDEC_CORE>,
> >> + <&cru SCLK_VENC_CORE>, <&cru SCLK_VENC_DSP>,
> >> + <&cru SCLK_SDIO>, <&cru SCLK_TSP>,
> >> + <&cru SCLK_WIFI>, <&cru ARMCLK>,
> >> + <&cru PLL_GPLL>, <&cru PLL_CPLL>,
> >> + <&cru ACLK_BUS_PRE>, <&cru HCLK_BUS_PRE>,
> >> + <&cru PCLK_BUS_PRE>, <&cru ACLK_PERI_PRE>,
> >> + <&cru HCLK_PERI>, <&cru PCLK_PERI>,
> >> + <&cru ACLK_VIO_PRE>, <&cru HCLK_VIO_PRE>,
> >> + <&cru ACLK_RGA_PRE>, <&cru SCLK_RGA>,
> >> + <&cru ACLK_VOP_PRE>, <&cru ACLK_RKVDEC_PRE>,
> >> + <&cru ACLK_RKVENC>, <&cru ACLK_VPU_PRE>,
> >> + <&cru SCLK_VDEC_CABAC>, <&cru SCLK_VDEC_CORE>,
> >> + <&cru SCLK_VENC_CORE>, <&cru SCLK_VENC_DSP>,
> >> + <&cru SCLK_EFUSE>, <&cru PCLK_DDR>,
> >> + <&cru ACLK_GMAC>, <&cru PCLK_GMAC>,
> >> + <&cru SCLK_RTC32K>, <&cru SCLK_USB3OTG_SUSPEND>;
> >
> > that list is way to long.
> > Device-specific clocks should be inited in their respective device nodes.
>
> Cpll init freq is 1200M, is too high. we need set cpll child clk div
> first,and then set cpll freq.
> After pll init, others clk init freq can inited in their device node.
thanks, that is a nice explanation. Please put it into a comment above the
assigned-clocks property, so that we can keep that knowledge around for later
times :-) .
Thanks
Heiko
next prev parent reply other threads:[~2017-03-22 11:07 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-16 13:17 [PATCH v2 0/6] initialize dtsi file and dts file for RK3328 SoCs cl
2017-03-16 13:17 ` [PATCH v2 1/6] dt-bindings: iio: rockchip-saradc: add support for rk3328 cl
2017-03-16 13:36 ` Heiko Stuebner
2017-03-24 2:13 ` Rob Herring
2017-03-16 13:17 ` [PATCH v2 2/6] dt-bindings: i2c: rk3x: " cl
2017-03-16 13:37 ` Heiko Stuebner
2017-03-22 9:10 ` Wolfram Sang
2017-03-16 13:17 ` [PATCH v2 3/6] dt-bindings: soc: rockchip: grf: " cl
2017-03-24 2:14 ` Rob Herring
2017-03-16 13:17 ` [PATCH v2 4/6] arm64: dts: rockchip: add core dtsi file for RK3328 SoCs cl
2017-03-21 8:55 ` Heiko Stübner
2017-03-22 10:23 ` Elaine Zhang
2017-03-22 11:06 ` Heiko Stübner [this message]
2017-03-23 2:06 ` 陈亮
2017-03-23 9:16 ` Heiko Stübner
2017-03-23 3:33 ` 陈亮
2017-03-24 6:31 ` 陈亮
2017-03-24 7:12 ` Heiko Stübner
2017-03-22 18:09 ` Sudeep Holla
2017-03-23 2:15 ` 陈亮
2017-03-16 13:22 ` [PATCH v2 5/6] arm64: dts: rockchip: add dts file for RK3328 cl
2017-03-16 13:23 ` [PATCH v2 6/6] dt-bindings: document rockchip rk3328-evb board cl
2017-03-24 2:15 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1536448.abPucmTQ1N@diego \
--to=heiko@sntech.de \
--cc=afaerber@suse.de \
--cc=akpm@linux-foundation.org \
--cc=andy.yan@rock-chips.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=cl@rock-chips.com \
--cc=david.wu@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=fabio.estevam@nxp.com \
--cc=huangtao@rock-chips.com \
--cc=jay.xu@rock-chips.com \
--cc=jic23@kernel.org \
--cc=kever.yang@rock-chips.com \
--cc=khilman@baylibre.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=paweljarosz3691@gmail.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=rocky.hao@rock-chips.com \
--cc=shawn.lin@rock-chips.com \
--cc=shawnguo@kernel.org \
--cc=tony.xie@rock-chips.com \
--cc=will.deacon@arm.com \
--cc=wsa@the-dreams.de \
--cc=wxt@rock-chips.com \
--cc=yamada.masahiro@socionext.com \
--cc=yhx@rock-chips.com \
--cc=zhangqing@rock-chips.com \
--cc=zhengxing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).