From: 陈亮 <cl@rock-chips.com>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: robh+dt@kernel.org, mark.rutland@arm.com,
zhengxing@rock-chips.com, andy.yan@rock-chips.com,
jay.xu@rock-chips.com, matthias.bgg@gmail.com,
paweljarosz3691@gmail.com, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
wsa@the-dreams.de, linux-i2c@vger.kernel.org, jic23@kernel.org,
knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
wxt@rock-chips.com, david.wu@rock-chips.com,
linux-iio@vger.kernel.org, shawn.lin@rock-chips.com,
akpm@linux-foundation.org, dianders@chromium.org,
yamada.masahiro@socionext.com, catalin.marinas@arm.com,
will.deacon@arm.com, afaerber@suse.de, shawnguo@kernel.org,
khilman@baylibre.com, arnd@arndb.de, fabio.estevam@nxp.com,
zhangqing@rock-chips.com, kever.yang@rock-chips.com,
tony.xie@rock-chips.com, huangtao@rock-chips.com,
yhx@rock-chips.com, rocky.hao@rock-chips.com
Subject: Re: [PATCH v2 4/6] arm64: dts: rockchip: add core dtsi file for RK3328 SoCs
Date: Thu, 23 Mar 2017 10:06:02 +0800 [thread overview]
Message-ID: <58D32D8A.1030506@rock-chips.com> (raw)
In-Reply-To: <14610453.rKm3MBREMz@diego>
Hi, Heiko
在 2017年03月21日 16:55, Heiko Stübner 写道:
> Hi,
>
> Am Donnerstag, 16. März 2017, 21:17:22 CET schrieb cl@rock-chips.com:
>> From: Liang Chen <cl@rock-chips.com>
>>
>> This patch adds core dtsi file for Rockchip RK3328 SoCs.
>>
>> Signed-off-by: Liang Chen <cl@rock-chips.com>
>> ---
>> arch/arm64/boot/dts/rockchip/rk3328.dtsi | 1362
>> ++++++++++++++++++++++++++++++ 1 file changed, 1362 insertions(+)
>> create mode 100644 arch/arm64/boot/dts/rockchip/rk3328.dtsi
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi
>> b/arch/arm64/boot/dts/rockchip/rk3328.dtsi new file mode 100644
>> index 0000000..a92955c
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
>> @@ -0,0 +1,1362 @@
>> +/*
>> + * Copyright (c) 2017 Fuzhou Rockchip Electronics Co., Ltd
>> + *
>> + * This file is dual-licensed: you can use it either under the terms
>> + * of the GPL or the X11 license, at your option. Note that this dual
>> + * licensing only applies to this file, and not this project as a
>> + * whole.
>> + *
>> + * a) This library is free software; you can redistribute it and/or
>> + * modify it under the terms of the GNU General Public License as
>> + * published by the Free Software Foundation; either version 2 of the
>> + * License, or (at your option) any later version.
>> + *
>> + * This library is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>> + * GNU General Public License for more details.
>> + *
>> + * Or, alternatively,
>> + *
>> + * b) Permission is hereby granted, free of charge, to any person
>> + * obtaining a copy of this software and associated documentation
>> + * files (the "Software"), to deal in the Software without
>> + * restriction, including without limitation the rights to use,
>> + * copy, modify, merge, publish, distribute, sublicense, and/or
>> + * sell copies of the Software, and to permit persons to whom the
>> + * Software is furnished to do so, subject to the following
>> + * conditions:
>> + *
>> + * The above copyright notice and this permission notice shall be
>> + * included in all copies or substantial portions of the Software.
>> + *
>> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
>> + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
>> + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
>> + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
>> + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
>> + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
>> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
>> + * OTHER DEALINGS IN THE SOFTWARE.
>> + */
>> +
>> +#include <dt-bindings/clock/rk3328-cru.h>
>> +#include <dt-bindings/gpio/gpio.h>
>> +#include <dt-bindings/interrupt-controller/arm-gic.h>
>> +#include <dt-bindings/interrupt-controller/irq.h>
>> +#include <dt-bindings/pinctrl/rockchip.h>
>> +#include <dt-bindings/soc/rockchip,boot-mode.h>
>> +#include <dt-bindings/power/rk3328-power.h>
>> +
>> +/ {
>> + compatible = "rockchip,rk3328";
>> +
>> + interrupt-parent = <&gic>;
>> + #address-cells = <2>;
>> + #size-cells = <2>;
>> +
>> + aliases {
>> + serial0 = &uart0;
>> + serial1 = &uart1;
>> + serial2 = &uart2;
>> + i2c0 = &i2c0;
>> + i2c1 = &i2c1;
>> + i2c2 = &i2c2;
>> + i2c3 = &i2c3;
>> + };
>> +
>> + cpus {
>> + #address-cells = <2>;
> #address-cells = <1>? You most likely don't need the 2 field cpu regs?
This is likely copy from juno board of arm, and i find that #address-cells = <1> in some boards and #address-cells = <2> in the other boards.
All of ROCKCHIP Socs set #address-cells = <2>, so we set #address-cells = <2> to keep compatibility?
next prev parent reply other threads:[~2017-03-23 2:09 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-16 13:17 [PATCH v2 0/6] initialize dtsi file and dts file for RK3328 SoCs cl
2017-03-16 13:17 ` [PATCH v2 1/6] dt-bindings: iio: rockchip-saradc: add support for rk3328 cl
2017-03-16 13:36 ` Heiko Stuebner
2017-03-24 2:13 ` Rob Herring
2017-03-16 13:17 ` [PATCH v2 2/6] dt-bindings: i2c: rk3x: " cl
2017-03-16 13:37 ` Heiko Stuebner
2017-03-22 9:10 ` Wolfram Sang
2017-03-16 13:17 ` [PATCH v2 3/6] dt-bindings: soc: rockchip: grf: " cl
2017-03-24 2:14 ` Rob Herring
2017-03-16 13:17 ` [PATCH v2 4/6] arm64: dts: rockchip: add core dtsi file for RK3328 SoCs cl
2017-03-21 8:55 ` Heiko Stübner
2017-03-22 10:23 ` Elaine Zhang
2017-03-22 11:06 ` Heiko Stübner
2017-03-23 2:06 ` 陈亮 [this message]
2017-03-23 9:16 ` Heiko Stübner
2017-03-23 3:33 ` 陈亮
2017-03-24 6:31 ` 陈亮
2017-03-24 7:12 ` Heiko Stübner
2017-03-22 18:09 ` Sudeep Holla
2017-03-23 2:15 ` 陈亮
2017-03-16 13:22 ` [PATCH v2 5/6] arm64: dts: rockchip: add dts file for RK3328 cl
2017-03-16 13:23 ` [PATCH v2 6/6] dt-bindings: document rockchip rk3328-evb board cl
2017-03-24 2:15 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58D32D8A.1030506@rock-chips.com \
--to=cl@rock-chips.com \
--cc=afaerber@suse.de \
--cc=akpm@linux-foundation.org \
--cc=andy.yan@rock-chips.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=david.wu@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=fabio.estevam@nxp.com \
--cc=heiko@sntech.de \
--cc=huangtao@rock-chips.com \
--cc=jay.xu@rock-chips.com \
--cc=jic23@kernel.org \
--cc=kever.yang@rock-chips.com \
--cc=khilman@baylibre.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=paweljarosz3691@gmail.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=rocky.hao@rock-chips.com \
--cc=shawn.lin@rock-chips.com \
--cc=shawnguo@kernel.org \
--cc=tony.xie@rock-chips.com \
--cc=will.deacon@arm.com \
--cc=wsa@the-dreams.de \
--cc=wxt@rock-chips.com \
--cc=yamada.masahiro@socionext.com \
--cc=yhx@rock-chips.com \
--cc=zhangqing@rock-chips.com \
--cc=zhengxing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).