* [PATCH -next] drm/fb-helper: Remove set but not used variable 'connector_funcs'
@ 2018-09-12 3:15 YueHaibing
2018-09-12 13:29 ` Sean Paul
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2018-09-12 3:15 UTC (permalink / raw)
To: Gustavo Padovan, Maarten Lankhorst, Sean Paul, David Airlie
Cc: YueHaibing, dri-devel, linux-kernel, kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/gpu/drm/drm_fb_helper.c: In function 'drm_pick_crtcs':
drivers/gpu/drm/drm_fb_helper.c:2373:43: warning:
variable 'connector_funcs' set but not used [-Wunused-but-set-variable]
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/gpu/drm/drm_fb_helper.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
index 73cf10a..16e3a59 100644
--- a/drivers/gpu/drm/drm_fb_helper.c
+++ b/drivers/gpu/drm/drm_fb_helper.c
@@ -2370,7 +2370,6 @@ static int drm_pick_crtcs(struct drm_fb_helper *fb_helper,
{
int c, o;
struct drm_connector *connector;
- const struct drm_connector_helper_funcs *connector_funcs;
int my_score, best_score, score;
struct drm_fb_helper_crtc **crtcs, *crtc;
struct drm_fb_helper_connector *fb_helper_conn;
@@ -2399,8 +2398,6 @@ static int drm_pick_crtcs(struct drm_fb_helper *fb_helper,
if (drm_has_preferred_mode(fb_helper_conn, width, height))
my_score++;
- connector_funcs = connector->helper_private;
-
/*
* select a crtc for this connector and then attempt to configure
* remaining connectors
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] drm/fb-helper: Remove set but not used variable 'connector_funcs'
2018-09-12 3:15 [PATCH -next] drm/fb-helper: Remove set but not used variable 'connector_funcs' YueHaibing
@ 2018-09-12 13:29 ` Sean Paul
0 siblings, 0 replies; 2+ messages in thread
From: Sean Paul @ 2018-09-12 13:29 UTC (permalink / raw)
To: YueHaibing
Cc: Gustavo Padovan, Maarten Lankhorst, Sean Paul, David Airlie,
dri-devel, linux-kernel, kernel-janitors
On Wed, Sep 12, 2018 at 03:15:30AM +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/drm_fb_helper.c: In function 'drm_pick_crtcs':
> drivers/gpu/drm/drm_fb_helper.c:2373:43: warning:
> variable 'connector_funcs' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Thanks for your patch, applied to -misc-fixes
Sean
> ---
> drivers/gpu/drm/drm_fb_helper.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
> index 73cf10a..16e3a59 100644
> --- a/drivers/gpu/drm/drm_fb_helper.c
> +++ b/drivers/gpu/drm/drm_fb_helper.c
> @@ -2370,7 +2370,6 @@ static int drm_pick_crtcs(struct drm_fb_helper *fb_helper,
> {
> int c, o;
> struct drm_connector *connector;
> - const struct drm_connector_helper_funcs *connector_funcs;
> int my_score, best_score, score;
> struct drm_fb_helper_crtc **crtcs, *crtc;
> struct drm_fb_helper_connector *fb_helper_conn;
> @@ -2399,8 +2398,6 @@ static int drm_pick_crtcs(struct drm_fb_helper *fb_helper,
> if (drm_has_preferred_mode(fb_helper_conn, width, height))
> my_score++;
>
> - connector_funcs = connector->helper_private;
> -
> /*
> * select a crtc for this connector and then attempt to configure
> * remaining connectors
>
>
>
--
Sean Paul, Software Engineer, Google / Chromium OS
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-12 13:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-12 3:15 [PATCH -next] drm/fb-helper: Remove set but not used variable 'connector_funcs' YueHaibing
2018-09-12 13:29 ` Sean Paul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).