* [PATCH] net: dsa: remove redundant null pointer check before of_node_put
@ 2018-09-16 13:22 zhong jiang
2018-09-17 15:20 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: zhong jiang @ 2018-09-16 13:22 UTC (permalink / raw)
To: davem; +Cc: andrew, vivien.didelot, f.fainelli, netdev, linux-kernel
of_node_put has taken the null pointer check into account. So it is
safe to remove the duplicated check before of_node_put.
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
drivers/net/dsa/bcm_sf2.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/dsa/bcm_sf2.c b/drivers/net/dsa/bcm_sf2.c
index e0066ad..1fc27e1 100644
--- a/drivers/net/dsa/bcm_sf2.c
+++ b/drivers/net/dsa/bcm_sf2.c
@@ -465,8 +465,7 @@ static int bcm_sf2_mdio_register(struct dsa_switch *ds)
static void bcm_sf2_mdio_unregister(struct bcm_sf2_priv *priv)
{
mdiobus_unregister(priv->slave_mii_bus);
- if (priv->master_mii_dn)
- of_node_put(priv->master_mii_dn);
+ of_node_put(priv->master_mii_dn);
}
static u32 bcm_sf2_sw_get_phy_flags(struct dsa_switch *ds, int port)
--
1.7.12.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: dsa: remove redundant null pointer check before of_node_put
2018-09-16 13:22 [PATCH] net: dsa: remove redundant null pointer check before of_node_put zhong jiang
@ 2018-09-17 15:20 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-09-17 15:20 UTC (permalink / raw)
To: zhongjiang; +Cc: andrew, vivien.didelot, f.fainelli, netdev, linux-kernel
From: zhong jiang <zhongjiang@huawei.com>
Date: Sun, 16 Sep 2018 21:22:31 +0800
> of_node_put has taken the null pointer check into account. So it is
> safe to remove the duplicated check before of_node_put.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-17 15:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-16 13:22 [PATCH] net: dsa: remove redundant null pointer check before of_node_put zhong jiang
2018-09-17 15:20 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).