* [PATCH] crypto: cavium: remove redundant null pointer check before kfree
@ 2018-09-21 13:30 zhong jiang
2018-09-28 5:09 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: zhong jiang @ 2018-09-21 13:30 UTC (permalink / raw)
To: herbert, davem; +Cc: george.cherian, linux-crypto, linux-kernel
kfree has taken the null pointer into account. hence it is safe
to remove the redundant null pointer check before kfree.
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
drivers/crypto/cavium/cpt/cptvf_reqmanager.c | 20 +++++---------------
1 file changed, 5 insertions(+), 15 deletions(-)
diff --git a/drivers/crypto/cavium/cpt/cptvf_reqmanager.c b/drivers/crypto/cavium/cpt/cptvf_reqmanager.c
index b0ba433..ca549c5 100644
--- a/drivers/crypto/cavium/cpt/cptvf_reqmanager.c
+++ b/drivers/crypto/cavium/cpt/cptvf_reqmanager.c
@@ -308,21 +308,11 @@ void do_request_cleanup(struct cpt_vf *cptvf,
}
}
- if (info->scatter_components)
- kzfree(info->scatter_components);
-
- if (info->gather_components)
- kzfree(info->gather_components);
-
- if (info->out_buffer)
- kzfree(info->out_buffer);
-
- if (info->in_buffer)
- kzfree(info->in_buffer);
-
- if (info->completion_addr)
- kzfree((void *)info->completion_addr);
-
+ kzfree(info->scatter_components);
+ kzfree(info->gather_components);
+ kzfree(info->out_buffer);
+ kzfree(info->in_buffer);
+ kzfree((void *)info->completion_addr);
kzfree(info);
}
--
1.7.12.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] crypto: cavium: remove redundant null pointer check before kfree
2018-09-21 13:30 [PATCH] crypto: cavium: remove redundant null pointer check before kfree zhong jiang
@ 2018-09-28 5:09 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2018-09-28 5:09 UTC (permalink / raw)
To: zhong jiang; +Cc: davem, george.cherian, linux-crypto, linux-kernel
On Fri, Sep 21, 2018 at 09:30:15PM +0800, zhong jiang wrote:
> kfree has taken the null pointer into account. hence it is safe
> to remove the redundant null pointer check before kfree.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-28 5:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-21 13:30 [PATCH] crypto: cavium: remove redundant null pointer check before kfree zhong jiang
2018-09-28 5:09 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).