From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: linux-kbuild@vger.kernel.org
Cc: Ingo Molnar <mingo@redhat.com>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Bernd Edlinger <bernd.edlinger@hotmail.de>,
Borislav Petkov <bp@suse.de>, Sam Ravnborg <sam@ravnborg.org>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Michal Marek <michal.lkml@markovi.net>,
linux-kernel@vger.kernel.org
Subject: [PATCH 0/3] kbuild: add scripts/Makefile.toolcheck to check necessary host tools
Date: Tue, 16 Oct 2018 18:10:50 +0900 [thread overview]
Message-ID: <1539681053-24388-1-git-send-email-yamada.masahiro@socionext.com> (raw)
I wrote this patch set to cater to some reports:
- Bernd Edlinger reports false positive check of libelf
once CONFIG_UNWINDER_ORC is enabled.
https://lore.kernel.org/patchwork/patch/960411/
- Borislav Petkov reports the build fails very late
if CONFIG_KERNEL_LZ4 is enabled but lz4 is missing.
https://patchwork.kernel.org/patch/10635381/
From the discussion
https://patchwork.kernel.org/patch/10516049/
people like to see a build error when some host tools
are missing.
So, we need to check host tools in makefiles.
(Or, do not check at all. The build will fail anyway,
but the error message might not be clear enough in some cases.)
A problem is people check host tools
in random places in the top Makefile.
This does not work because the top Makefile is parsed twice
when the include/config/auto.config is updated.
Once with a stale auto.config, and once again with a
new auto.conf.
This will cause false positive build error.
One solution is to provide a systematic way to
do host-tool checks.
I added small macros in scripts/Makefile.toolcheck
to describe tool checks in a Kbuild-ish taste.
Masahiro Yamada (3):
kbuild: provide a new place to check necessary host tools
objtool: move libelf check out of top Makefile
kbuild: check the presence of lzo and lz4 tools when necessary
Makefile | 22 ++++-----------------
scripts/Makefile.build | 2 --
scripts/Makefile.toolcheck | 48 ++++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 52 insertions(+), 20 deletions(-)
create mode 100644 scripts/Makefile.toolcheck
--
2.7.4
next reply other threads:[~2018-10-16 9:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-16 9:10 Masahiro Yamada [this message]
2018-10-16 9:10 ` [PATCH 1/3] kbuild: provide a new place to check necessary host tools Masahiro Yamada
2018-10-16 15:47 ` Sam Ravnborg
2018-10-16 9:10 ` [PATCH 2/3] objtool: move libelf check out of top Makefile Masahiro Yamada
2018-10-16 14:25 ` Josh Poimboeuf
2018-10-16 15:51 ` Masahiro Yamada
2018-10-16 16:15 ` Josh Poimboeuf
2018-10-19 6:04 ` Masahiro Yamada
2018-10-19 19:28 ` Josh Poimboeuf
2018-10-16 9:10 ` [PATCH 3/3] kbuild: check the presence of lzo and lz4 tools when necessary Masahiro Yamada
2018-10-16 19:54 ` Borislav Petkov
2018-10-17 8:59 ` Masahiro Yamada
2018-10-17 9:10 ` Borislav Petkov
2018-10-17 9:25 ` Masahiro Yamada
2018-10-17 9:47 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1539681053-24388-1-git-send-email-yamada.masahiro@socionext.com \
--to=yamada.masahiro@socionext.com \
--cc=bernd.edlinger@hotmail.de \
--cc=bp@suse.de \
--cc=jpoimboe@redhat.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=mingo@redhat.com \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).