* [PATCH] f2fs: fix get_blocktype_secs bug when segs_per_sec is larger than 1
@ 2018-10-30 12:28 Yunlong Song
2018-10-30 12:46 ` [PATCH v2] " Yunlong Song
0 siblings, 1 reply; 3+ messages in thread
From: Yunlong Song @ 2018-10-30 12:28 UTC (permalink / raw)
To: jaegeuk, chao, yuchao0, yunlong.song, yunlong.song
Cc: miaoxie, bintian.wang, shengyong1, heyunlei, linux-f2fs-devel,
linux-kernel
f2fs_need_SSR uses get_blocktype_secs to calculate needed dirty
sections, however, for the case segs_per_sec > 1, when needed segs are
smaller than segs_per_sec, it will just return 0, so fix it.
Signed-off-by: Yunlong Song <yunlong.song@huawei.com>
---
fs/f2fs/f2fs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
index 56204a8..d47417b 100644
--- a/fs/f2fs/f2fs.h
+++ b/fs/f2fs/f2fs.h
@@ -1842,7 +1842,7 @@ static inline int get_blocktype_secs(struct f2fs_sb_info *sbi, int block_type)
unsigned int segs = (get_pages(sbi, block_type) + pages_per_sec - 1) >>
sbi->log_blocks_per_seg;
- return segs / sbi->segs_per_sec;
+ return (segs / sbi->segs_per_sec + sbi->segs_per_sec - 1) / sbi->segs_per_sec;
}
static inline block_t valid_user_blocks(struct f2fs_sb_info *sbi)
--
1.8.5.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH v2] f2fs: fix get_blocktype_secs bug when segs_per_sec is larger than 1
2018-10-30 12:28 [PATCH] f2fs: fix get_blocktype_secs bug when segs_per_sec is larger than 1 Yunlong Song
@ 2018-10-30 12:46 ` Yunlong Song
2018-10-31 3:34 ` Chao Yu
0 siblings, 1 reply; 3+ messages in thread
From: Yunlong Song @ 2018-10-30 12:46 UTC (permalink / raw)
To: jaegeuk, chao, yuchao0, yunlong.song, yunlong.song
Cc: miaoxie, bintian.wang, shengyong1, heyunlei, linux-f2fs-devel,
linux-kernel
f2fs_need_SSR uses get_blocktype_secs to calculate needed dirty
sections, however, for the case segs_per_sec > 1, when needed segs are
smaller than segs_per_sec, it will just return 0, so fix it.
Signed-off-by: Yunlong Song <yunlong.song@huawei.com>
---
fs/f2fs/f2fs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
index 56204a8..ef41ea2 100644
--- a/fs/f2fs/f2fs.h
+++ b/fs/f2fs/f2fs.h
@@ -1842,7 +1842,7 @@ static inline int get_blocktype_secs(struct f2fs_sb_info *sbi, int block_type)
unsigned int segs = (get_pages(sbi, block_type) + pages_per_sec - 1) >>
sbi->log_blocks_per_seg;
- return segs / sbi->segs_per_sec;
+ return (segs + sbi->segs_per_sec - 1) / sbi->segs_per_sec;
}
static inline block_t valid_user_blocks(struct f2fs_sb_info *sbi)
--
1.8.5.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] f2fs: fix get_blocktype_secs bug when segs_per_sec is larger than 1
2018-10-30 12:46 ` [PATCH v2] " Yunlong Song
@ 2018-10-31 3:34 ` Chao Yu
0 siblings, 0 replies; 3+ messages in thread
From: Chao Yu @ 2018-10-31 3:34 UTC (permalink / raw)
To: Yunlong Song, jaegeuk, chao, yunlong.song
Cc: miaoxie, bintian.wang, shengyong1, heyunlei, linux-f2fs-devel,
linux-kernel
On 2018/10/30 20:46, Yunlong Song wrote:
> f2fs_need_SSR uses get_blocktype_secs to calculate needed dirty
> sections, however, for the case segs_per_sec > 1, when needed segs are
> smaller than segs_per_sec, it will just return 0, so fix it.
>
> Signed-off-by: Yunlong Song <yunlong.song@huawei.com>
> ---
> fs/f2fs/f2fs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
> index 56204a8..ef41ea2 100644
> --- a/fs/f2fs/f2fs.h
> +++ b/fs/f2fs/f2fs.h
> @@ -1842,7 +1842,7 @@ static inline int get_blocktype_secs(struct f2fs_sb_info *sbi, int block_type)
> unsigned int segs = (get_pages(sbi, block_type) + pages_per_sec - 1) >>
> sbi->log_blocks_per_seg;
>
> - return segs / sbi->segs_per_sec;
> + return (segs + sbi->segs_per_sec - 1) / sbi->segs_per_sec;
roundup(segs, sbi->segs_per_sec)?
Thanks,
> }
>
> static inline block_t valid_user_blocks(struct f2fs_sb_info *sbi)
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-31 3:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-30 12:28 [PATCH] f2fs: fix get_blocktype_secs bug when segs_per_sec is larger than 1 Yunlong Song
2018-10-30 12:46 ` [PATCH v2] " Yunlong Song
2018-10-31 3:34 ` Chao Yu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).