* [PATCH] usb: gadget: aspeed-vhub: constify usb_gadget_ops structure
@ 2018-10-30 16:19 Julia Lawall
2018-11-08 0:35 ` Andrew Jeffery
0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2018-10-30 16:19 UTC (permalink / raw)
To: Felipe Balbi
Cc: kernel-janitors, Greg Kroah-Hartman, Joel Stanley,
Andrew Jeffery, linux-usb, linux-arm-kernel, linux-aspeed,
linux-kernel
The usb_gadget_ops structure can be const as it is only stored in
the ops field of a usb_gadget structure and this field is const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
drivers/usb/gadget/udc/aspeed-vhub/dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/udc/aspeed-vhub/dev.c b/drivers/usb/gadget/udc/aspeed-vhub/dev.c
index f0233912bace..6b1b16b17d7d 100644
--- a/drivers/usb/gadget/udc/aspeed-vhub/dev.c
+++ b/drivers/usb/gadget/udc/aspeed-vhub/dev.c
@@ -438,7 +438,7 @@ static int ast_vhub_udc_stop(struct usb_gadget *gadget)
return 0;
}
-static struct usb_gadget_ops ast_vhub_udc_ops = {
+static const struct usb_gadget_ops ast_vhub_udc_ops = {
.get_frame = ast_vhub_udc_get_frame,
.wakeup = ast_vhub_udc_wakeup,
.pullup = ast_vhub_udc_pullup,
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: gadget: aspeed-vhub: constify usb_gadget_ops structure
2018-10-30 16:19 [PATCH] usb: gadget: aspeed-vhub: constify usb_gadget_ops structure Julia Lawall
@ 2018-11-08 0:35 ` Andrew Jeffery
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Jeffery @ 2018-11-08 0:35 UTC (permalink / raw)
To: Julia Lawall, Felipe Balbi
Cc: kernel-janitors, Greg Kroah-Hartman, Joel Stanley, linux-usb,
linux-arm-kernel, linux-aspeed, linux-kernel
On Wed, 31 Oct 2018, at 02:49, Julia Lawall wrote:
> The usb_gadget_ops structure can be const as it is only stored in
> the ops field of a usb_gadget structure and this field is const.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
>
> ---
> drivers/usb/gadget/udc/aspeed-vhub/dev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/udc/aspeed-vhub/dev.c b/drivers/usb/
> gadget/udc/aspeed-vhub/dev.c
> index f0233912bace..6b1b16b17d7d 100644
> --- a/drivers/usb/gadget/udc/aspeed-vhub/dev.c
> +++ b/drivers/usb/gadget/udc/aspeed-vhub/dev.c
> @@ -438,7 +438,7 @@ static int ast_vhub_udc_stop(struct usb_gadget
> *gadget)
> return 0;
> }
>
> -static struct usb_gadget_ops ast_vhub_udc_ops = {
> +static const struct usb_gadget_ops ast_vhub_udc_ops = {
> .get_frame = ast_vhub_udc_get_frame,
> .wakeup = ast_vhub_udc_wakeup,
> .pullup = ast_vhub_udc_pullup,
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-11-08 0:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-30 16:19 [PATCH] usb: gadget: aspeed-vhub: constify usb_gadget_ops structure Julia Lawall
2018-11-08 0:35 ` Andrew Jeffery
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).