From: Peng Hao <peng.hao2@zte.com.cn>
To: robh+dt@kernel.org, mark.rutland@arm.com, arnd@arndb.de,
gregkh@linuxfoundation.org, andy@infradead.org,
dvhart@infradead.org
Cc: linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org, hutao@cn.fujitsu.com,
linux-doc@vger.kernel.org, Peng Hao <peng.hao2@zte.com.cn>
Subject: [PATCH V4 3/5] misc/pvpanic: add MMIO support
Date: Wed, 31 Oct 2018 21:37:19 +0800 [thread overview]
Message-ID: <1540993041-25611-3-git-send-email-peng.hao2@zte.com.cn> (raw)
In-Reply-To: <1540993041-25611-1-git-send-email-peng.hao2@zte.com.cn>
On some architectures (e.g. arm64), it's preferable to use MMIO, since
this can be used standalone. Add MMIO support to the pvpanic driver.
Signed-off-by: Peng Hao <peng.hao2@zte.com.cn>
---
drivers/misc/pvpanic.c | 20 ++++++++++++++++----
1 file changed, 16 insertions(+), 4 deletions(-)
diff --git a/drivers/misc/pvpanic.c b/drivers/misc/pvpanic.c
index 9450376..d0e28b2 100644
--- a/drivers/misc/pvpanic.c
+++ b/drivers/misc/pvpanic.c
@@ -28,7 +28,7 @@
#define PVPANIC_PANICKED (1 << 0)
-static u16 port;
+static void __iomem *base;
static struct acpi_driver pvpanic_driver = {
.name = "pvpanic",
@@ -44,7 +44,7 @@
static void
pvpanic_send_event(unsigned int event)
{
- outb(event, port);
+ iowrite8(event, base);
}
static int
@@ -64,12 +64,21 @@
static acpi_status
pvpanic_walk_resources(struct acpi_resource *res, void *context)
{
+ struct resource r;
+
switch (res->type) {
case ACPI_RESOURCE_TYPE_END_TAG:
return AE_OK;
case ACPI_RESOURCE_TYPE_IO:
- port = res->data.io.minimum;
+ if (acpi_dev_resource_io(res, &r))
+ base = (void __iomem *) ioport_map(r.start,
+ r.end - r.start + 1);
+ return AE_OK;
+
+ case ACPI_RESOURCE_TYPE_FIXED_MEMORY32:
+ if (acpi_dev_resource_memory(res, &r))
+ base = ioremap(r.start, r.end - r.start + 1);
return AE_OK;
default:
@@ -91,7 +100,7 @@ static int pvpanic_add(struct acpi_device *device)
acpi_walk_resources(device->handle, METHOD_NAME__CRS,
pvpanic_walk_resources, NULL);
- if (!port)
+ if (!base)
return -ENODEV;
atomic_notifier_chain_register(&panic_notifier_list,
@@ -105,6 +114,9 @@ static int pvpanic_remove(struct acpi_device *device)
atomic_notifier_chain_unregister(&panic_notifier_list,
&pvpanic_panic_nb);
+ if (base)
+ iounmap(base);
+
return 0;
}
--
1.8.3.1
next prev parent reply other threads:[~2018-10-31 5:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-31 13:37 [PATCH V4 1/5] pvpanic: move pvpanic to misc as common driver Peng Hao
2018-10-31 7:05 ` Mark Rutland
2018-10-31 12:45 ` Andy Shevchenko
2018-10-31 13:37 ` [PATCH V4 2/5] misc/pvpanic : convert to SPDX license tags Peng Hao
2018-10-31 12:46 ` Andy Shevchenko
2018-10-31 13:37 ` Peng Hao [this message]
2018-10-31 12:49 ` [PATCH V4 3/5] misc/pvpanic: add MMIO support Andy Shevchenko
2018-10-31 13:37 ` [PATCH V4 4/5] misc/pvpanic: add support to get pvpanic device info by FDT Peng Hao
2018-10-31 12:50 ` Andy Shevchenko
2018-10-31 12:53 ` Andy Shevchenko
2018-10-31 13:37 ` [PATCH V4 5/5] dt-bindings/misc/pvpanic :add document for pvpanic-mmio Peng Hao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1540993041-25611-3-git-send-email-peng.hao2@zte.com.cn \
--to=peng.hao2@zte.com.cn \
--cc=andy@infradead.org \
--cc=arnd@arndb.de \
--cc=dvhart@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=hutao@cn.fujitsu.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).