* [PATCH 1/1] irq/matrix: Fix memory overallocation
@ 2018-11-01 0:35 Michael Kelley
2018-11-01 9:03 ` [tip:irq/urgent] " tip-bot for Michael Kelley
0 siblings, 1 reply; 2+ messages in thread
From: Michael Kelley @ 2018-11-01 0:35 UTC (permalink / raw)
To: linux-kernel, tglx; +Cc: Michael Kelley, KY Srinivasan
IRQ_MATRIX_SIZE is the number of longs needed for a bitmap,
multiplied by the size of a long, yielding a byte count. But
it is used as the size of an array of longs, which is way more
memory than is needed. Change IRQ_MATRIX_SIZE so it is just the
number of longs needed and the arrays come out the correct size.
Signed-off-by: Michael Kelley <mikelley@microsoft.com>
---
kernel/irq/matrix.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/irq/matrix.c b/kernel/irq/matrix.c
index 6e6d467..1f0985a 100644
--- a/kernel/irq/matrix.c
+++ b/kernel/irq/matrix.c
@@ -8,7 +8,7 @@
#include <linux/cpu.h>
#include <linux/irq.h>
-#define IRQ_MATRIX_SIZE (BITS_TO_LONGS(IRQ_MATRIX_BITS) * sizeof(unsigned long))
+#define IRQ_MATRIX_SIZE (BITS_TO_LONGS(IRQ_MATRIX_BITS))
struct cpumap {
unsigned int available;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [tip:irq/urgent] irq/matrix: Fix memory overallocation
2018-11-01 0:35 [PATCH 1/1] irq/matrix: Fix memory overallocation Michael Kelley
@ 2018-11-01 9:03 ` tip-bot for Michael Kelley
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Michael Kelley @ 2018-11-01 9:03 UTC (permalink / raw)
To: linux-tip-commits; +Cc: linux-kernel, kys, mikelley, hpa, mingo, tglx
Commit-ID: 57f01796f14fecf00d330fe39c8d2477ced9cd79
Gitweb: https://git.kernel.org/tip/57f01796f14fecf00d330fe39c8d2477ced9cd79
Author: Michael Kelley <mikelley@microsoft.com>
AuthorDate: Thu, 1 Nov 2018 00:35:05 +0000
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Thu, 1 Nov 2018 10:00:38 +0100
irq/matrix: Fix memory overallocation
IRQ_MATRIX_SIZE is the number of longs needed for a bitmap, multiplied by
the size of a long, yielding a byte count. But it is used to size an array
of longs, which is way more memory than is needed.
Change IRQ_MATRIX_SIZE so it is just the number of longs needed and the
arrays come out the correct size.
Fixes: 2f75d9e1c905 ("genirq: Implement bitmap matrix allocator")
Signed-off-by: Michael Kelley <mikelley@microsoft.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: KY Srinivasan <kys@microsoft.com>
Link: https://lkml.kernel.org/r/1541032428-10392-1-git-send-email-mikelley@microsoft.com
---
kernel/irq/matrix.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/irq/matrix.c b/kernel/irq/matrix.c
index 6e6d467f3dec..1f0985adf193 100644
--- a/kernel/irq/matrix.c
+++ b/kernel/irq/matrix.c
@@ -8,7 +8,7 @@
#include <linux/cpu.h>
#include <linux/irq.h>
-#define IRQ_MATRIX_SIZE (BITS_TO_LONGS(IRQ_MATRIX_BITS) * sizeof(unsigned long))
+#define IRQ_MATRIX_SIZE (BITS_TO_LONGS(IRQ_MATRIX_BITS))
struct cpumap {
unsigned int available;
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-11-01 9:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-01 0:35 [PATCH 1/1] irq/matrix: Fix memory overallocation Michael Kelley
2018-11-01 9:03 ` [tip:irq/urgent] " tip-bot for Michael Kelley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).