* Re: net: ipv4: tcp_westwood: fixed warnings and checks
[not found] <1541425985-31869-1-git-send-email-suraj1998@gmail.com--annotate>
@ 2018-11-08 9:08 ` Suraj Singh
0 siblings, 0 replies; 2+ messages in thread
From: Suraj Singh @ 2018-11-08 9:08 UTC (permalink / raw)
To: davem; +Cc: kuznet, yoshfuji, netdev, linux-kernel, Suraj Singh
From: Suraj Singh <suraj998@gmail.com>
Regrding why I used "staging: " in the commmit message, I was following Greg Kroah-Hartman's video on YouTube on how to submit your first patch, and in his sample commit, he'd started his commit message with "staging: ", and so I thought it was convention to do so. I'll remove that immediately. I made this same mistake in another patch that I just sent for TCP Vegas, I'll make the change there as well.
I didn't consider the complexities of calling the same function twice. I was looking more towards satisying the scriptpatch.pl's requirements.
- tp->snd_cwnd = tp->snd_ssthresh = tcp_westwood_bw_rttmin(sk);
+ tp->snd_cwnd = tcp_westwood_bw_rttmin(sk);
+ tp->snd_ssthresh = tcp_westwood_bw_rttmin(sk);
I've made the same mistake here. I'll make these changes and resubmit. Is there anything else that's wrong?
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: net: ipv4: tcp_westwood: fixed warnings and checks
2018-11-05 13:53 [PATCH] staging: " Suraj Singh
@ 2018-11-08 9:16 ` Suraj Singh
0 siblings, 0 replies; 2+ messages in thread
From: Suraj Singh @ 2018-11-08 9:16 UTC (permalink / raw)
To: davem; +Cc: kuznet, yoshfuji, netdev, linux-kernel, suraj1998, Suraj Singh
From: Suraj Singh <suraj998@gmail.com>
Regrding why I used "staging: " in the commmit message, I was following Greg Kroah-Hartman's video on YouTube on how to submit your first patch, and in his sample commit, he'd started his commit message with "staging: ", and so I thought it was convention to do so. I'll remove that immediately. I made this same mistake in another patch that I just sent for TCP Vegas, I'll make the change there as well.
I didn't consider the complexities of calling the same function twice. I was looking more towards satisying the scriptpatch.pl's requirements.
- tp->snd_cwnd = tp->snd_ssthresh = tcp_westwood_bw_rttmin(sk);
+ tp->snd_cwnd = tcp_westwood_bw_rttmin(sk);
+ tp->snd_ssthresh = tcp_westwood_bw_rttmin(sk);
I've made the same mistake here. I'll make these changes and resubmit. Is there anything else that's wrong?
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-11-08 9:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1541425985-31869-1-git-send-email-suraj1998@gmail.com--annotate>
2018-11-08 9:08 ` net: ipv4: tcp_westwood: fixed warnings and checks Suraj Singh
2018-11-05 13:53 [PATCH] staging: " Suraj Singh
2018-11-08 9:16 ` Suraj Singh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).