From: Stephen Boyd <sboyd@kernel.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh@kernel.org>, Vinod Koul <vkoul@kernel.org>
Cc: Michael Turquette <mturquette@baylibre.com>,
Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: qcom: gcc: Fix board clock node name
Date: Fri, 09 Nov 2018 14:13:42 -0800 [thread overview]
Message-ID: <154180162264.88331.6677984637578512693@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20181109175105.GW12092@vkoul-mobl>
Quoting Vinod Koul (2018-11-09 09:51:05)
> On 09-11-18, 23:18, Vinod Koul wrote:
> > On 09-11-18, 09:12, Stephen Boyd wrote:
> > > Quoting Vinod Koul (2018-11-09 01:50:54)
> > > > drivers/clk/qcom/gcc-qcs404.c | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/clk/qcom/gcc-qcs404.c b/drivers/clk/qcom/gcc-qcs404.c
> > > > index e4ca6a45f313..ef1b267cb058 100644
> > > > --- a/drivers/clk/qcom/gcc-qcs404.c
> > > > +++ b/drivers/clk/qcom/gcc-qcs404.c
> > > > @@ -265,7 +265,7 @@ static struct clk_fixed_factor cxo = {
> > > > .div = 1,
> > > > .hw.init = &(struct clk_init_data){
> > > > .name = "cxo",
> > > > - .parent_names = (const char *[]){ "xo_board" },
> > > > + .parent_names = (const char *[]){ "xo-board" },
> > >
> > > We have xo_board used everywhere else in drivers/clk/qcom/ so this makes
> > > me concerned. Wouldn't a better answer be to add clock-output-names to
> > > the xo-board DT node and have arm-soc merge that through. I mostly want
> > > to keep things consistent here so that if we need to inject an xo_board
> > > clk into the system then we can do so generically instead of making it
> > > per-platform. Of course, if we're never going to have this problem on
> > > qcs404 then it will be fine to start differing here. So I'm leaning
> > > towards merge this patch, just please ack my concern here and tell me it
> > > won't be a problem and I'll be happy to merge to clk-fixes.
> >
> > So this is a warning from DT compiler and triggered with W=12, I
> > see tons of examples using "_" in node names. Clearly someone realized
> > it (Rob ?) added a warning for it.
> >
> > As you rightly thought, qcs404 will be okay as we are starting out and following
> > few conventions so keeping this saner :)
> >
> > > BTW, can you also specify a 'clocks' property in the GCC node and send
> > > the xo_board node there? In fact, we should do that for every GCC node
> > > in the tree. Care to do that and also add sleep_clk to each clock
> > > controller node that uses it? This is useful to do so that we can more
> > > easily see where clocks are going between clock controller nodes.
> >
> > I agree that it makes sense to add the property in gcc node. I will add
> > this in my list and chase if after my current task completes, if that is
> > fine by you
> >
Ok. Thanks for checking. Applied to clk-fixes.
next prev parent reply other threads:[~2018-11-09 22:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-09 9:50 [PATCH] clk: qcom: gcc: Fix board clock node name Vinod Koul
2018-11-09 17:12 ` Stephen Boyd
2018-11-09 17:48 ` Vinod Koul
2018-11-09 17:51 ` Vinod Koul
2018-11-09 22:13 ` Stephen Boyd [this message]
2018-11-11 2:12 ` Taniya Das
2018-11-13 17:22 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=154180162264.88331.6677984637578512693@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).