Re: [PATCH] clk: qcom: gcc: Fix board clock node name

From: Taniya Das <tdas@codeaurora.org>
To: Vinod Koul <vkoul@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>
Cc: Andy Gross <andy.gross@linaro.org>,
	David Brown <david.brown@linaro.org>,
	linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
	linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: qcom: gcc: Fix board clock node name
Date: Sun, 11 Nov 2018 07:42:28 +0530	[thread overview]
Message-ID: <c3bf03cd-ef87-a005-8536-d8739f53f2a5@codeaurora.org> (raw)
In-Reply-To: <20181109095054.13924-1-vkoul@kernel.org>

Hello Vinod,

On 11/9/2018 3:20 PM, Vinod Koul wrote:
> Device tree node name are not supposed to have "_" in them so fix the
> node name use of xo_board to xo-board
> 
> Fixes: 652f1813c113 ("clk: qcom: gcc: Add global clock controller driver for QCS404")
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> ---
> 
> Steve: RobH pointed this on DTS patches, would be great if you can pick this
> as a fix
> 
>   drivers/clk/qcom/gcc-qcs404.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/qcom/gcc-qcs404.c b/drivers/clk/qcom/gcc-qcs404.c
> index e4ca6a45f313..ef1b267cb058 100644
> --- a/drivers/clk/qcom/gcc-qcs404.c
> +++ b/drivers/clk/qcom/gcc-qcs404.c
> @@ -265,7 +265,7 @@ static struct clk_fixed_factor cxo = {
>   	.div = 1,
>   	.hw.init = &(struct clk_init_data){
>   		.name = "cxo",
> -		.parent_names = (const char *[]){ "xo_board" },
> +		.parent_names = (const char *[]){ "xo-board" },
>   		.num_parents = 1,
>   		.ops = &clk_fixed_factor_ops,
>   	},
> 

This fixed clock needs to be removed, once the RPM<->SMD clocks are 
added. Why not have this clock part of the device Tree?

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation.

--