From: Stephen Boyd <sboyd@kernel.org>
To: "Ryder Lee" <ryder.lee@mediatek.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
linux-pwm@vger.kernel.org, Weijie Gao <weijie.gao@mediatek.com>,
Roy Luo <cheng-hao.luo@mediatek.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
John Crispin <john@phrozen.org>,
kernel@pengutronix.de, linux-clk@vger.kernel.org,
Michael Turquette <mturquette@baylibre.com>
Subject: Re: [resend PATCH 1/3] pwm: mediatek: drop flag 'has_clks'
Date: Tue, 13 Nov 2018 10:00:58 -0800 [thread overview]
Message-ID: <154213205843.88331.7023190778461777093@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20181113095210.mh3iy5tcsu6w6tem@pengutronix.de>
Quoting Uwe Kleine-König (2018-11-13 01:52:10)
>
> I wonder if it would make sense to introduce functions like:
>
> struct clk *clk_get_optional(struct device *dev, const char *id)
>
> that return NULL instead of ERR_PTR(-ENODEV).
>
> Then the above would simplify to:
>
> pc->clks[i] = devm_clk_get_optional(&pdev->dev, mtk_pwm_clk_name[i]);
> if (IS_ERR(pc->clks[i]) {
> if (PTR_ERR(pc->clks[i]) == -EPROBE_DEFER)
> dev_err(...);
> return PTR_ERR(pc->clks[i]);
> }
>
> (added the clk people to Cc for this question).
>
Such a patch is already on the list and not getting much review.
http://lkml.kernel.org/r/1535724443-21150-1-git-send-email-phil.edworthy@renesas.com
next prev parent reply other threads:[~2018-11-13 18:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-13 2:08 [resend PATCH 1/3] pwm: mediatek: drop flag 'has_clks' Ryder Lee
2018-11-13 2:08 ` [resend PATCH 2/3] pwm: mediatek: add pwm support for MT7629 SoC Ryder Lee
2018-11-15 19:20 ` Sean Wang
2018-11-13 2:08 ` [resend PATCH 3/3] dt-bindings: pwm: update bindings " Ryder Lee
2018-11-13 9:55 ` Uwe Kleine-König
2018-11-13 9:52 ` [resend PATCH 1/3] pwm: mediatek: drop flag 'has_clks' Uwe Kleine-König
2018-11-13 18:00 ` Stephen Boyd [this message]
2018-11-14 12:47 ` Thierry Reding
2018-11-14 13:27 ` John Crispin
2018-11-15 2:16 ` Ryder Lee
2018-11-16 6:47 ` Uwe Kleine-König
2018-11-16 10:22 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=154213205843.88331.7023190778461777093@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=cheng-hao.luo@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=john@phrozen.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=ryder.lee@mediatek.com \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=weijie.gao@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).