linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/1] staging: rtlwifi: Add new line to stay in 80 characters
@ 2018-11-12 23:18 Cristian Sicilia
  2018-11-12 23:44 ` Greg Kroah-Hartman
  2018-11-13 19:34 ` [PATCH v2 0/2] Aligh parenthesis and split lines Cristian Sicilia
  0 siblings, 2 replies; 5+ messages in thread
From: Cristian Sicilia @ 2018-11-12 23:18 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Cristian Sicilia, Colin Ian King,
	Nathan Chancellor, Arnd Bergmann, devel, linux-kernel

The parameter is sent to next line to stay in 80
characters

Signed-off-by: Cristian Sicilia <sicilia.cristian@gmail.com>
---
 drivers/staging/rtlwifi/core.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/rtlwifi/core.c b/drivers/staging/rtlwifi/core.c
index ca37f75..a990281 100644
--- a/drivers/staging/rtlwifi/core.c
+++ b/drivers/staging/rtlwifi/core.c
@@ -1882,7 +1882,8 @@ bool rtl_hal_pwrseqcmdparsing(struct rtl_priv *rtlpriv, u8 cut_version,
 				return true;
 			default:
 				WARN_ONCE(true,
-					  "rtlwifi: %s(): Unknown CMD!!\n", __func__);
+					  "rtlwifi: %s(): Unknown CMD!!\n",
+					  __func__);
 				break;
 			}
 		}
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/1] staging: rtlwifi: Add new line to stay in 80 characters
  2018-11-12 23:18 [PATCH 1/1] staging: rtlwifi: Add new line to stay in 80 characters Cristian Sicilia
@ 2018-11-12 23:44 ` Greg Kroah-Hartman
  2018-11-13 19:34 ` [PATCH v2 0/2] Aligh parenthesis and split lines Cristian Sicilia
  1 sibling, 0 replies; 5+ messages in thread
From: Greg Kroah-Hartman @ 2018-11-12 23:44 UTC (permalink / raw)
  To: Cristian Sicilia
  Cc: Colin Ian King, Nathan Chancellor, Arnd Bergmann, devel, linux-kernel

On Tue, Nov 13, 2018 at 12:18:56AM +0100, Cristian Sicilia wrote:
> The parameter is sent to next line to stay in 80
> characters
> 
> Signed-off-by: Cristian Sicilia <sicilia.cristian@gmail.com>
> ---
>  drivers/staging/rtlwifi/core.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 

You sent two 1/1 patches, shouldn't this be a patch series of 2 patches
ordered properly?

Please fix up and resend.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v2 0/2] Aligh parenthesis and split lines
  2018-11-12 23:18 [PATCH 1/1] staging: rtlwifi: Add new line to stay in 80 characters Cristian Sicilia
  2018-11-12 23:44 ` Greg Kroah-Hartman
@ 2018-11-13 19:34 ` Cristian Sicilia
  2018-11-13 19:34   ` [PATCH v2 1/2] staging: rtlwifi: Add spaces to match open parenthesis Cristian Sicilia
  2018-11-13 19:34   ` [PATCH v2 2/2] staging: rtlwifi: Add new line to stay in 80 characters Cristian Sicilia
  1 sibling, 2 replies; 5+ messages in thread
From: Cristian Sicilia @ 2018-11-13 19:34 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Arnd Bergmann, Nathan Chancellor, Colin Ian King
  Cc: Cristian Sicilia, devel, linux-kernel

In the first patch I added some space to align previous
parenthesis.
In the second patch split a line to stay in 80 characters.

Cristian Sicilia (2):
  staging: rtlwifi: Add spaces to match open parenthesis
  staging: rtlwifi: Add new line to stay in 80 characters

 drivers/staging/rtlwifi/core.c | 3 ++-
 drivers/staging/rtlwifi/ps.c   | 4 ++--
 2 files changed, 4 insertions(+), 3 deletions(-)

-- 

This two patch was sent in two different mail, now are
in a single patchset.

2.7.4


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v2 1/2] staging: rtlwifi: Add spaces to match open parenthesis
  2018-11-13 19:34 ` [PATCH v2 0/2] Aligh parenthesis and split lines Cristian Sicilia
@ 2018-11-13 19:34   ` Cristian Sicilia
  2018-11-13 19:34   ` [PATCH v2 2/2] staging: rtlwifi: Add new line to stay in 80 characters Cristian Sicilia
  1 sibling, 0 replies; 5+ messages in thread
From: Cristian Sicilia @ 2018-11-13 19:34 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Arnd Bergmann, Nathan Chancellor, Colin Ian King
  Cc: Cristian Sicilia, devel, linux-kernel

Added before parameters some spaces to match open parenthesis
on previous line.

Signed-off-by: Cristian Sicilia <sicilia.cristian@gmail.com>
---
 drivers/staging/rtlwifi/ps.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtlwifi/ps.c b/drivers/staging/rtlwifi/ps.c
index 0ca0532..5118773 100644
--- a/drivers/staging/rtlwifi/ps.c
+++ b/drivers/staging/rtlwifi/ps.c
@@ -245,7 +245,7 @@ void rtl_ips_nic_off_wq_callback(void *data)
 			/* call before RF off */
 			if (rtlpriv->cfg->ops->get_btc_status())
 				rtlpriv->btcoexist.btc_ops->btc_ips_notify(rtlpriv,
-									ppsc->inactive_pwrstate);
+									   ppsc->inactive_pwrstate);
 
 			/*rtl_pci_reset_trx_ring(hw); */
 			_rtl_ps_inactive_ps(hw);
@@ -291,7 +291,7 @@ void rtl_ips_nic_on(struct ieee80211_hw *hw)
 				rtlpriv->phydm.ops->phydm_reset_dm(rtlpriv);
 			if (rtlpriv->cfg->ops->get_btc_status())
 				rtlpriv->btcoexist.btc_ops->btc_ips_notify(rtlpriv,
-									ppsc->inactive_pwrstate);
+									   ppsc->inactive_pwrstate);
 		}
 	}
 	mutex_unlock(&rtlpriv->locks.ips_mutex);
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH v2 2/2] staging: rtlwifi: Add new line to stay in 80 characters
  2018-11-13 19:34 ` [PATCH v2 0/2] Aligh parenthesis and split lines Cristian Sicilia
  2018-11-13 19:34   ` [PATCH v2 1/2] staging: rtlwifi: Add spaces to match open parenthesis Cristian Sicilia
@ 2018-11-13 19:34   ` Cristian Sicilia
  1 sibling, 0 replies; 5+ messages in thread
From: Cristian Sicilia @ 2018-11-13 19:34 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Arnd Bergmann, Nathan Chancellor, Colin Ian King
  Cc: Cristian Sicilia, devel, linux-kernel

The parameter is sent to next line to stay in 80
characters

Signed-off-by: Cristian Sicilia <sicilia.cristian@gmail.com>
---
 drivers/staging/rtlwifi/core.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/rtlwifi/core.c b/drivers/staging/rtlwifi/core.c
index ca37f75..a990281 100644
--- a/drivers/staging/rtlwifi/core.c
+++ b/drivers/staging/rtlwifi/core.c
@@ -1882,7 +1882,8 @@ bool rtl_hal_pwrseqcmdparsing(struct rtl_priv *rtlpriv, u8 cut_version,
 				return true;
 			default:
 				WARN_ONCE(true,
-					  "rtlwifi: %s(): Unknown CMD!!\n", __func__);
+					  "rtlwifi: %s(): Unknown CMD!!\n",
+					  __func__);
 				break;
 			}
 		}
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2018-11-13 19:35 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-12 23:18 [PATCH 1/1] staging: rtlwifi: Add new line to stay in 80 characters Cristian Sicilia
2018-11-12 23:44 ` Greg Kroah-Hartman
2018-11-13 19:34 ` [PATCH v2 0/2] Aligh parenthesis and split lines Cristian Sicilia
2018-11-13 19:34   ` [PATCH v2 1/2] staging: rtlwifi: Add spaces to match open parenthesis Cristian Sicilia
2018-11-13 19:34   ` [PATCH v2 2/2] staging: rtlwifi: Add new line to stay in 80 characters Cristian Sicilia

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).