From: Stephen Boyd <swboyd@chromium.org>
To: Lina Iyer <ilina@codeaurora.org>,
evgreen@chromium.org, marc.zyngier@arm.com
Cc: linux-kernel@vger.kernel.org, rplsssn@codeaurora.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
thierry.reding@gmail.com, Lina Iyer <ilina@codeaurora.org>
Subject: Re: [RFC v3 2/3] dt-bindings: sdm845-pinctrl: add wakeup interrupt parent for GPIO
Date: Wed, 21 Nov 2018 13:36:21 -0800 [thread overview]
Message-ID: <154283618199.88331.10217252750356423959@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20181121000648.29262-3-ilina@codeaurora.org>
Quoting Lina Iyer (2018-11-20 16:06:47)
> SDM845 SoC has an always-on interrupt controller (PDC) with select GPIO
> routed to the PDC as interrupts that can be used to wake the system up
> from deep low power modes and suspend.
>
> Signed-off-by: Lina Iyer <ilina@codeaurora.org>
> ---
> .../bindings/pinctrl/qcom,sdm845-pinctrl.txt | 31 ++++++++++++++++++-
> 1 file changed, 30 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sdm845-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/qcom,sdm845-pinctrl.txt
> index 665aadb5ea28..bedfa0b57fa6 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,sdm845-pinctrl.txt
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sdm845-pinctrl.txt
> @@ -29,6 +29,17 @@ SDM845 platform.
> Definition: must be 2. Specifying the pin number and flags, as defined
> in <dt-bindings/interrupt-controller/irq.h>
>
> +- wakeup-parent:
> + Usage: optional
> + Value type: <phandle>
> + Definition: A phandle to the wakeup interrupt controller for the SoC.
> +
> +- wakeup-irq:
This shouldn't be needed. TLMM driver can probe for the possibility of
wakeup capable irqs from irq allocation step. The only place we should
need to know what TLMM pins map to what PDC lines is in the PDC driver.
next prev parent reply other threads:[~2018-11-21 21:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-21 0:06 [RFC v3 0/3] qcom: GPIO IRQ wakeup using PDC irqchip Lina Iyer
2018-11-21 0:06 ` [RFC v3 1/3] drivers: pinctrl: msm: setup gpio irqchip in hierarchy with pdc irqchip Lina Iyer
2018-11-21 0:06 ` [RFC v3 2/3] dt-bindings: sdm845-pinctrl: add wakeup interrupt parent for GPIO Lina Iyer
2018-11-21 21:36 ` Stephen Boyd [this message]
2018-11-26 16:14 ` Lina Iyer
2018-11-27 9:12 ` Stephen Boyd
2018-11-27 18:21 ` Lina Iyer
2018-11-27 21:45 ` Stephen Boyd
2018-11-28 17:39 ` Lina Iyer
2018-11-29 0:24 ` Bjorn Andersson
2018-11-29 21:45 ` Lina Iyer
2018-11-30 7:10 ` Bjorn Andersson
2018-11-30 18:33 ` Lina Iyer
2018-12-03 23:48 ` Stephen Boyd
2018-12-18 18:01 ` Lina Iyer
2018-11-21 0:06 ` [RFC v3 3/3] arm64: dts: msm: add PDC wake irq maps for GPIOs for SDM845 Lina Iyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=154283618199.88331.10217252750356423959@swboyd.mtv.corp.google.com \
--to=swboyd@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=evgreen@chromium.org \
--cc=ilina@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=rplsssn@codeaurora.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).