* [PATCH] xen: xlate_mmu: add missing header to fix 'W=1' warning
@ 2018-11-27 14:23 Srikanth Boddepalli
2018-11-28 16:24 ` Boris Ostrovsky
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Srikanth Boddepalli @ 2018-11-27 14:23 UTC (permalink / raw)
To: boris.ostrovsky
Cc: jgross, sstabellini, xen-devel, linux-kernel, boddepalli.srikanth
Add a missing header otherwise compiler warns about missed prototype:
drivers/xen/xlate_mmu.c:183:5: warning: no previous prototype for 'xen_xlate_unmap_gfn_range?' [-Wmissing-prototypes]
int xen_xlate_unmap_gfn_range(struct vm_area_struct *vma,
^~~~~~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Srikanth Boddepalli <boddepalli.srikanth@gmail.com>
---
drivers/xen/xlate_mmu.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/xen/xlate_mmu.c b/drivers/xen/xlate_mmu.c
index 23f1387..e7df65d 100644
--- a/drivers/xen/xlate_mmu.c
+++ b/drivers/xen/xlate_mmu.c
@@ -36,6 +36,7 @@
#include <asm/xen/hypervisor.h>
#include <xen/xen.h>
+#include <xen/xen-ops.h>
#include <xen/page.h>
#include <xen/interface/xen.h>
#include <xen/interface/memory.h>
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] xen: xlate_mmu: add missing header to fix 'W=1' warning
2018-11-27 14:23 [PATCH] xen: xlate_mmu: add missing header to fix 'W=1' warning Srikanth Boddepalli
@ 2018-11-28 16:24 ` Boris Ostrovsky
2018-11-28 17:38 ` Joey Pabalinas
2018-11-29 16:55 ` Juergen Gross
2 siblings, 0 replies; 4+ messages in thread
From: Boris Ostrovsky @ 2018-11-28 16:24 UTC (permalink / raw)
To: Srikanth Boddepalli; +Cc: jgross, sstabellini, xen-devel, linux-kernel
On 11/27/18 9:23 AM, Srikanth Boddepalli wrote:
> Add a missing header otherwise compiler warns about missed prototype:
>
> drivers/xen/xlate_mmu.c:183:5: warning: no previous prototype for 'xen_xlate_unmap_gfn_range?' [-Wmissing-prototypes]
> int xen_xlate_unmap_gfn_range(struct vm_area_struct *vma,
> ^~~~~~~~~~~~~~~~~~~~~~~~~
>
> Signed-off-by: Srikanth Boddepalli <boddepalli.srikanth@gmail.com>
> ---
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xen: xlate_mmu: add missing header to fix 'W=1' warning
2018-11-27 14:23 [PATCH] xen: xlate_mmu: add missing header to fix 'W=1' warning Srikanth Boddepalli
2018-11-28 16:24 ` Boris Ostrovsky
@ 2018-11-28 17:38 ` Joey Pabalinas
2018-11-29 16:55 ` Juergen Gross
2 siblings, 0 replies; 4+ messages in thread
From: Joey Pabalinas @ 2018-11-28 17:38 UTC (permalink / raw)
To: Srikanth Boddepalli
Cc: boris.ostrovsky, jgross, sstabellini, xen-devel, linux-kernel,
Joey Pabalinas
[-- Attachment #1: Type: text/plain, Size: 455 bytes --]
On Tue, Nov 27, 2018 at 07:53:27PM +0530, Srikanth Boddepalli wrote:
> Add a missing header otherwise compiler warns about missed prototype:
>
> drivers/xen/xlate_mmu.c:183:5: warning: no previous prototype for 'xen_xlate_unmap_gfn_range?' [-Wmissing-prototypes]
> int xen_xlate_unmap_gfn_range(struct vm_area_struct *vma,
> ^~~~~~~~~~~~~~~~~~~~~~~~~
Reviewed-by: Joey Pabalinas <joeypabalinas@gmail.com>
--
Cheers,
Joey Pabalinas
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xen: xlate_mmu: add missing header to fix 'W=1' warning
2018-11-27 14:23 [PATCH] xen: xlate_mmu: add missing header to fix 'W=1' warning Srikanth Boddepalli
2018-11-28 16:24 ` Boris Ostrovsky
2018-11-28 17:38 ` Joey Pabalinas
@ 2018-11-29 16:55 ` Juergen Gross
2 siblings, 0 replies; 4+ messages in thread
From: Juergen Gross @ 2018-11-29 16:55 UTC (permalink / raw)
To: Srikanth Boddepalli, boris.ostrovsky; +Cc: sstabellini, xen-devel, linux-kernel
On 27/11/2018 15:23, Srikanth Boddepalli wrote:
> Add a missing header otherwise compiler warns about missed prototype:
>
> drivers/xen/xlate_mmu.c:183:5: warning: no previous prototype for 'xen_xlate_unmap_gfn_range?' [-Wmissing-prototypes]
> int xen_xlate_unmap_gfn_range(struct vm_area_struct *vma,
> ^~~~~~~~~~~~~~~~~~~~~~~~~
>
> Signed-off-by: Srikanth Boddepalli <boddepalli.srikanth@gmail.com>
Pushed to xen/tip.git for-linus-4.20a
Juergen
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-11-29 16:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-27 14:23 [PATCH] xen: xlate_mmu: add missing header to fix 'W=1' warning Srikanth Boddepalli
2018-11-28 16:24 ` Boris Ostrovsky
2018-11-28 17:38 ` Joey Pabalinas
2018-11-29 16:55 ` Juergen Gross
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).