* [PATCH] ubi: do not drop UBI device reference before using
@ 2018-11-28 3:20 Pan Bian
2018-11-28 8:06 ` Boris Brezillon
0 siblings, 1 reply; 2+ messages in thread
From: Pan Bian @ 2018-11-28 3:20 UTC (permalink / raw)
To: Artem Bityutskiy, Richard Weinberger, David Woodhouse,
Brian Norris, Boris Brezillon, Marek Vasut
Cc: linux-mtd, linux-kernel, Pan Bian
The UBI device reference is dropped but then the device is used as a
parameter of ubi_err. The bug is introduced in changing ubi_err's
behavior. The old ubi_err does not require a UBI device as its first
parameter, but the new one does.
Fixes: 32608703310 ("UBI: Extend UBI layer debug/messaging capabilities")
Signed-off-by: Pan Bian <bianpan2016@163.com>
---
drivers/mtd/ubi/kapi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/ubi/kapi.c b/drivers/mtd/ubi/kapi.c
index e9e9ecb..0b8f0c4 100644
--- a/drivers/mtd/ubi/kapi.c
+++ b/drivers/mtd/ubi/kapi.c
@@ -227,9 +227,9 @@ struct ubi_volume_desc *ubi_open_volume(int ubi_num, int vol_id, int mode)
out_free:
kfree(desc);
out_put_ubi:
- ubi_put_device(ubi);
ubi_err(ubi, "cannot open device %d, volume %d, error %d",
ubi_num, vol_id, err);
+ ubi_put_device(ubi);
return ERR_PTR(err);
}
EXPORT_SYMBOL_GPL(ubi_open_volume);
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ubi: do not drop UBI device reference before using
2018-11-28 3:20 [PATCH] ubi: do not drop UBI device reference before using Pan Bian
@ 2018-11-28 8:06 ` Boris Brezillon
0 siblings, 0 replies; 2+ messages in thread
From: Boris Brezillon @ 2018-11-28 8:06 UTC (permalink / raw)
To: Pan Bian
Cc: Artem Bityutskiy, Richard Weinberger, David Woodhouse,
Brian Norris, Marek Vasut, linux-mtd, linux-kernel
On Wed, 28 Nov 2018 11:20:03 +0800
Pan Bian <bianpan2016@163.com> wrote:
> The UBI device reference is dropped but then the device is used as a
> parameter of ubi_err. The bug is introduced in changing ubi_err's
> behavior. The old ubi_err does not require a UBI device as its first
> parameter, but the new one does.
>
> Fixes: 32608703310 ("UBI: Extend UBI layer debug/messaging capabilities")
>
Unnecessary blank line here.
> Signed-off-by: Pan Bian <bianpan2016@163.com>
Reviewed-by: Boris Brezillon <boris.brezillon@bootlin.com>
> ---
> drivers/mtd/ubi/kapi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/ubi/kapi.c b/drivers/mtd/ubi/kapi.c
> index e9e9ecb..0b8f0c4 100644
> --- a/drivers/mtd/ubi/kapi.c
> +++ b/drivers/mtd/ubi/kapi.c
> @@ -227,9 +227,9 @@ struct ubi_volume_desc *ubi_open_volume(int ubi_num, int vol_id, int mode)
> out_free:
> kfree(desc);
> out_put_ubi:
> - ubi_put_device(ubi);
> ubi_err(ubi, "cannot open device %d, volume %d, error %d",
> ubi_num, vol_id, err);
> + ubi_put_device(ubi);
> return ERR_PTR(err);
> }
> EXPORT_SYMBOL_GPL(ubi_open_volume);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-11-28 8:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-28 3:20 [PATCH] ubi: do not drop UBI device reference before using Pan Bian
2018-11-28 8:06 ` Boris Brezillon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).