From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>,
Randy Dunlap <rdunlap@infradead.org>
Cc: Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: linux-next: Tree for Nov 27 (scsi/aha1542)
Date: Tue, 27 Nov 2018 21:41:24 -0800 [thread overview]
Message-ID: <1543383684.3518.2.camel@HansenPartnership.com> (raw)
In-Reply-To: <20181128153847.08ead1c9@canb.auug.org.au>
[-- Attachment #1: Type: text/plain, Size: 1387 bytes --]
On Wed, 2018-11-28 at 15:38 +1100, Stephen Rothwell wrote:
> Hi all,
>
> On Tue, 27 Nov 2018 20:14:58 -0800 Randy Dunlap <rdunlap@infradead.or
> g> wrote:
> >
> > On 11/26/18 8:25 PM, Stephen Rothwell wrote:
> > > Hi all,
> > >
> > > Changes since 20181126:
> > >
> >
> > on i386:
> >
> > ERROR: "__udivdi3" [drivers/scsi/aha1542.ko] undefined!
> >
> > somewhere in aha1542_interrupt() according to objdump.
>
> Presumably caused by commit
>
> 1794ef2b150d ("scsi: aha1542: convert to DMA mapping API")
Yes, it's because dma_addr_t can be u64 on pae systems but
isa_virt_to_bus only ever returns unsigned long (because an ISA
physical address can only be 24 bits).
I think this is the fix; there doesn't seem to be much point converting
to do_div given all the limitations.
James
---
diff --git a/drivers/scsi/aha1542.c b/drivers/scsi/aha1542.c
index a9c29757172f..afb693d7b44f 100644
--- a/drivers/scsi/aha1542.c
+++ b/drivers/scsi/aha1542.c
@@ -325,7 +325,7 @@ static irqreturn_t aha1542_interrupt(int irq, void *dev_id)
return IRQ_HANDLED;
};
- mbo = (scsi2int(mb[mbi].ccbptr) - aha1542->ccb_handle) / sizeof(struct ccb);
+ mbo = (scsi2int(mb[mbi].ccbptr) - (unsigned long)aha1542->ccb_handle) / sizeof(struct ccb);
mbistatus = mb[mbi].status;
mb[mbi].status = 0;
aha1542->aha1542_last_mbi_used = mbi;
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2018-11-28 5:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-27 4:25 linux-next: Tree for Nov 27 Stephen Rothwell
2018-11-28 3:47 ` linux-next: Tree for Nov 27 (net/ipv4/af_inet.c) Randy Dunlap
2018-11-28 4:30 ` David Ahern
2018-11-28 4:14 ` linux-next: Tree for Nov 27 (scsi/aha1542) Randy Dunlap
2018-11-28 4:38 ` Stephen Rothwell
2018-11-28 5:41 ` James Bottomley [this message]
2018-11-28 6:54 ` Christoph Hellwig
2018-11-28 7:11 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1543383684.3518.2.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).