From: Christoph Hellwig <hch@lst.de>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Randy Dunlap <rdunlap@infradead.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: linux-next: Tree for Nov 27 (scsi/aha1542)
Date: Wed, 28 Nov 2018 07:54:50 +0100 [thread overview]
Message-ID: <20181128065450.GA20211@lst.de> (raw)
In-Reply-To: <1543383684.3518.2.camel@HansenPartnership.com>
On Tue, Nov 27, 2018 at 09:41:24PM -0800, James Bottomley wrote:
> Yes, it's because dma_addr_t can be u64 on pae systems but
> isa_virt_to_bus only ever returns unsigned long (because an ISA
> physical address can only be 24 bits).
>
> I think this is the fix; there doesn't seem to be much point converting
> to do_div given all the limitations.
Yes, something along these lines should fix it. I don't have the code
in front of me, but I vaguely remember there is a second division like
this, though. It might be worth to factor the calculation into a helper
with a comment like the message above explaining it.
next prev parent reply other threads:[~2018-11-28 6:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-27 4:25 linux-next: Tree for Nov 27 Stephen Rothwell
2018-11-28 3:47 ` linux-next: Tree for Nov 27 (net/ipv4/af_inet.c) Randy Dunlap
2018-11-28 4:30 ` David Ahern
2018-11-28 4:14 ` linux-next: Tree for Nov 27 (scsi/aha1542) Randy Dunlap
2018-11-28 4:38 ` Stephen Rothwell
2018-11-28 5:41 ` James Bottomley
2018-11-28 6:54 ` Christoph Hellwig [this message]
2018-11-28 7:11 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181128065450.GA20211@lst.de \
--to=hch@lst.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).