linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] clk: qcom: gpu_cc_gmu_clk_src has 5 parents, not 6
@ 2018-11-28 18:48 Douglas Anderson
  2018-11-28 21:24 ` Stephen Boyd
  0 siblings, 1 reply; 2+ messages in thread
From: Douglas Anderson @ 2018-11-28 18:48 UTC (permalink / raw)
  To: Stephen Boyd
  Cc: Taniya Das, Kristian H . Kristensen, Jordan Crouse, Amit Nischal,
	Douglas Anderson, Michael Turquette, linux-arm-msm, linux-kernel,
	Andy Gross, David Brown, linux-soc, linux-clk

In an earlier version of commit 453361cdd757 ("clk: qcom: Add graphics
clock controller driver for SDM845") there were 6 listed parents for
"gpu_cc_gmu_clk_src".  In the version that landed there were 5.
...but "num_parents" was still left at 6.  On my system this goes boom
at bootup.

Fixes: 453361cdd757 ("clk: qcom: Add graphics clock controller driver for SDM845")
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---

 drivers/clk/qcom/gpucc-sdm845.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/qcom/gpucc-sdm845.c b/drivers/clk/qcom/gpucc-sdm845.c
index 80898cea259a..e40efba1bf7d 100644
--- a/drivers/clk/qcom/gpucc-sdm845.c
+++ b/drivers/clk/qcom/gpucc-sdm845.c
@@ -85,7 +85,7 @@ static struct clk_rcg2 gpu_cc_gmu_clk_src = {
 	.clkr.hw.init = &(struct clk_init_data){
 		.name = "gpu_cc_gmu_clk_src",
 		.parent_names = gpu_cc_parent_names_0,
-		.num_parents = 6,
+		.num_parents = 5,
 		.ops = &clk_rcg2_shared_ops,
 	},
 };
-- 
2.20.0.rc0.387.gc7a69e6b6c-goog


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] clk: qcom: gpu_cc_gmu_clk_src has 5 parents, not 6
  2018-11-28 18:48 [PATCH] clk: qcom: gpu_cc_gmu_clk_src has 5 parents, not 6 Douglas Anderson
@ 2018-11-28 21:24 ` Stephen Boyd
  0 siblings, 0 replies; 2+ messages in thread
From: Stephen Boyd @ 2018-11-28 21:24 UTC (permalink / raw)
  To: Douglas Anderson
  Cc: Taniya Das, Kristian H . Kristensen, Jordan Crouse, Amit Nischal,
	Douglas Anderson, Michael Turquette, linux-arm-msm, linux-kernel,
	Andy Gross, David Brown, linux-soc, linux-clk

Quoting Douglas Anderson (2018-11-28 10:48:59)
> In an earlier version of commit 453361cdd757 ("clk: qcom: Add graphics
> clock controller driver for SDM845") there were 6 listed parents for
> "gpu_cc_gmu_clk_src".  In the version that landed there were 5.
> ...but "num_parents" was still left at 6.  On my system this goes boom
> at bootup.
> 
> Fixes: 453361cdd757 ("clk: qcom: Add graphics clock controller driver for SDM845")
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---

Applied to clk-next


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-11-28 21:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-28 18:48 [PATCH] clk: qcom: gpu_cc_gmu_clk_src has 5 parents, not 6 Douglas Anderson
2018-11-28 21:24 ` Stephen Boyd

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).