* [PATCH 1/4] PCI: mediatek: Remove un-used variant in struct mtk_pcie_port
2018-12-14 1:25 [PATCH 0/4] Cleanup un-used variant and un-used property for MediaTek PCIe honghui.zhang
@ 2018-12-14 1:25 ` honghui.zhang
2018-12-14 1:25 ` [PATCH 2/4] dt-bindings: PCI: MediaTek: Remove un-used property honghui.zhang
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: honghui.zhang @ 2018-12-14 1:25 UTC (permalink / raw)
To: lorenzo.pieralisi, bhelgaas, linux-arm-kernel, linux-mediatek,
linux-pci, linux-kernel, ryder.lee, matthias.bgg, robh+dt, robh
Cc: devicetree, youlin.pei, jianjun.wang, Honghui Zhang
From: Honghui Zhang <honghui.zhang@mediatek.com>
The "lane" variant in struct mtk_pcie_port is not used, remove it.
Signed-off-by: Honghui Zhang <honghui.zhang@mediatek.com>
---
drivers/pci/controller/pcie-mediatek.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/pci/controller/pcie-mediatek.c b/drivers/pci/controller/pcie-mediatek.c
index 6917aec..e307166 100644
--- a/drivers/pci/controller/pcie-mediatek.c
+++ b/drivers/pci/controller/pcie-mediatek.c
@@ -161,7 +161,6 @@ struct mtk_pcie_soc {
* @obff_ck: pointer to OBFF functional block operating clock
* @pipe_ck: pointer to LTSSM and PHY/MAC layer operating clock
* @phy: pointer to PHY control block
- * @lane: lane count
* @slot: port slot
* @irq: GIC irq
* @irq_domain: legacy INTx IRQ domain
@@ -182,7 +181,6 @@ struct mtk_pcie_port {
struct clk *obff_ck;
struct clk *pipe_ck;
struct phy *phy;
- u32 lane;
u32 slot;
int irq;
struct irq_domain *irq_domain;
@@ -895,12 +893,6 @@ static int mtk_pcie_parse_port(struct mtk_pcie *pcie,
if (!port)
return -ENOMEM;
- err = of_property_read_u32(node, "num-lanes", &port->lane);
- if (err) {
- dev_err(dev, "missing num-lanes property\n");
- return err;
- }
-
snprintf(name, sizeof(name), "port%d", slot);
regs = platform_get_resource_byname(pdev, IORESOURCE_MEM, name);
port->base = devm_ioremap_resource(dev, regs);
--
2.6.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/4] dt-bindings: PCI: MediaTek: Remove un-used property
2018-12-14 1:25 [PATCH 0/4] Cleanup un-used variant and un-used property for MediaTek PCIe honghui.zhang
2018-12-14 1:25 ` [PATCH 1/4] PCI: mediatek: Remove un-used variant in struct mtk_pcie_port honghui.zhang
@ 2018-12-14 1:25 ` honghui.zhang
2018-12-14 1:25 ` [PATCH 3/4] arm: dts: mt7623: Remove un-used property for PCIe honghui.zhang
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: honghui.zhang @ 2018-12-14 1:25 UTC (permalink / raw)
To: lorenzo.pieralisi, bhelgaas, linux-arm-kernel, linux-mediatek,
linux-pci, linux-kernel, ryder.lee, matthias.bgg, robh+dt, robh
Cc: devicetree, youlin.pei, jianjun.wang, Honghui Zhang
From: Honghui Zhang <honghui.zhang@mediatek.com>
The "num-lanes" property is not used, remove it.
Signed-off-by: Honghui Zhang <honghui.zhang@mediatek.com>
---
Documentation/devicetree/bindings/pci/mediatek-pcie.txt | 8 --------
1 file changed, 8 deletions(-)
diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie.txt b/Documentation/devicetree/bindings/pci/mediatek-pcie.txt
index 20227a8..92437a3 100644
--- a/Documentation/devicetree/bindings/pci/mediatek-pcie.txt
+++ b/Documentation/devicetree/bindings/pci/mediatek-pcie.txt
@@ -65,7 +65,6 @@ Required properties:
explanation.
- ranges: Sub-ranges distributed from the PCIe controller node. An empty
property is sufficient.
-- num-lanes: Number of lanes to use for this port.
Examples for MT7623:
@@ -118,7 +117,6 @@ Examples for MT7623:
interrupt-map-mask = <0 0 0 0>;
interrupt-map = <0 0 0 0 &sysirq GIC_SPI 193 IRQ_TYPE_LEVEL_LOW>;
ranges;
- num-lanes = <1>;
};
pcie@1,0 {
@@ -129,7 +127,6 @@ Examples for MT7623:
interrupt-map-mask = <0 0 0 0>;
interrupt-map = <0 0 0 0 &sysirq GIC_SPI 194 IRQ_TYPE_LEVEL_LOW>;
ranges;
- num-lanes = <1>;
};
pcie@2,0 {
@@ -140,7 +137,6 @@ Examples for MT7623:
interrupt-map-mask = <0 0 0 0>;
interrupt-map = <0 0 0 0 &sysirq GIC_SPI 195 IRQ_TYPE_LEVEL_LOW>;
ranges;
- num-lanes = <1>;
};
};
@@ -172,7 +168,6 @@ Examples for MT2712:
#size-cells = <2>;
#interrupt-cells = <1>;
ranges;
- num-lanes = <1>;
interrupt-map-mask = <0 0 0 7>;
interrupt-map = <0 0 0 1 &pcie_intc0 0>,
<0 0 0 2 &pcie_intc0 1>,
@@ -191,7 +186,6 @@ Examples for MT2712:
#size-cells = <2>;
#interrupt-cells = <1>;
ranges;
- num-lanes = <1>;
interrupt-map-mask = <0 0 0 7>;
interrupt-map = <0 0 0 1 &pcie_intc1 0>,
<0 0 0 2 &pcie_intc1 1>,
@@ -245,7 +239,6 @@ Examples for MT7622:
#size-cells = <2>;
#interrupt-cells = <1>;
ranges;
- num-lanes = <1>;
interrupt-map-mask = <0 0 0 7>;
interrupt-map = <0 0 0 1 &pcie_intc0 0>,
<0 0 0 2 &pcie_intc0 1>,
@@ -264,7 +257,6 @@ Examples for MT7622:
#size-cells = <2>;
#interrupt-cells = <1>;
ranges;
- num-lanes = <1>;
interrupt-map-mask = <0 0 0 7>;
interrupt-map = <0 0 0 1 &pcie_intc1 0>,
<0 0 0 2 &pcie_intc1 1>,
--
2.6.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 3/4] arm: dts: mt7623: Remove un-used property for PCIe
2018-12-14 1:25 [PATCH 0/4] Cleanup un-used variant and un-used property for MediaTek PCIe honghui.zhang
2018-12-14 1:25 ` [PATCH 1/4] PCI: mediatek: Remove un-used variant in struct mtk_pcie_port honghui.zhang
2018-12-14 1:25 ` [PATCH 2/4] dt-bindings: PCI: MediaTek: Remove un-used property honghui.zhang
@ 2018-12-14 1:25 ` honghui.zhang
2018-12-14 1:25 ` [PATCH 4/4] arm64: dts: mt7622: " honghui.zhang
2018-12-18 13:52 ` [PATCH 0/4] Cleanup un-used variant and un-used property for MediaTek PCIe Lorenzo Pieralisi
4 siblings, 0 replies; 6+ messages in thread
From: honghui.zhang @ 2018-12-14 1:25 UTC (permalink / raw)
To: lorenzo.pieralisi, bhelgaas, linux-arm-kernel, linux-mediatek,
linux-pci, linux-kernel, ryder.lee, matthias.bgg, robh+dt, robh
Cc: devicetree, youlin.pei, jianjun.wang, Honghui Zhang
From: Honghui Zhang <honghui.zhang@mediatek.com>
The "num-lanes" property for PCIe is not used, remove it.
Signed-off-by: Honghui Zhang <honghui.zhang@mediatek.com>
---
arch/arm/boot/dts/mt7623.dtsi | 3 ---
1 file changed, 3 deletions(-)
diff --git a/arch/arm/boot/dts/mt7623.dtsi b/arch/arm/boot/dts/mt7623.dtsi
index 1cdc346..4ca56d8 100644
--- a/arch/arm/boot/dts/mt7623.dtsi
+++ b/arch/arm/boot/dts/mt7623.dtsi
@@ -734,7 +734,6 @@
interrupt-map-mask = <0 0 0 0>;
interrupt-map = <0 0 0 0 &sysirq GIC_SPI 193 IRQ_TYPE_LEVEL_LOW>;
ranges;
- num-lanes = <1>;
status = "disabled";
};
@@ -746,7 +745,6 @@
interrupt-map-mask = <0 0 0 0>;
interrupt-map = <0 0 0 0 &sysirq GIC_SPI 194 IRQ_TYPE_LEVEL_LOW>;
ranges;
- num-lanes = <1>;
status = "disabled";
};
@@ -758,7 +756,6 @@
interrupt-map-mask = <0 0 0 0>;
interrupt-map = <0 0 0 0 &sysirq GIC_SPI 195 IRQ_TYPE_LEVEL_LOW>;
ranges;
- num-lanes = <1>;
status = "disabled";
};
};
--
2.6.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 4/4] arm64: dts: mt7622: Remove un-used property for PCIe
2018-12-14 1:25 [PATCH 0/4] Cleanup un-used variant and un-used property for MediaTek PCIe honghui.zhang
` (2 preceding siblings ...)
2018-12-14 1:25 ` [PATCH 3/4] arm: dts: mt7623: Remove un-used property for PCIe honghui.zhang
@ 2018-12-14 1:25 ` honghui.zhang
2018-12-18 13:52 ` [PATCH 0/4] Cleanup un-used variant and un-used property for MediaTek PCIe Lorenzo Pieralisi
4 siblings, 0 replies; 6+ messages in thread
From: honghui.zhang @ 2018-12-14 1:25 UTC (permalink / raw)
To: lorenzo.pieralisi, bhelgaas, linux-arm-kernel, linux-mediatek,
linux-pci, linux-kernel, ryder.lee, matthias.bgg, robh+dt, robh
Cc: devicetree, youlin.pei, jianjun.wang, Honghui Zhang
From: Honghui Zhang <honghui.zhang@mediatek.com>
The "num-lanes" property for PCIe is not used, remove it.
Signed-off-by: Honghui Zhang <honghui.zhang@mediatek.com>
---
arch/arm64/boot/dts/mediatek/mt7622.dtsi | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
index de2c47bd..f619eb5 100644
--- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
@@ -750,7 +750,6 @@
ranges;
status = "disabled";
- num-lanes = <1>;
interrupt-map-mask = <0 0 0 7>;
interrupt-map = <0 0 0 1 &pcie_intc0 0>,
<0 0 0 2 &pcie_intc0 1>,
@@ -771,7 +770,6 @@
ranges;
status = "disabled";
- num-lanes = <1>;
interrupt-map-mask = <0 0 0 7>;
interrupt-map = <0 0 0 1 &pcie_intc1 0>,
<0 0 0 2 &pcie_intc1 1>,
--
2.6.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 0/4] Cleanup un-used variant and un-used property for MediaTek PCIe
2018-12-14 1:25 [PATCH 0/4] Cleanup un-used variant and un-used property for MediaTek PCIe honghui.zhang
` (3 preceding siblings ...)
2018-12-14 1:25 ` [PATCH 4/4] arm64: dts: mt7622: " honghui.zhang
@ 2018-12-18 13:52 ` Lorenzo Pieralisi
4 siblings, 0 replies; 6+ messages in thread
From: Lorenzo Pieralisi @ 2018-12-18 13:52 UTC (permalink / raw)
To: honghui.zhang
Cc: bhelgaas, linux-arm-kernel, linux-mediatek, linux-pci,
linux-kernel, ryder.lee, matthias.bgg, robh+dt, robh, devicetree,
youlin.pei, jianjun.wang
On Fri, Dec 14, 2018 at 09:25:38AM +0800, honghui.zhang@mediatek.com wrote:
> From: Honghui Zhang <honghui.zhang@mediatek.com>
>
> The "num-lanes" property in MediaTek's PCIe device node is not used by
> its driver or anyone else, cleanup those related code.
>
> Honghui Zhang (4):
> PCI: mediatek: Remove un-used variant in struct mtk_pcie_port
> dt-bindings: PCI: MediaTek: Remove un-used property
> arm: dts: mt7623: Remove un-used property for PCIe
> arm64: dts: mt7622: Remove un-used property for PCIe
>
> Documentation/devicetree/bindings/pci/mediatek-pcie.txt | 8 --------
> arch/arm/boot/dts/mt7623.dtsi | 3 ---
> arch/arm64/boot/dts/mediatek/mt7622.dtsi | 2 --
> drivers/pci/controller/pcie-mediatek.c | 8 --------
> 4 files changed, 21 deletions(-)
Applied to pci/mediatek for v4.21, thanks.
Lorenzo
^ permalink raw reply [flat|nested] 6+ messages in thread