* [PATCH] regulator: mcp16502: code cleanup
@ 2018-12-17 11:44 Andrei.Stefanescu
2018-12-19 18:40 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Andrei.Stefanescu @ 2018-12-17 11:44 UTC (permalink / raw)
To: broonie, lgirdwood
Cc: linux-arm-kernel, linux-kernel, Cristian.Birsan, Nicolas.Ferre,
Andrei.Stefanescu
This patch does the following:
- align parameter with parenthesis
- fix compile error
If CONFIG_SUSPEND is not set the dummy pm_ops
callbacks are named mcp16502_suspend and mcp16502_resume
instead of mcp16502_suspend_noirq and mcp16502_resume_noirq.
Excerpt from compile log (kbuild test robot):
In file included from include/linux/device.h:23:0,
from include/linux/gpio/driver.h:5,
from include/asm-generic/gpio.h:13,
from include/linux/gpio.h:62,
from drivers/regulator/mcp16502.c:11:
>> drivers/regulator/mcp16502.c:527:32: error: 'mcp16502_suspend_noirq'
undeclared here (not in a function); did you mean 'mcp16502_suspend'?
SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(mcp16502_suspend_noirq,
>> drivers/regulator/mcp16502.c:528:10: error: 'mcp16502_resume_noirq'
undeclared here (not in a function); did you mean 'mcp16502_suspend_noirq'?
mcp16502_resume_noirq)
vim +527 drivers/regulator/mcp16502.c
524
525 #ifdef CONFIG_PM
526 static const struct dev_pm_ops mcp16502_pm_ops = {
> 527 SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(mcp16502_suspend_noirq,
> 528 mcp16502_resume_noirq)
529 };
530 #endif
531 static const struct i2c_device_id mcp16502_i2c_id[] = {
532 { "mcp16502", 0 },
533 { }
534 };
535 MODULE_DEVICE_TABLE(i2c, mcp16502_i2c_id);
536
Signed-off-by: Andrei Stefanescu <andrei.stefanescu@microchip.com>
---
drivers/regulator/mcp16502.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/regulator/mcp16502.c b/drivers/regulator/mcp16502.c
index 25d7b43..809a664 100644
--- a/drivers/regulator/mcp16502.c
+++ b/drivers/regulator/mcp16502.c
@@ -518,14 +518,14 @@ static int mcp16502_resume_noirq(struct device *dev)
return 0;
}
#else /* !CONFIG_SUSPEND */
-#define mcp16502_suspend NULL
-#define mcp16502_resume NULL
+#define mcp16502_suspend_noirq NULL
+#define mcp16502_resume_noirq NULL
#endif /* !CONFIG_SUSPEND */
#ifdef CONFIG_PM
static const struct dev_pm_ops mcp16502_pm_ops = {
SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(mcp16502_suspend_noirq,
- mcp16502_resume_noirq)
+ mcp16502_resume_noirq)
};
#endif
static const struct i2c_device_id mcp16502_i2c_id[] = {
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] regulator: mcp16502: code cleanup
2018-12-17 11:44 [PATCH] regulator: mcp16502: code cleanup Andrei.Stefanescu
@ 2018-12-19 18:40 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2018-12-19 18:40 UTC (permalink / raw)
To: Andrei.Stefanescu
Cc: lgirdwood, linux-arm-kernel, linux-kernel, Cristian.Birsan,
Nicolas.Ferre
[-- Attachment #1: Type: text/plain, Size: 709 bytes --]
On Mon, Dec 17, 2018 at 11:44:59AM +0000, Andrei.Stefanescu@microchip.com wrote:
> This patch does the following:
> - align parameter with parenthesis
> - fix compile error
>
> If CONFIG_SUSPEND is not set the dummy pm_ops
> callbacks are named mcp16502_suspend and mcp16502_resume
> instead of mcp16502_suspend_noirq and mcp16502_resume_noirq.
Thanks for fixing this.
>
> Excerpt from compile log (kbuild test robot):
There's no need to include the entire output from the kbuild robot in
your commit log, especially when it's much larger than either the change
or description of the change - it gets in the way of reading things as
it makes it harder to pick out relevant information.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-12-19 18:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-17 11:44 [PATCH] regulator: mcp16502: code cleanup Andrei.Stefanescu
2018-12-19 18:40 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).