* [PATCH -next] regulator: act8945a-regulator: make symbol act8945a_pm static
@ 2018-12-18 7:10 Wei Yongjun
2018-12-20 10:45 ` Boris Brezillon
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2018-12-18 7:10 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown, Boris Brezillon
Cc: Wei Yongjun, linux-kernel, kernel-janitors
Fixes the following sparse warning:
drivers/regulator/act8945a-regulator.c:340:1: warning:
symbol 'act8945a_pm' was not declared. Should it be static?
Fixes: 7482d6ecc68e ("regulator: act8945a-regulator: Implement PM functionalities")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/regulator/act8945a-regulator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/act8945a-regulator.c b/drivers/regulator/act8945a-regulator.c
index 90572b6..dc3942b 100644
--- a/drivers/regulator/act8945a-regulator.c
+++ b/drivers/regulator/act8945a-regulator.c
@@ -337,7 +337,7 @@ static int act8945a_suspend(struct device *pdev)
return regmap_write(act8945a->regmap, ACT8945A_SYS_CTRL, 0x42);
}
-SIMPLE_DEV_PM_OPS(act8945a_pm, act8945a_suspend, NULL);
+static SIMPLE_DEV_PM_OPS(act8945a_pm, act8945a_suspend, NULL);
static void act8945a_pmic_shutdown(struct platform_device *pdev)
{
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] regulator: act8945a-regulator: make symbol act8945a_pm static
2018-12-18 7:10 [PATCH -next] regulator: act8945a-regulator: make symbol act8945a_pm static Wei Yongjun
@ 2018-12-20 10:45 ` Boris Brezillon
0 siblings, 0 replies; 2+ messages in thread
From: Boris Brezillon @ 2018-12-20 10:45 UTC (permalink / raw)
To: Wei Yongjun; +Cc: Liam Girdwood, Mark Brown, linux-kernel, kernel-janitors
On Tue, 18 Dec 2018 07:10:21 +0000
Wei Yongjun <weiyongjun1@huawei.com> wrote:
> Fixes the following sparse warning:
>
> drivers/regulator/act8945a-regulator.c:340:1: warning:
> symbol 'act8945a_pm' was not declared. Should it be static?
>
> Fixes: 7482d6ecc68e ("regulator: act8945a-regulator: Implement PM functionalities")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Boris Brezillon <boris.brezillon@bootlin.com>
> ---
> drivers/regulator/act8945a-regulator.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/regulator/act8945a-regulator.c b/drivers/regulator/act8945a-regulator.c
> index 90572b6..dc3942b 100644
> --- a/drivers/regulator/act8945a-regulator.c
> +++ b/drivers/regulator/act8945a-regulator.c
> @@ -337,7 +337,7 @@ static int act8945a_suspend(struct device *pdev)
> return regmap_write(act8945a->regmap, ACT8945A_SYS_CTRL, 0x42);
> }
>
> -SIMPLE_DEV_PM_OPS(act8945a_pm, act8945a_suspend, NULL);
> +static SIMPLE_DEV_PM_OPS(act8945a_pm, act8945a_suspend, NULL);
>
> static void act8945a_pmic_shutdown(struct platform_device *pdev)
> {
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-12-20 10:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-18 7:10 [PATCH -next] regulator: act8945a-regulator: make symbol act8945a_pm static Wei Yongjun
2018-12-20 10:45 ` Boris Brezillon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).