From: Zhang Rui <rui.zhang@intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>, Sinan Kaya <okaya@kernel.org>
Cc: Linux-Next Mailing List <linux-next@vger.kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Eduardo Valentin <edubezval@gmail.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Amit Kucheria <amit.kucheria@linaro.org>,
"open list:THERMAL" <linux-pm@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 07/11] drivers: thermal: int3406_thermal: Make PCI dependency explicit
Date: Tue, 08 Jan 2019 19:58:05 +0800 [thread overview]
Message-ID: <1546948685.2072.95.camel@intel.com> (raw)
In-Reply-To: <CAJZ5v0gst1ZDgG-uP9GUUB1ziPnqhfArio3um=wCQjfbeH2_iw@mail.gmail.com>
On 一, 2019-01-07 at 12:19 +0100, Rafael J. Wysocki wrote:
> On Sat, Jan 5, 2019 at 11:06 AM Sinan Kaya <okaya@kernel.org> wrote:
> >
> >
> > After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built
> > without
> > CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
> > satisfied implicitly through dependencies on CONFIG_ACPI have to be
> > specified directly. Need CONFIG_PCI to be set in order to be able
> > to use
> > this driver.
> >
> > Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without
> > CONFIG_PCI set")
> > Signed-off-by: Sinan Kaya <okaya@kernel.org>
> > ---
> > drivers/thermal/intel/int340x_thermal/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/thermal/intel/int340x_thermal/Kconfig
> > b/drivers/thermal/intel/int340x_thermal/Kconfig
> > index 0582bd12a239..fba1976d5f8d 100644
> > --- a/drivers/thermal/intel/int340x_thermal/Kconfig
> > +++ b/drivers/thermal/intel/int340x_thermal/Kconfig
> > @@ -31,7 +31,7 @@ if INT340X_THERMAL
> >
> > config INT3406_THERMAL
> > tristate "ACPI INT3406 display thermal driver"
> > - depends on ACPI_VIDEO
> > + depends on ACPI_VIDEO && PCI
> > help
> > The display thermal device represents the LED/LCD display
> > panel
> > that may or may not include touch support. The main
> > function of
> > --
> Rui, any objections here? And for the [11/11]?
CONFIG_INT3406_THERMAL depends on CONFIG_INT340X_THERMAL, so IMO, patch
11 is sufficient.
thanks,
rui
next prev parent reply other threads:[~2019-01-08 11:58 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190105100606.6673-1-okaya@kernel.org>
2019-01-05 10:05 ` [PATCH v6 01/11] ACPI / LPSS: Make PCI dependency explicit Sinan Kaya
2019-01-05 10:05 ` [PATCH v6 02/11] ata: pata_acpi: " Sinan Kaya
2019-01-05 10:05 ` [PATCH v6 03/11] vga-switcheroo: make " Sinan Kaya
2019-01-05 10:05 ` [PATCH v6 04/11] platform/x86: intel_ips: " Sinan Kaya
2019-01-05 10:06 ` [PATCH v6 05/11] platform/x86: intel_pmc: Make " Sinan Kaya
2019-01-09 10:47 ` Rafael J. Wysocki
2019-01-09 11:10 ` Andy Shevchenko
2019-01-15 18:40 ` Rafael J. Wysocki
2019-01-05 10:06 ` [PATCH v6 06/11] platform/x86: apple-gmux: " Sinan Kaya
2019-01-05 10:06 ` [PATCH v6 07/11] drivers: thermal: int3406_thermal: " Sinan Kaya
2019-01-07 11:19 ` Rafael J. Wysocki
2019-01-08 11:58 ` Zhang Rui [this message]
2019-01-08 13:03 ` Sinan Kaya
2019-01-05 10:06 ` [PATCH v6 08/11] ASoC: Intel: atom: " Sinan Kaya
2019-01-07 11:15 ` Rafael J. Wysocki
2019-01-07 12:19 ` Mark Brown
2019-01-07 15:16 ` Sinan Kaya
2019-01-07 15:41 ` Mark Brown
2019-01-07 15:13 ` Sinan Kaya
2019-01-05 10:06 ` [PATCH v6 09/11] mmc: sdhci-acpi: " Sinan Kaya
2019-01-07 11:17 ` Rafael J. Wysocki
2019-01-07 12:42 ` Adrian Hunter
2019-01-07 12:48 ` Shah, Nehal-bakulchandra
2019-01-09 2:10 ` Wang, Dongsheng
2019-01-08 13:27 ` Arnd Bergmann
2019-01-14 8:32 ` Adrian Hunter
2019-01-14 11:44 ` Ulf Hansson
2019-01-05 10:06 ` [PATCH v6 10/11] x86/intel/lpss: " Sinan Kaya
2019-01-05 10:06 ` [PATCH v6 11/11] drivers: thermal: int340x_thermal: " Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1546948685.2072.95.camel@intel.com \
--to=rui.zhang@intel.com \
--cc=amit.kucheria@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=edubezval@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=okaya@kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).