linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Sinan Kaya <okaya@kernel.org>,
	Andy Shevchenko <andy@infradead.org>,
	linux-next <linux-next@vger.kernel.org>,
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
	Darren Hart <dvhart@infradead.org>,
	"open list:X86 PLATFORM DRIVERS" 
	<platform-driver-x86@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 05/11] platform/x86: intel_pmc: Make PCI dependency explicit
Date: Tue, 15 Jan 2019 19:40:45 +0100	[thread overview]
Message-ID: <3717479.LUAfB5gYd9@aspire.rjw.lan> (raw)
In-Reply-To: <CAHp75VeKB_4Fc-G_QG0YnSqhAu9w8csASrgrg0cVAo_gYjeJ_g@mail.gmail.com>

On Wednesday, January 9, 2019 12:10:45 PM CET Andy Shevchenko wrote:
> On Wed, Jan 9, 2019 at 12:48 PM Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> >
> > On Saturday, January 5, 2019 11:06:00 AM CET Sinan Kaya wrote:
> > > After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
> > > CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
> > > satisfied implicitly through dependencies on CONFIG_ACPI have to be
> > > specified directly. Code relies on PCI for execution. Specify this
> > > in the Kconfig.
> > >
> > > Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
> > > Signed-off-by: Sinan Kaya <okaya@kernel.org>
> > > ---
> > >  drivers/platform/x86/Kconfig | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> > > index b36ea14b41ad..7afb96cb1cd6 100644
> > > --- a/drivers/platform/x86/Kconfig
> > > +++ b/drivers/platform/x86/Kconfig
> > > @@ -1174,7 +1174,7 @@ config INTEL_SMARTCONNECT
> > >
> > >  config INTEL_PMC_IPC
> > >       tristate "Intel PMC IPC Driver"
> > > -     depends on ACPI
> > > +     depends on ACPI && PCI
> > >       ---help---
> > >       This driver provides support for PMC control on some Intel platforms.
> > >       The PMC is an ARC processor which defines IPC commands for communication
> >
> > Andy, you had some reservations regarding this patch IIRC.
> >
> > Should I apply it?
> 
> Let's do it as a quick fix with something like below being added to
> the commit message:
> 
> "For sake of a quick fix this introduces a new mandatory dependency to
> the driver which may survive without it. Otherwise we need to revisit
> the driver architecture to address this properly."

Done, thanks!


  reply	other threads:[~2019-01-15 18:41 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190105100606.6673-1-okaya@kernel.org>
2019-01-05 10:05 ` [PATCH v6 01/11] ACPI / LPSS: Make PCI dependency explicit Sinan Kaya
2019-01-05 10:05 ` [PATCH v6 02/11] ata: pata_acpi: " Sinan Kaya
2019-01-05 10:05 ` [PATCH v6 03/11] vga-switcheroo: make " Sinan Kaya
2019-01-05 10:05 ` [PATCH v6 04/11] platform/x86: intel_ips: " Sinan Kaya
2019-01-05 10:06 ` [PATCH v6 05/11] platform/x86: intel_pmc: Make " Sinan Kaya
2019-01-09 10:47   ` Rafael J. Wysocki
2019-01-09 11:10     ` Andy Shevchenko
2019-01-15 18:40       ` Rafael J. Wysocki [this message]
2019-01-05 10:06 ` [PATCH v6 06/11] platform/x86: apple-gmux: " Sinan Kaya
2019-01-05 10:06 ` [PATCH v6 07/11] drivers: thermal: int3406_thermal: " Sinan Kaya
2019-01-07 11:19   ` Rafael J. Wysocki
2019-01-08 11:58     ` Zhang Rui
2019-01-08 13:03       ` Sinan Kaya
2019-01-05 10:06 ` [PATCH v6 08/11] ASoC: Intel: atom: " Sinan Kaya
2019-01-07 11:15   ` Rafael J. Wysocki
2019-01-07 12:19     ` Mark Brown
2019-01-07 15:16       ` Sinan Kaya
2019-01-07 15:41         ` Mark Brown
2019-01-07 15:13     ` Sinan Kaya
2019-01-05 10:06 ` [PATCH v6 09/11] mmc: sdhci-acpi: " Sinan Kaya
2019-01-07 11:17   ` Rafael J. Wysocki
2019-01-07 12:42     ` Adrian Hunter
2019-01-07 12:48       ` Shah, Nehal-bakulchandra
2019-01-09  2:10       ` Wang, Dongsheng
2019-01-08 13:27   ` Arnd Bergmann
2019-01-14  8:32   ` Adrian Hunter
2019-01-14 11:44   ` Ulf Hansson
2019-01-05 10:06 ` [PATCH v6 10/11] x86/intel/lpss: " Sinan Kaya
2019-01-05 10:06 ` [PATCH v6 11/11] drivers: thermal: int340x_thermal: " Sinan Kaya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3717479.LUAfB5gYd9@aspire.rjw.lan \
    --to=rjw@rjwysocki.net \
    --cc=andy.shevchenko@gmail.com \
    --cc=andy@infradead.org \
    --cc=dvhart@infradead.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=okaya@kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).