* [PATCH v4] driver: uio: fix possible memory leak in uio_open
@ 2019-01-08 13:38 Liu Jian
2019-01-22 11:01 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Liu Jian @ 2019-01-08 13:38 UTC (permalink / raw)
To: gregkh; +Cc: xiubli, liujian56, linux-kernel
If 'idev->info' is NULL, we need to free 'listerner'
Fixes: 57c5f4df0a5a ("uio: fix crash after the device is unregistered")
Signed-off-by: Liu Jian <liujian56@huawei.com>
---
v1->v2:
rename the "err_infoopen" to "err_idev_info"
v2->3:
put the extra info after the "--"
v3-v4:
add git log
drivers/uio/uio.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/uio/uio.c b/drivers/uio/uio.c
index 1313422..b4ae2d9 100644
--- a/drivers/uio/uio.c
+++ b/drivers/uio/uio.c
@@ -491,18 +491,19 @@ static int uio_open(struct inode *inode, struct file *filep)
if (!idev->info) {
mutex_unlock(&idev->info_lock);
ret = -EINVAL;
- goto err_alloc_listener;
+ goto err_idev_info;
}
if (idev->info && idev->info->open)
ret = idev->info->open(idev->info, inode);
mutex_unlock(&idev->info_lock);
if (ret)
- goto err_infoopen;
+ goto err_idev_info;
return 0;
-err_infoopen:
+err_idev_info:
+ filep->private_data = NULL;
kfree(listener);
err_alloc_listener:
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v4] driver: uio: fix possible memory leak in uio_open
2019-01-08 13:38 [PATCH v4] driver: uio: fix possible memory leak in uio_open Liu Jian
@ 2019-01-22 11:01 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2019-01-22 11:01 UTC (permalink / raw)
To: Liu Jian; +Cc: xiubli, linux-kernel
On Tue, Jan 08, 2019 at 09:38:43PM +0800, Liu Jian wrote:
> If 'idev->info' is NULL, we need to free 'listerner'
"listener", right?
Please fix up and resend.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-22 11:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-08 13:38 [PATCH v4] driver: uio: fix possible memory leak in uio_open Liu Jian
2019-01-22 11:01 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).