[PATCH net] net: phy: phy driver features are mandatory

* [PATCH net] net: phy: phy driver features are mandatory
@ 2019-01-15 12:35 Camelia Groza
  2019-01-15 14:05 ` Andrew Lunn
  2019-01-16  8:58 ` [net] b8154ef682: WARNING:at_drivers/net/phy/phy_device.c:#phy_driver_register kernel test robot
  0 siblings, 2 replies; 5+ messages in thread
From: Camelia Groza @ 2019-01-15 12:35 UTC (permalink / raw)
  To: andrew, f.fainelli, hkallweit1, davem, oss
  Cc: netdev, linux-kernel, Camelia Groza

Since phy driver features became a link_mode bitmap, phy drivers that
don't have a list of features configured will cause the kernel to crash
when probed.

Prevent the phy driver from registering if the features field is missing.

Fixes: 719655a14971 ("net: phy: Replace phy driver features u32 with link_mode bitmap")
Reported-by: Scott Wood <oss@buserror.net>
Signed-off-by: Camelia Groza <camelia.groza@nxp.com>
---
This patch should be merged to 4.20 stable.
---
 drivers/net/phy/phy_device.c | 3 +++
 include/linux/phy.h          | 4 ++--
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
index 5199000..f70dfb3 100644
--- a/drivers/net/phy/phy_device.c
+++ b/drivers/net/phy/phy_device.c
@@ -2243,6 +2243,9 @@ int phy_driver_register(struct phy_driver *new_driver, struct module *owner)
 {
 	int retval;
 
+	if (WARN_ON(!new_driver->features))
+		return -EINVAL;
+
 	new_driver->mdiodrv.flags |= MDIO_DEVICE_IS_PHY;
 	new_driver->mdiodrv.driver.name = new_driver->name;
 	new_driver->mdiodrv.driver.bus = &mdio_bus_type;
diff --git a/include/linux/phy.h b/include/linux/phy.h
index 3b051f7..ec3b6d5 100644
--- a/include/linux/phy.h
+++ b/include/linux/phy.h
@@ -467,8 +467,8 @@ struct phy_device {
  *   only works for PHYs with IDs which match this field
  * name: The friendly name of this PHY type
  * phy_id_mask: Defines the important bits of the phy_id
- * features: A list of features (speed, duplex, etc) supported
- *   by this PHY
+ * features: A mandatory list of features (speed, duplex, etc)
+ *   supported by this PHY
  * flags: A bitfield defining certain other features this PHY
  *   supports (like interrupts)
  *
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread