* [PATCH] doc: memcontrol: fix the obsolete content about force empty
@ 2019-01-15 23:51 Yang Shi
2019-01-16 21:52 ` Jonathan Corbet
0 siblings, 1 reply; 2+ messages in thread
From: Yang Shi @ 2019-01-15 23:51 UTC (permalink / raw)
To: mhocko, shakeelb, hannes, akpm, corbet
Cc: yang.shi, linux-mm, linux-doc, linux-kernel
We don't do page cache reparent anymore when offlining memcg, so update
force empty related content accordingly.
Reviewed-by: Shakeel Butt <shakeelb@google.com>
Acked-by: Michal Hocko <mhocko@suse.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Signed-off-by: Yang Shi <yang.shi@linux.alibaba.com>
---
Documentation/cgroup-v1/memory.txt | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/Documentation/cgroup-v1/memory.txt b/Documentation/cgroup-v1/memory.txt
index 3682e99..8e2cb1d 100644
--- a/Documentation/cgroup-v1/memory.txt
+++ b/Documentation/cgroup-v1/memory.txt
@@ -70,7 +70,7 @@ Brief summary of control files.
memory.soft_limit_in_bytes # set/show soft limit of memory usage
memory.stat # show various statistics
memory.use_hierarchy # set/show hierarchical account enabled
- memory.force_empty # trigger forced move charge to parent
+ memory.force_empty # trigger forced page reclaim
memory.pressure_level # set memory pressure notifications
memory.swappiness # set/show swappiness parameter of vmscan
(See sysctl's vm.swappiness)
@@ -459,8 +459,9 @@ About use_hierarchy, see Section 6.
the cgroup will be reclaimed and as many pages reclaimed as possible.
The typical use case for this interface is before calling rmdir().
- Because rmdir() moves all pages to parent, some out-of-use page caches can be
- moved to the parent. If you want to avoid that, force_empty will be useful.
+ Though rmdir() offlines memcg, but the memcg may still stay there due to
+ charged file caches. Some out-of-use page caches may keep charged until
+ memory pressure happens. If you want to avoid that, force_empty will be useful.
Also, note that when memory.kmem.limit_in_bytes is set the charges due to
kernel pages will still be seen. This is not considered a failure and the
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] doc: memcontrol: fix the obsolete content about force empty
2019-01-15 23:51 [PATCH] doc: memcontrol: fix the obsolete content about force empty Yang Shi
@ 2019-01-16 21:52 ` Jonathan Corbet
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Corbet @ 2019-01-16 21:52 UTC (permalink / raw)
To: Yang Shi
Cc: mhocko, shakeelb, hannes, akpm, linux-mm, linux-doc, linux-kernel
On Wed, 16 Jan 2019 07:51:35 +0800
Yang Shi <yang.shi@linux.alibaba.com> wrote:
> We don't do page cache reparent anymore when offlining memcg, so update
> force empty related content accordingly.
>
> Reviewed-by: Shakeel Butt <shakeelb@google.com>
> Acked-by: Michal Hocko <mhocko@suse.com>
> Cc: Johannes Weiner <hannes@cmpxchg.org>
> Signed-off-by: Yang Shi <yang.shi@linux.alibaba.com>
> ---
> Documentation/cgroup-v1/memory.txt | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
Applied, thanks.
jon
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-16 21:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-15 23:51 [PATCH] doc: memcontrol: fix the obsolete content about force empty Yang Shi
2019-01-16 21:52 ` Jonathan Corbet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).