linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drivers: pwm: pwm-bcm-kona: update macros to remove braces around numbers
@ 2019-01-16 19:41 Sheetal Tigadoli
  2019-01-17 19:36 ` Uwe Kleine-König
  2019-03-04 11:27 ` Thierry Reding
  0 siblings, 2 replies; 3+ messages in thread
From: Sheetal Tigadoli @ 2019-01-16 19:41 UTC (permalink / raw)
  To: Thierry Reding, Florian Fainelli, Ray Jui, Scott Branden
  Cc: bcm-kernel-feedback-list, linux-pwm, linux-kernel, Sheetal Tigadoli

update macros to remove braces around numbers

Signed-off-by: Sheetal Tigadoli <sheetal.tigadoli@broadcom.com>
---
 drivers/pwm/pwm-bcm-kona.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/pwm/pwm-bcm-kona.c b/drivers/pwm/pwm-bcm-kona.c
index 09a95ae..81da91d 100644
--- a/drivers/pwm/pwm-bcm-kona.c
+++ b/drivers/pwm/pwm-bcm-kona.c
@@ -45,25 +45,25 @@
  *    high or low depending on its state at that exact instant.
  */
 
-#define PWM_CONTROL_OFFSET			(0x00000000)
+#define PWM_CONTROL_OFFSET			0x00000000
 #define PWM_CONTROL_SMOOTH_SHIFT(chan)		(24 + (chan))
 #define PWM_CONTROL_TYPE_SHIFT(chan)		(16 + (chan))
 #define PWM_CONTROL_POLARITY_SHIFT(chan)	(8 + (chan))
 #define PWM_CONTROL_TRIGGER_SHIFT(chan)		(chan)
 
-#define PRESCALE_OFFSET				(0x00000004)
+#define PRESCALE_OFFSET				0x00000004
 #define PRESCALE_SHIFT(chan)			((chan) << 2)
 #define PRESCALE_MASK(chan)			(0x7 << PRESCALE_SHIFT(chan))
-#define PRESCALE_MIN				(0x00000000)
-#define PRESCALE_MAX				(0x00000007)
+#define PRESCALE_MIN				0x00000000
+#define PRESCALE_MAX				0x00000007
 
 #define PERIOD_COUNT_OFFSET(chan)		(0x00000008 + ((chan) << 3))
-#define PERIOD_COUNT_MIN			(0x00000002)
-#define PERIOD_COUNT_MAX			(0x00ffffff)
+#define PERIOD_COUNT_MIN			0x00000002
+#define PERIOD_COUNT_MAX			0x00ffffff
 
 #define DUTY_CYCLE_HIGH_OFFSET(chan)		(0x0000000c + ((chan) << 3))
-#define DUTY_CYCLE_HIGH_MIN			(0x00000000)
-#define DUTY_CYCLE_HIGH_MAX			(0x00ffffff)
+#define DUTY_CYCLE_HIGH_MIN			0x00000000
+#define DUTY_CYCLE_HIGH_MAX			0x00ffffff
 
 struct kona_pwmc {
 	struct pwm_chip chip;
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] drivers: pwm: pwm-bcm-kona: update macros to remove braces around numbers
  2019-01-16 19:41 [PATCH] drivers: pwm: pwm-bcm-kona: update macros to remove braces around numbers Sheetal Tigadoli
@ 2019-01-17 19:36 ` Uwe Kleine-König
  2019-03-04 11:27 ` Thierry Reding
  1 sibling, 0 replies; 3+ messages in thread
From: Uwe Kleine-König @ 2019-01-17 19:36 UTC (permalink / raw)
  To: Sheetal Tigadoli
  Cc: Thierry Reding, Florian Fainelli, Ray Jui, Scott Branden,
	bcm-kernel-feedback-list, linux-pwm, linux-kernel

Hello,

I'm sure Thierry doesn't want "drivers:" in the Subject, but usually he
just fixes up stuff like that while applying, so I expect no reason to
resend.

On Thu, Jan 17, 2019 at 01:11:22AM +0530, Sheetal Tigadoli wrote:
> update macros to remove braces around numbers
> 
> Signed-off-by: Sheetal Tigadoli <sheetal.tigadoli@broadcom.com>
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Thanks
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] drivers: pwm: pwm-bcm-kona: update macros to remove braces around numbers
  2019-01-16 19:41 [PATCH] drivers: pwm: pwm-bcm-kona: update macros to remove braces around numbers Sheetal Tigadoli
  2019-01-17 19:36 ` Uwe Kleine-König
@ 2019-03-04 11:27 ` Thierry Reding
  1 sibling, 0 replies; 3+ messages in thread
From: Thierry Reding @ 2019-03-04 11:27 UTC (permalink / raw)
  To: Sheetal Tigadoli
  Cc: Florian Fainelli, Ray Jui, Scott Branden,
	bcm-kernel-feedback-list, linux-pwm, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 605 bytes --]

On Thu, Jan 17, 2019 at 01:11:22AM +0530, Sheetal Tigadoli wrote:
> update macros to remove braces around numbers
> 
> Signed-off-by: Sheetal Tigadoli <sheetal.tigadoli@broadcom.com>
> ---
>  drivers/pwm/pwm-bcm-kona.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)

Applied, thanks.

I dropped the "drivers: " prefix and shortened pwm-bcm-kona to bcm-kona
because PWM is already implied by the "pwm: " prefix. I've also replaced
the commit message with a real rationale rather than repeating the
subject.

Please keep this in mind for future patches.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-03-04 11:27 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-16 19:41 [PATCH] drivers: pwm: pwm-bcm-kona: update macros to remove braces around numbers Sheetal Tigadoli
2019-01-17 19:36 ` Uwe Kleine-König
2019-03-04 11:27 ` Thierry Reding

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).