* [PATCH 0/2] mtd: rawnand: denali: just trivial cleanups @ 2019-01-24 4:19 Masahiro Yamada 2019-01-24 4:19 ` [PATCH 1/2] mtd: rawnand: denali: remove unneeded denali_reset_irq() call Masahiro Yamada ` (2 more replies) 0 siblings, 3 replies; 4+ messages in thread From: Masahiro Yamada @ 2019-01-24 4:19 UTC (permalink / raw) To: linux-mtd, Boris Brezillon, Miquel Raynal Cc: Masahiro Yamada, Brian Norris, linux-kernel, Marek Vasut, Richard Weinberger, David Woodhouse, Boris Brezillon Masahiro Yamada (2): mtd: rawnand: denali: remove unneeded denali_reset_irq() call mtd: rawnand: denali: remove unused function argument 'raw' drivers/mtd/nand/raw/denali.c | 21 +++++++++------------ 1 file changed, 9 insertions(+), 12 deletions(-) -- 2.7.4 ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/2] mtd: rawnand: denali: remove unneeded denali_reset_irq() call 2019-01-24 4:19 [PATCH 0/2] mtd: rawnand: denali: just trivial cleanups Masahiro Yamada @ 2019-01-24 4:19 ` Masahiro Yamada 2019-01-24 4:19 ` [PATCH 2/2] mtd: rawnand: denali: remove unused function argument 'raw' Masahiro Yamada 2019-01-25 13:14 ` [PATCH 0/2] mtd: rawnand: denali: just trivial cleanups Miquel Raynal 2 siblings, 0 replies; 4+ messages in thread From: Masahiro Yamada @ 2019-01-24 4:19 UTC (permalink / raw) To: linux-mtd, Boris Brezillon, Miquel Raynal Cc: Masahiro Yamada, Brian Norris, linux-kernel, Marek Vasut, Richard Weinberger, David Woodhouse, Boris Brezillon This code was added by commit 26d266e10e5e ("mtd: nand: denali: fix raw and oob accessors for syndrome page layout"), but I do not see sensible reason. The IRQ flags are correctly reset by denali_cmd_ctrl(), so this code is unneeded. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- drivers/mtd/nand/raw/denali.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/mtd/nand/raw/denali.c b/drivers/mtd/nand/raw/denali.c index 21320b1..6775644 100644 --- a/drivers/mtd/nand/raw/denali.c +++ b/drivers/mtd/nand/raw/denali.c @@ -751,9 +751,6 @@ static int denali_read_oob(struct nand_chip *chip, int page) static int denali_write_oob(struct nand_chip *chip, int page) { struct mtd_info *mtd = nand_to_mtd(chip); - struct denali_nand_info *denali = mtd_to_denali(mtd); - - denali_reset_irq(denali); denali_oob_xfer(mtd, chip, page, 1); -- 2.7.4 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] mtd: rawnand: denali: remove unused function argument 'raw' 2019-01-24 4:19 [PATCH 0/2] mtd: rawnand: denali: just trivial cleanups Masahiro Yamada 2019-01-24 4:19 ` [PATCH 1/2] mtd: rawnand: denali: remove unneeded denali_reset_irq() call Masahiro Yamada @ 2019-01-24 4:19 ` Masahiro Yamada 2019-01-25 13:14 ` [PATCH 0/2] mtd: rawnand: denali: just trivial cleanups Miquel Raynal 2 siblings, 0 replies; 4+ messages in thread From: Masahiro Yamada @ 2019-01-24 4:19 UTC (permalink / raw) To: linux-mtd, Boris Brezillon, Miquel Raynal Cc: Masahiro Yamada, Brian Norris, linux-kernel, Marek Vasut, Richard Weinberger, David Woodhouse, Boris Brezillon This argument is not used at all. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- drivers/mtd/nand/raw/denali.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/mtd/nand/raw/denali.c b/drivers/mtd/nand/raw/denali.c index 6775644..24aeafc 100644 --- a/drivers/mtd/nand/raw/denali.c +++ b/drivers/mtd/nand/raw/denali.c @@ -473,7 +473,7 @@ static void denali_setup_dma32(struct denali_nand_info *denali, } static int denali_pio_read(struct denali_nand_info *denali, void *buf, - size_t size, int page, int raw) + size_t size, int page) { u32 addr = DENALI_MAP01 | DENALI_BANK(denali) | page; uint32_t *buf32 = (uint32_t *)buf; @@ -501,7 +501,7 @@ static int denali_pio_read(struct denali_nand_info *denali, void *buf, } static int denali_pio_write(struct denali_nand_info *denali, - const void *buf, size_t size, int page, int raw) + const void *buf, size_t size, int page) { u32 addr = DENALI_MAP01 | DENALI_BANK(denali) | page; const uint32_t *buf32 = (uint32_t *)buf; @@ -522,16 +522,16 @@ static int denali_pio_write(struct denali_nand_info *denali, } static int denali_pio_xfer(struct denali_nand_info *denali, void *buf, - size_t size, int page, int raw, int write) + size_t size, int page, int write) { if (write) - return denali_pio_write(denali, buf, size, page, raw); + return denali_pio_write(denali, buf, size, page); else - return denali_pio_read(denali, buf, size, page, raw); + return denali_pio_read(denali, buf, size, page); } static int denali_dma_xfer(struct denali_nand_info *denali, void *buf, - size_t size, int page, int raw, int write) + size_t size, int page, int write) { dma_addr_t dma_addr; uint32_t irq_mask, irq_status, ecc_err_mask; @@ -541,7 +541,7 @@ static int denali_dma_xfer(struct denali_nand_info *denali, void *buf, dma_addr = dma_map_single(denali->dev, buf, size, dir); if (dma_mapping_error(denali->dev, dma_addr)) { dev_dbg(denali->dev, "Failed to DMA-map buffer. Trying PIO.\n"); - return denali_pio_xfer(denali, buf, size, page, raw, write); + return denali_pio_xfer(denali, buf, size, page, write); } if (write) { @@ -595,9 +595,9 @@ static int denali_data_xfer(struct denali_nand_info *denali, void *buf, denali->reg + TRANSFER_SPARE_REG); if (denali->dma_avail) - return denali_dma_xfer(denali, buf, size, page, raw, write); + return denali_dma_xfer(denali, buf, size, page, write); else - return denali_pio_xfer(denali, buf, size, page, raw, write); + return denali_pio_xfer(denali, buf, size, page, write); } static void denali_oob_xfer(struct mtd_info *mtd, struct nand_chip *chip, -- 2.7.4 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 0/2] mtd: rawnand: denali: just trivial cleanups 2019-01-24 4:19 [PATCH 0/2] mtd: rawnand: denali: just trivial cleanups Masahiro Yamada 2019-01-24 4:19 ` [PATCH 1/2] mtd: rawnand: denali: remove unneeded denali_reset_irq() call Masahiro Yamada 2019-01-24 4:19 ` [PATCH 2/2] mtd: rawnand: denali: remove unused function argument 'raw' Masahiro Yamada @ 2019-01-25 13:14 ` Miquel Raynal 2 siblings, 0 replies; 4+ messages in thread From: Miquel Raynal @ 2019-01-25 13:14 UTC (permalink / raw) To: Masahiro Yamada Cc: linux-mtd, Boris Brezillon, Brian Norris, linux-kernel, Marek Vasut, Richard Weinberger, David Woodhouse, Boris Brezillon Hi Masahiro, Masahiro Yamada <yamada.masahiro@socionext.com> wrote on Thu, 24 Jan 2019 13:19:05 +0900: > Masahiro Yamada (2): > mtd: rawnand: denali: remove unneeded denali_reset_irq() call > mtd: rawnand: denali: remove unused function argument 'raw' > > drivers/mtd/nand/raw/denali.c | 21 +++++++++------------ > 1 file changed, 9 insertions(+), 12 deletions(-) > Series applied to nand/next. Thanks, Miquèl ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-01-25 13:14 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-01-24 4:19 [PATCH 0/2] mtd: rawnand: denali: just trivial cleanups Masahiro Yamada 2019-01-24 4:19 ` [PATCH 1/2] mtd: rawnand: denali: remove unneeded denali_reset_irq() call Masahiro Yamada 2019-01-24 4:19 ` [PATCH 2/2] mtd: rawnand: denali: remove unused function argument 'raw' Masahiro Yamada 2019-01-25 13:14 ` [PATCH 0/2] mtd: rawnand: denali: just trivial cleanups Miquel Raynal
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).