* [PATCH -next] extcon: ptn5150: Fix return value check in ptn5150_i2c_probe()
@ 2019-01-25 1:45 Wei Yongjun
0 siblings, 0 replies; only message in thread
From: Wei Yongjun @ 2019-01-25 1:45 UTC (permalink / raw)
To: MyungJoo Ham, Chanwoo Choi, Vijai Kumar K
Cc: Wei Yongjun, linux-kernel, kernel-janitors
In case of error, the function devm_gpiod_get() returns ERR_PTR() and
never returns NULL. The NULL test in the return value check should be
replaced with IS_ERR().
Fixes: 58963276749e ("extcon: Add support for ptn5150 extcon driver")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/extcon/extcon-ptn5150.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/extcon/extcon-ptn5150.c b/drivers/extcon/extcon-ptn5150.c
index 155620b..8217fdc 100644
--- a/drivers/extcon/extcon-ptn5150.c
+++ b/drivers/extcon/extcon-ptn5150.c
@@ -240,14 +240,14 @@ static int ptn5150_i2c_probe(struct i2c_client *i2c,
info->dev = &i2c->dev;
info->i2c = i2c;
info->int_gpiod = devm_gpiod_get(&i2c->dev, "int", GPIOD_IN);
- if (!info->int_gpiod) {
+ if (IS_ERR(info->int_gpiod)) {
dev_err(dev, "failed to get INT GPIO\n");
- return -EINVAL;
+ return PTR_ERR(info->int_gpiod);
}
info->vbus_gpiod = devm_gpiod_get(&i2c->dev, "vbus", GPIOD_IN);
- if (!info->vbus_gpiod) {
+ if (IS_ERR(info->vbus_gpiod)) {
dev_err(dev, "failed to get VBUS GPIO\n");
- return -EINVAL;
+ return PTR_ERR(info->vbus_gpiod);
}
ret = gpiod_direction_output(info->vbus_gpiod, 0);
if (ret) {
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2019-01-25 1:40 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-25 1:45 [PATCH -next] extcon: ptn5150: Fix return value check in ptn5150_i2c_probe() Wei Yongjun
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).