* [PATCH -next] drm/xen-front: Drop pointless static qualifier in fb_destroy()
@ 2019-01-26 12:05 YueHaibing
2019-01-28 6:36 ` Oleksandr Andrushchenko
2019-02-04 6:56 ` [Xen-devel] " Oleksandr Andrushchenko
0 siblings, 2 replies; 4+ messages in thread
From: YueHaibing @ 2019-01-26 12:05 UTC (permalink / raw)
To: Oleksandr Andrushchenko, David Airlie, Daniel Vetter
Cc: YueHaibing, dri-devel, xen-devel, linux-kernel, kernel-janitors
There is no need to have the 'struct drm_framebuffer *fb' variable
static since new value always be assigned before use it.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/gpu/drm/xen/xen_drm_front_kms.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/xen/xen_drm_front_kms.c b/drivers/gpu/drm/xen/xen_drm_front_kms.c
index 860da05..c2955d3 100644
--- a/drivers/gpu/drm/xen/xen_drm_front_kms.c
+++ b/drivers/gpu/drm/xen/xen_drm_front_kms.c
@@ -54,7 +54,7 @@ static void fb_destroy(struct drm_framebuffer *fb)
const struct drm_mode_fb_cmd2 *mode_cmd)
{
struct xen_drm_front_drm_info *drm_info = dev->dev_private;
- static struct drm_framebuffer *fb;
+ struct drm_framebuffer *fb;
struct drm_gem_object *gem_obj;
int ret;
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH -next] drm/xen-front: Drop pointless static qualifier in fb_destroy()
2019-01-26 12:05 [PATCH -next] drm/xen-front: Drop pointless static qualifier in fb_destroy() YueHaibing
@ 2019-01-28 6:36 ` Oleksandr Andrushchenko
2019-02-01 8:55 ` Oleksandr Andrushchenko
2019-02-04 6:56 ` [Xen-devel] " Oleksandr Andrushchenko
1 sibling, 1 reply; 4+ messages in thread
From: Oleksandr Andrushchenko @ 2019-01-28 6:36 UTC (permalink / raw)
To: YueHaibing, David Airlie, Daniel Vetter
Cc: dri-devel, xen-devel, linux-kernel, kernel-janitors
On 1/26/19 2:05 PM, YueHaibing wrote:
> There is no need to have the 'struct drm_framebuffer *fb' variable
> static since new value always be assigned before use it.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Good catch, thank you!
Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> ---
> drivers/gpu/drm/xen/xen_drm_front_kms.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xen/xen_drm_front_kms.c b/drivers/gpu/drm/xen/xen_drm_front_kms.c
> index 860da05..c2955d3 100644
> --- a/drivers/gpu/drm/xen/xen_drm_front_kms.c
> +++ b/drivers/gpu/drm/xen/xen_drm_front_kms.c
> @@ -54,7 +54,7 @@ static void fb_destroy(struct drm_framebuffer *fb)
> const struct drm_mode_fb_cmd2 *mode_cmd)
> {
> struct xen_drm_front_drm_info *drm_info = dev->dev_private;
> - static struct drm_framebuffer *fb;
> + struct drm_framebuffer *fb;
> struct drm_gem_object *gem_obj;
> int ret;
>
>
>
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH -next] drm/xen-front: Drop pointless static qualifier in fb_destroy()
2019-01-28 6:36 ` Oleksandr Andrushchenko
@ 2019-02-01 8:55 ` Oleksandr Andrushchenko
0 siblings, 0 replies; 4+ messages in thread
From: Oleksandr Andrushchenko @ 2019-02-01 8:55 UTC (permalink / raw)
To: YueHaibing, David Airlie, Daniel Vetter
Cc: dri-devel, xen-devel, linux-kernel, kernel-janitors
On 1/28/19 8:36 AM, Oleksandr Andrushchenko wrote:
> On 1/26/19 2:05 PM, YueHaibing wrote:
>> There is no need to have the 'struct drm_framebuffer *fb' variable
>> static since new value always be assigned before use it.
>>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> Good catch, thank you!
> Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
If nobody objects I'll apply this to drm-misc-fixes next Monday
>> ---
>> drivers/gpu/drm/xen/xen_drm_front_kms.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/xen/xen_drm_front_kms.c
>> b/drivers/gpu/drm/xen/xen_drm_front_kms.c
>> index 860da05..c2955d3 100644
>> --- a/drivers/gpu/drm/xen/xen_drm_front_kms.c
>> +++ b/drivers/gpu/drm/xen/xen_drm_front_kms.c
>> @@ -54,7 +54,7 @@ static void fb_destroy(struct drm_framebuffer *fb)
>> const struct drm_mode_fb_cmd2 *mode_cmd)
>> {
>> struct xen_drm_front_drm_info *drm_info = dev->dev_private;
>> - static struct drm_framebuffer *fb;
>> + struct drm_framebuffer *fb;
>> struct drm_gem_object *gem_obj;
>> int ret;
>>
>>
>>
>>
>>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Xen-devel] [PATCH -next] drm/xen-front: Drop pointless static qualifier in fb_destroy()
2019-01-26 12:05 [PATCH -next] drm/xen-front: Drop pointless static qualifier in fb_destroy() YueHaibing
2019-01-28 6:36 ` Oleksandr Andrushchenko
@ 2019-02-04 6:56 ` Oleksandr Andrushchenko
1 sibling, 0 replies; 4+ messages in thread
From: Oleksandr Andrushchenko @ 2019-02-04 6:56 UTC (permalink / raw)
To: YueHaibing, Oleksandr Andrushchenko, David Airlie, Daniel Vetter
Cc: kernel-janitors, linux-kernel, dri-devel, xen-devel
On 1/26/19 2:05 PM, YueHaibing wrote:
> There is no need to have the 'struct drm_framebuffer *fb' variable
> static since new value always be assigned before use it.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/gpu/drm/xen/xen_drm_front_kms.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xen/xen_drm_front_kms.c b/drivers/gpu/drm/xen/xen_drm_front_kms.c
> index 860da05..c2955d3 100644
> --- a/drivers/gpu/drm/xen/xen_drm_front_kms.c
> +++ b/drivers/gpu/drm/xen/xen_drm_front_kms.c
> @@ -54,7 +54,7 @@ static void fb_destroy(struct drm_framebuffer *fb)
> const struct drm_mode_fb_cmd2 *mode_cmd)
> {
> struct xen_drm_front_drm_info *drm_info = dev->dev_private;
> - static struct drm_framebuffer *fb;
> + struct drm_framebuffer *fb;
> struct drm_gem_object *gem_obj;
> int ret;
>
Applied to drm-misc-next
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-02-04 6:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-26 12:05 [PATCH -next] drm/xen-front: Drop pointless static qualifier in fb_destroy() YueHaibing
2019-01-28 6:36 ` Oleksandr Andrushchenko
2019-02-01 8:55 ` Oleksandr Andrushchenko
2019-02-04 6:56 ` [Xen-devel] " Oleksandr Andrushchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).