From: Atish Patra <atish.patra@wdc.com>
To: linux-riscv@lists.infradead.org
Cc: "Atish Patra" <atish.patra@wdc.com>,
"Alan Kao" <alankao@andestech.com>,
"Albert Ou" <aou@eecs.berkeley.edu>,
"Andreas Schwab" <schwab@suse.de>,
"Anup Patel" <anup@brainfault.org>,
"Daniel Lezcano" <daniel.lezcano@linaro.org>,
"Dmitriy Cherkasov" <dmitriy@oss-tech.org>,
"Jason Cooper" <jason@lakedaemon.net>,
linux-kernel@vger.kernel.org,
"Marc Zyngier" <marc.zyngier@arm.com>,
"Palmer Dabbelt" <palmer@sifive.com>,
"Patrick Stählin" <me@packi.ch>,
"Paul Walmsley" <paul.walmsley@sifive.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Zong Li" <zongbox@gmail.com>,
"Damien Le Moal" <Damien.LeMoal@wdc.com>
Subject: [v3 PATCH 7/8] irqchip/irq-sifive-plic:: Check and continue in case of an invalid cpuid.
Date: Thu, 7 Feb 2019 17:51:20 -0800 [thread overview]
Message-ID: <1549590681-24125-8-git-send-email-atish.patra@wdc.com> (raw)
In-Reply-To: <1549590681-24125-1-git-send-email-atish.patra@wdc.com>
riscv_hartid_to_cpuid can return invalid cpuid for a hart
that is present in DT but was never brought up.
Print the appropriate warning message and continue.
Signed-off-by: Atish Patra <atish.patra@wdc.com>
Reviewed-by: Anup Patel <anup@brainfault.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
---
drivers/irqchip/irq-sifive-plic.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/irqchip/irq-sifive-plic.c b/drivers/irqchip/irq-sifive-plic.c
index 357e9daf..254ecd76 100644
--- a/drivers/irqchip/irq-sifive-plic.c
+++ b/drivers/irqchip/irq-sifive-plic.c
@@ -237,6 +237,11 @@ static int __init plic_init(struct device_node *node,
}
cpu = riscv_hartid_to_cpuid(hartid);
+ if (cpu < 0) {
+ pr_warn("Invalid cpuid for context %d\n", i);
+ continue;
+ }
+
handler = per_cpu_ptr(&plic_handlers, cpu);
handler->present = true;
handler->ctxid = i;
--
2.7.4
next prev parent reply other threads:[~2019-02-08 1:51 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-08 1:51 [v3 PATCH 0/8] Various SMP related fixes Atish Patra
2019-02-08 1:51 ` [v3 PATCH 1/8] RISC-V: Do not wait indefinitely in __cpu_up Atish Patra
2019-02-08 9:01 ` Christoph Hellwig
2019-02-08 1:51 ` [v3 PATCH 2/8] RISC-V: Move cpuid to hartid mapping to SMP Atish Patra
2019-02-08 9:03 ` Christoph Hellwig
2019-02-08 22:56 ` Atish Patra
2019-02-08 1:51 ` [v3 PATCH 3/8] RISC-V: Remove NR_CPUs check during hartid search from DT Atish Patra
2019-02-08 1:51 ` [v3 PATCH 4/8] RISC-V: Allow hartid-to-cpuid function to fail Atish Patra
2019-02-08 1:51 ` [v3 PATCH 5/8] RISC-V: Compare cpuid with NR_CPUS before mapping Atish Patra
2019-02-08 1:51 ` [v3 PATCH 6/8] clocksource/drivers/riscv: Add required checks during clock source init Atish Patra
2019-02-08 9:04 ` Christoph Hellwig
2019-02-08 22:56 ` Atish Patra
2019-02-08 1:51 ` Atish Patra [this message]
2019-02-08 1:51 ` [v3 PATCH 8/8] RISC-V: Assign hwcap only according to boot cpu Atish Patra
2019-02-08 9:11 ` Christoph Hellwig
2019-02-08 23:02 ` Atish Patra
2019-02-09 4:26 ` David Abdurachmanov
2019-02-09 16:11 ` Marc Zyngier
2019-02-11 19:02 ` Palmer Dabbelt
2019-02-11 20:03 ` Atish Patra
2019-02-11 22:13 ` Marc Zyngier
2019-02-11 22:23 ` Palmer Dabbelt
2019-02-11 23:25 ` Atish Patra
2019-02-11 13:23 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1549590681-24125-8-git-send-email-atish.patra@wdc.com \
--to=atish.patra@wdc.com \
--cc=Damien.LeMoal@wdc.com \
--cc=alankao@andestech.com \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=daniel.lezcano@linaro.org \
--cc=dmitriy@oss-tech.org \
--cc=jason@lakedaemon.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=marc.zyngier@arm.com \
--cc=me@packi.ch \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
--cc=schwab@suse.de \
--cc=tglx@linutronix.de \
--cc=zongbox@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).