From: Gaurav Kohli <gkohli@codeaurora.org>
To: srinivas.kandagatla@linaro.org, linux-kernel@vger.kernel.org
Cc: linux-arm-msm@vger.kernel.org, Gaurav Kohli <gkohli@codeaurora.org>
Subject: [PATCH v2] nvmem: core: Set no-read-write provider to avoid userspace read/write
Date: Sun, 17 Mar 2019 19:42:20 +0530 [thread overview]
Message-ID: <1552831940-7327-1-git-send-email-gkohli@codeaurora.org> (raw)
Current nvmem framework allows user space to read all register space
populated by nvmem binary file, In case we don't want to expose value
of registers to userspace and only want kernel space to read cell
value from nvmem_cell_read_u32.
To protect the same, Add no-read-write property to prevent read
from userspace.
Signed-off-by: Gaurav Kohli <gkohli@codeaurora.org>
---
v2: Fix build error
v1: Fix no_read_write update condition
diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
index f24008b..f1c44fc 100644
--- a/drivers/nvmem/core.c
+++ b/drivers/nvmem/core.c
@@ -27,6 +27,7 @@ struct nvmem_device {
struct kref refcnt;
size_t size;
bool read_only;
+ bool no_read_write;
int flags;
enum nvmem_type type;
struct bin_attribute eeprom;
@@ -120,6 +121,10 @@ static ssize_t bin_attr_nvmem_read(struct file *filp, struct kobject *kobj,
dev = container_of(kobj, struct device, kobj);
nvmem = to_nvmem_device(dev);
+ /* if no-read-write, then stop from reading */
+ if (nvmem->no_read_write)
+ return -EPERM;
+
/* Stop the user from reading */
if (pos >= nvmem->size)
return 0;
@@ -154,6 +159,10 @@ static ssize_t bin_attr_nvmem_write(struct file *filp, struct kobject *kobj,
dev = container_of(kobj, struct device, kobj);
nvmem = to_nvmem_device(dev);
+ /* if no-read-write, then stop from writing */
+ if (nvmem->no_read_write)
+ return -EPERM;
+
/* Stop the user from writing */
if (pos >= nvmem->size)
return -EFBIG;
@@ -651,6 +660,9 @@ struct nvmem_device *nvmem_register(const struct nvmem_config *config)
nvmem->read_only = device_property_present(config->dev, "read-only") ||
config->read_only || !nvmem->reg_write;
+ nvmem->no_read_write = device_property_present(config->dev,
+ "no-read-write");
+
if (config->root_only)
nvmem->dev.groups = nvmem->read_only ?
nvmem_ro_root_dev_groups :
--
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.
next reply other threads:[~2019-03-17 14:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-17 14:12 Gaurav Kohli [this message]
2019-03-20 14:34 ` [PATCH v2] nvmem: core: Set no-read-write provider to avoid userspace read/write Srinivas Kandagatla
2019-03-20 15:50 ` Gaurav Kohli
2019-03-20 16:26 ` Srinivas Kandagatla
2019-03-20 17:50 ` Gaurav Kohli
2019-03-21 13:14 ` Marc Gonzalez
2019-03-22 15:02 ` Srinivas Kandagatla
2019-03-22 18:12 ` Gaurav Kohli
2019-03-25 6:15 ` Gaurav Kohli
2019-04-01 4:52 ` Gaurav Kohli
2019-04-02 7:35 ` Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1552831940-7327-1-git-send-email-gkohli@codeaurora.org \
--to=gkohli@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).