linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Gaurav Kohli <gkohli@codeaurora.org>, linux-kernel@vger.kernel.org
Cc: linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v2] nvmem: core: Set no-read-write provider to avoid userspace read/write
Date: Wed, 20 Mar 2019 16:26:05 +0000	[thread overview]
Message-ID: <865519b5-62c9-3eb3-3855-eebf98bded85@linaro.org> (raw)
In-Reply-To: <5f11070f-bf9b-c313-9a78-e412a2fb2908@codeaurora.org>



On 20/03/2019 15:50, Gaurav Kohli wrote:
> 
> On 3/20/2019 8:04 PM, Srinivas Kandagatla wrote:
>>
>>
>> On 17/03/2019 14:12, Gaurav Kohli wrote:
>>> Current nvmem framework allows user space to read all register space
>>> populated by nvmem binary file, In case we don't want to expose value
>>> of registers to userspace and only want kernel space to read cell
>>> value from nvmem_cell_read_u32.
>>>
>>> To protect the same, Add no-read-write property to prevent read
>>> from userspace.
>>>
>>
>> Can you explain the real need of this?
>> Is there any issue you are noticing while reading nvmem content from 
>> userspace?
>>
> Hi Srinivas,
> 
> 
> No, We are not observing any issue, nvmem is dumping the data properly.
> 
> But there are certain register, which we don't want to expose to user 
> space and want kernel space can only read via nvmem_cell_read.
Am guessing these are some kind of keys or something that you do not 
want user to see.

Is root only option not helping you in this case?

We could go down the route of adding new config option something like 
CONFIG_NVMEM_NO_SYSFS_ENTRY to prevent adding nvmem entry in userspace.

Let me know if you are happy to create a patch for this change?

Thanks,
srini

> 
> In existing design, even if we read cell from kernel space, nvmem binary 
> files is still populated to user space unconditionally.
> 
> Regards
> 
> Gaurav

  reply	other threads:[~2019-03-20 16:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-17 14:12 [PATCH v2] nvmem: core: Set no-read-write provider to avoid userspace read/write Gaurav Kohli
2019-03-20 14:34 ` Srinivas Kandagatla
2019-03-20 15:50   ` Gaurav Kohli
2019-03-20 16:26     ` Srinivas Kandagatla [this message]
2019-03-20 17:50       ` Gaurav Kohli
2019-03-21 13:14         ` Marc Gonzalez
2019-03-22 15:02         ` Srinivas Kandagatla
2019-03-22 18:12           ` Gaurav Kohli
2019-03-25  6:15             ` Gaurav Kohli
2019-04-01  4:52               ` Gaurav Kohli
2019-04-02  7:35           ` Niklas Cassel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=865519b5-62c9-3eb3-3855-eebf98bded85@linaro.org \
    --to=srinivas.kandagatla@linaro.org \
    --cc=gkohli@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).