* [PATCH] net:mwl8k:move spin_lock_bh to spin_lock in tasklet
@ 2019-03-19 16:24 Jeff Xie
2019-03-20 7:08 ` Menion
2019-04-26 11:57 ` [PATCH] mwl8k: move " Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Jeff Xie @ 2019-03-19 16:24 UTC (permalink / raw)
To: buytenh, kvalo; +Cc: davem, chongguiguzi, linux-wireless, netdev, linux-kernel
It is unnecessary to call spin_lock_bh in a tasklet.
Signed-off-by: Jeff Xie <chongguiguzi@gmail.com>
---
drivers/net/wireless/marvell/mwl8k.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/marvell/mwl8k.c b/drivers/net/wireless/marvell/mwl8k.c
index 8e4e9b6..21a86cc 100644
--- a/drivers/net/wireless/marvell/mwl8k.c
+++ b/drivers/net/wireless/marvell/mwl8k.c
@@ -4631,7 +4631,7 @@ static void mwl8k_tx_poll(unsigned long data)
limit = 32;
- spin_lock_bh(&priv->tx_lock);
+ spin_lock(&priv->tx_lock);
for (i = 0; i < mwl8k_tx_queues(priv); i++)
limit -= mwl8k_txq_reclaim(hw, i, limit, 0);
@@ -4641,7 +4641,7 @@ static void mwl8k_tx_poll(unsigned long data)
priv->tx_wait = NULL;
}
- spin_unlock_bh(&priv->tx_lock);
+ spin_unlock(&priv->tx_lock);
if (limit) {
writel(~MWL8K_A2H_INT_TX_DONE,
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net:mwl8k:move spin_lock_bh to spin_lock in tasklet
2019-03-19 16:24 [PATCH] net:mwl8k:move spin_lock_bh to spin_lock in tasklet Jeff Xie
@ 2019-03-20 7:08 ` Menion
2019-04-26 11:57 ` [PATCH] mwl8k: move " Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Menion @ 2019-03-20 7:08 UTC (permalink / raw)
To: Jeff Xie; +Cc: buytenh, kvalo, davem, linux-wireless, netdev, linux-kernel
Is it possible that this solves this long standing issue? :
https://www.spinics.net/lists/linux-wireless/msg151171.html
Bye
Il giorno mar 19 mar 2019 alle ore 17:25 Jeff Xie
<chongguiguzi@gmail.com> ha scritto:
>
> It is unnecessary to call spin_lock_bh in a tasklet.
>
> Signed-off-by: Jeff Xie <chongguiguzi@gmail.com>
> ---
> drivers/net/wireless/marvell/mwl8k.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/marvell/mwl8k.c b/drivers/net/wireless/marvell/mwl8k.c
> index 8e4e9b6..21a86cc 100644
> --- a/drivers/net/wireless/marvell/mwl8k.c
> +++ b/drivers/net/wireless/marvell/mwl8k.c
> @@ -4631,7 +4631,7 @@ static void mwl8k_tx_poll(unsigned long data)
>
> limit = 32;
>
> - spin_lock_bh(&priv->tx_lock);
> + spin_lock(&priv->tx_lock);
>
> for (i = 0; i < mwl8k_tx_queues(priv); i++)
> limit -= mwl8k_txq_reclaim(hw, i, limit, 0);
> @@ -4641,7 +4641,7 @@ static void mwl8k_tx_poll(unsigned long data)
> priv->tx_wait = NULL;
> }
>
> - spin_unlock_bh(&priv->tx_lock);
> + spin_unlock(&priv->tx_lock);
>
> if (limit) {
> writel(~MWL8K_A2H_INT_TX_DONE,
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mwl8k: move spin_lock_bh to spin_lock in tasklet
2019-03-19 16:24 [PATCH] net:mwl8k:move spin_lock_bh to spin_lock in tasklet Jeff Xie
2019-03-20 7:08 ` Menion
@ 2019-04-26 11:57 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2019-04-26 11:57 UTC (permalink / raw)
To: Jeff Xie
Cc: buytenh, davem, chongguiguzi, linux-wireless, netdev, linux-kernel
Jeff Xie <chongguiguzi@gmail.com> wrote:
> It is unnecessary to call spin_lock_bh in a tasklet.
>
> Signed-off-by: Jeff Xie <chongguiguzi@gmail.com>
Patch applied to wireless-drivers-next.git, thanks.
0b2ff1ff64c8 mwl8k: move spin_lock_bh to spin_lock in tasklet
--
https://patchwork.kernel.org/patch/10859991/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-26 11:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-19 16:24 [PATCH] net:mwl8k:move spin_lock_bh to spin_lock in tasklet Jeff Xie
2019-03-20 7:08 ` Menion
2019-04-26 11:57 ` [PATCH] mwl8k: move " Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).