* [PATCH v2] tpm: fix an invalid condition in tpm_common_poll
@ 2019-03-19 20:31 Tadeusz Struk
2019-03-20 14:30 ` James Bottomley
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Tadeusz Struk @ 2019-03-19 20:31 UTC (permalink / raw)
To: jarkko.sakkinen
Cc: grawity, James.Bottomley, linux-integrity, linux-kernel, tadeusz.struk
The poll condition should only check response_length,
because reads should only be issued if there is data to read.
The response_read flag only prevents double writes.
The problem was that the write set the response_read to false,
enqued a tpm job, and returned. Then application called poll
which checked the response_read flag and returned EPOLLIN.
Then the application called read, but got nothing.
After all that the async_work kicked in.
Added also mutex_lock around the poll check to prevent
other possible race conditions.
Fixes: 9488585b21bef0df12 ("tpm: add support for partial reads")
Reported-by: Mantas Mikulėnas <grawity@gmail.com>
Signed-off-by: Tadeusz Struk <tadeusz.struk@intel.com>
---
drivers/char/tpm/tpm-dev-common.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/char/tpm/tpm-dev-common.c b/drivers/char/tpm/tpm-dev-common.c
index 5eecad233ea1..7312d3214381 100644
--- a/drivers/char/tpm/tpm-dev-common.c
+++ b/drivers/char/tpm/tpm-dev-common.c
@@ -203,12 +203,14 @@ __poll_t tpm_common_poll(struct file *file, poll_table *wait)
__poll_t mask = 0;
poll_wait(file, &priv->async_wait, wait);
+ mutex_lock(&priv->buffer_mutex);
- if (!priv->response_read || priv->response_length)
+ if (priv->response_length)
mask = EPOLLIN | EPOLLRDNORM;
else
mask = EPOLLOUT | EPOLLWRNORM;
+ mutex_unlock(&priv->buffer_mutex);
return mask;
}
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2] tpm: fix an invalid condition in tpm_common_poll
2019-03-19 20:31 [PATCH v2] tpm: fix an invalid condition in tpm_common_poll Tadeusz Struk
@ 2019-03-20 14:30 ` James Bottomley
2019-03-20 14:49 ` Tadeusz Struk
2019-03-20 18:51 ` Mantas Mikulėnas
2019-03-21 13:59 ` Jarkko Sakkinen
2 siblings, 1 reply; 7+ messages in thread
From: James Bottomley @ 2019-03-20 14:30 UTC (permalink / raw)
To: Tadeusz Struk, jarkko.sakkinen; +Cc: grawity, linux-integrity, linux-kernel
On Tue, 2019-03-19 at 13:31 -0700, Tadeusz Struk wrote:
> The poll condition should only check response_length,
> because reads should only be issued if there is data to read.
> The response_read flag only prevents double writes.
> The problem was that the write set the response_read to false,
> enqued a tpm job, and returned. Then application called poll
> which checked the response_read flag and returned EPOLLIN.
> Then the application called read, but got nothing.
> After all that the async_work kicked in.
> Added also mutex_lock around the poll check to prevent
> other possible race conditions.
>
> Fixes: 9488585b21bef0df12 ("tpm: add support for partial reads")
> Reported-by: Mantas Mikulėnas <grawity@gmail.com>
> Signed-off-by: Tadeusz Struk <tadeusz.struk@intel.com>
> ---
> drivers/char/tpm/tpm-dev-common.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/char/tpm/tpm-dev-common.c
> b/drivers/char/tpm/tpm-dev-common.c
> index 5eecad233ea1..7312d3214381 100644
> --- a/drivers/char/tpm/tpm-dev-common.c
> +++ b/drivers/char/tpm/tpm-dev-common.c
> @@ -203,12 +203,14 @@ __poll_t tpm_common_poll(struct file *file,
> poll_table *wait)
> __poll_t mask = 0;
>
> poll_wait(file, &priv->async_wait, wait);
> + mutex_lock(&priv->buffer_mutex);
>
> - if (!priv->response_read || priv->response_length)
> + if (priv->response_length)
> mask = EPOLLIN | EPOLLRDNORM;
> else
> mask = EPOLLOUT | EPOLLWRNORM;
>
> + mutex_unlock(&priv->buffer_mutex);
Just an observation on this: the mutex is now no-longer necessary
because a read on a size_t quantity is always atomic.
James
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] tpm: fix an invalid condition in tpm_common_poll
2019-03-20 14:30 ` James Bottomley
@ 2019-03-20 14:49 ` Tadeusz Struk
0 siblings, 0 replies; 7+ messages in thread
From: Tadeusz Struk @ 2019-03-20 14:49 UTC (permalink / raw)
To: James Bottomley, jarkko.sakkinen; +Cc: grawity, linux-integrity, linux-kernel
On 3/20/19 7:30 AM, James Bottomley wrote:
> Just an observation on this: the mutex is now no-longer necessary
> because a read on a size_t quantity is always atomic.
True, that's why it wasn't there at the beginning, but
then things changed and I forgot to add it, so let's
put it there just in case.
Thanks,
--
Tadeusz
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] tpm: fix an invalid condition in tpm_common_poll
2019-03-19 20:31 [PATCH v2] tpm: fix an invalid condition in tpm_common_poll Tadeusz Struk
2019-03-20 14:30 ` James Bottomley
@ 2019-03-20 18:51 ` Mantas Mikulėnas
2019-03-20 19:18 ` Tadeusz Struk
2019-03-21 13:59 ` Jarkko Sakkinen
2 siblings, 1 reply; 7+ messages in thread
From: Mantas Mikulėnas @ 2019-03-20 18:51 UTC (permalink / raw)
To: Tadeusz Struk
Cc: Jarkko Sakkinen, James.Bottomley, linux-integrity,
Linux Kernel Mailing List
On Tue, Mar 19, 2019 at 10:31 PM Tadeusz Struk <tadeusz.struk@intel.com> wrote:
>
> The poll condition should only check response_length,
> because reads should only be issued if there is data to read.
> The response_read flag only prevents double writes.
> The problem was that the write set the response_read to false,
> enqued a tpm job, and returned. Then application called poll
> which checked the response_read flag and returned EPOLLIN.
> Then the application called read, but got nothing.
> After all that the async_work kicked in.
> Added also mutex_lock around the poll check to prevent
> other possible race conditions.
>
> Fixes: 9488585b21bef0df12 ("tpm: add support for partial reads")
> Reported-by: Mantas Mikulėnas <grawity@gmail.com>
> Signed-off-by: Tadeusz Struk <tadeusz.struk@intel.com>
> ---
> drivers/char/tpm/tpm-dev-common.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/char/tpm/tpm-dev-common.c b/drivers/char/tpm/tpm-dev-common.c
> index 5eecad233ea1..7312d3214381 100644
> --- a/drivers/char/tpm/tpm-dev-common.c
> +++ b/drivers/char/tpm/tpm-dev-common.c
> @@ -203,12 +203,14 @@ __poll_t tpm_common_poll(struct file *file, poll_table *wait)
> __poll_t mask = 0;
>
> poll_wait(file, &priv->async_wait, wait);
> + mutex_lock(&priv->buffer_mutex);
>
> - if (!priv->response_read || priv->response_length)
> + if (priv->response_length)
> mask = EPOLLIN | EPOLLRDNORM;
> else
> mask = EPOLLOUT | EPOLLWRNORM;
>
> + mutex_unlock(&priv->buffer_mutex);
> return mask;
> }
Thanks, this patch seems to work, and I apologize for not responding
to test the patches earlier.
Any chance it'll be submitted for stable 5.0.x as well?
--
Mantas Mikulėnas
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] tpm: fix an invalid condition in tpm_common_poll
2019-03-20 18:51 ` Mantas Mikulėnas
@ 2019-03-20 19:18 ` Tadeusz Struk
2019-03-21 14:04 ` Jarkko Sakkinen
0 siblings, 1 reply; 7+ messages in thread
From: Tadeusz Struk @ 2019-03-20 19:18 UTC (permalink / raw)
To: Mantas Mikulėnas
Cc: Jarkko Sakkinen, James.Bottomley, linux-integrity,
Linux Kernel Mailing List
On 3/20/19 11:51 AM, Mantas Mikulėnas wrote:
> Thanks, this patch seems to work, and I apologize for not responding
> to test the patches earlier.
Thanks for testing.
>
> Any chance it'll be submitted for stable 5.0.x as well?
Yes, it's a regression. I included the "Fixes" tag so
it should be applied to all affected versions.
In this case it's 5.0 only.
Thanks,
--
Tadeusz
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] tpm: fix an invalid condition in tpm_common_poll
2019-03-19 20:31 [PATCH v2] tpm: fix an invalid condition in tpm_common_poll Tadeusz Struk
2019-03-20 14:30 ` James Bottomley
2019-03-20 18:51 ` Mantas Mikulėnas
@ 2019-03-21 13:59 ` Jarkko Sakkinen
2 siblings, 0 replies; 7+ messages in thread
From: Jarkko Sakkinen @ 2019-03-21 13:59 UTC (permalink / raw)
To: Tadeusz Struk; +Cc: grawity, James.Bottomley, linux-integrity, linux-kernel
On Tue, Mar 19, 2019 at 01:31:34PM -0700, Tadeusz Struk wrote:
> The poll condition should only check response_length,
> because reads should only be issued if there is data to read.
> The response_read flag only prevents double writes.
> The problem was that the write set the response_read to false,
> enqued a tpm job, and returned. Then application called poll
> which checked the response_read flag and returned EPOLLIN.
> Then the application called read, but got nothing.
> After all that the async_work kicked in.
> Added also mutex_lock around the poll check to prevent
> other possible race conditions.
>
> Fixes: 9488585b21bef0df12 ("tpm: add support for partial reads")
> Reported-by: Mantas Mikulėnas <grawity@gmail.com>
> Signed-off-by: Tadeusz Struk <tadeusz.struk@intel.com>
Can you send v3 with the comment and cc to stable? Then this
should be fine.
/Jarkko
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] tpm: fix an invalid condition in tpm_common_poll
2019-03-20 19:18 ` Tadeusz Struk
@ 2019-03-21 14:04 ` Jarkko Sakkinen
0 siblings, 0 replies; 7+ messages in thread
From: Jarkko Sakkinen @ 2019-03-21 14:04 UTC (permalink / raw)
To: Tadeusz Struk
Cc: Mantas Mikulėnas, James.Bottomley, linux-integrity,
Linux Kernel Mailing List
On Wed, Mar 20, 2019 at 12:18:42PM -0700, Tadeusz Struk wrote:
> On 3/20/19 11:51 AM, Mantas Mikulėnas wrote:
> > Thanks, this patch seems to work, and I apologize for not responding
> > to test the patches earlier.
>
> Thanks for testing.
>
> >
> > Any chance it'll be submitted for stable 5.0.x as well?
>
> Yes, it's a regression. I included the "Fixes" tag so
> it should be applied to all affected versions.
> In this case it's 5.0 only.
> Thanks,
> --
> Tadeusz
Add a tested-by for the next version.
/Jarkko
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-03-21 14:05 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-19 20:31 [PATCH v2] tpm: fix an invalid condition in tpm_common_poll Tadeusz Struk
2019-03-20 14:30 ` James Bottomley
2019-03-20 14:49 ` Tadeusz Struk
2019-03-20 18:51 ` Mantas Mikulėnas
2019-03-20 19:18 ` Tadeusz Struk
2019-03-21 14:04 ` Jarkko Sakkinen
2019-03-21 13:59 ` Jarkko Sakkinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).