* [PATCH v1] clk: mediatek: fix clk-gate flag setting
@ 2019-04-12 3:30 Weiyi Lu
2019-04-12 13:49 ` Matthias Brugger
2019-04-12 16:41 ` Stephen Boyd
0 siblings, 2 replies; 3+ messages in thread
From: Weiyi Lu @ 2019-04-12 3:30 UTC (permalink / raw)
To: Nicolas Boichat, Matthias Brugger, Stephen Boyd, Rob Herring
Cc: James Liao, Fan Chen, linux-arm-kernel, linux-kernel,
linux-mediatek, linux-clk, srv_heupstream, stable, Weiyi Lu
CLK_SET_RATE_PARENT would be dropped.
Merge two flag setting together to correct the error.
Fixes: 5a1cc4c27ad2 ("clk: mediatek: Add flags to mtk_gate")
Cc: <stable@vger.kernel.org>
Signed-off-by: Weiyi Lu <weiyi.lu@mediatek.com>
---
drivers/clk/mediatek/clk-gate.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/clk/mediatek/clk-gate.c b/drivers/clk/mediatek/clk-gate.c
index 9628d4e7690b..85daf826619a 100644
--- a/drivers/clk/mediatek/clk-gate.c
+++ b/drivers/clk/mediatek/clk-gate.c
@@ -169,11 +169,10 @@ struct clk *mtk_clk_register_gate(
return ERR_PTR(-ENOMEM);
init.name = name;
- init.flags = CLK_SET_RATE_PARENT;
+ init.flags = flags | CLK_SET_RATE_PARENT;
init.parent_names = parent_name ? &parent_name : NULL;
init.num_parents = parent_name ? 1 : 0;
init.ops = ops;
- init.flags = flags;
cg->regmap = regmap;
cg->set_ofs = set_ofs;
--
2.18.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1] clk: mediatek: fix clk-gate flag setting
2019-04-12 3:30 [PATCH v1] clk: mediatek: fix clk-gate flag setting Weiyi Lu
@ 2019-04-12 13:49 ` Matthias Brugger
2019-04-12 16:41 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Matthias Brugger @ 2019-04-12 13:49 UTC (permalink / raw)
To: Weiyi Lu, Nicolas Boichat, Stephen Boyd, Rob Herring
Cc: James Liao, Fan Chen, linux-arm-kernel, linux-kernel,
linux-mediatek, linux-clk, srv_heupstream, stable
On 12/04/2019 05:30, Weiyi Lu wrote:
> CLK_SET_RATE_PARENT would be dropped.
> Merge two flag setting together to correct the error.
>
> Fixes: 5a1cc4c27ad2 ("clk: mediatek: Add flags to mtk_gate")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Weiyi Lu <weiyi.lu@mediatek.com>
Good catch.
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> ---
> drivers/clk/mediatek/clk-gate.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/clk/mediatek/clk-gate.c b/drivers/clk/mediatek/clk-gate.c
> index 9628d4e7690b..85daf826619a 100644
> --- a/drivers/clk/mediatek/clk-gate.c
> +++ b/drivers/clk/mediatek/clk-gate.c
> @@ -169,11 +169,10 @@ struct clk *mtk_clk_register_gate(
> return ERR_PTR(-ENOMEM);
>
> init.name = name;
> - init.flags = CLK_SET_RATE_PARENT;
> + init.flags = flags | CLK_SET_RATE_PARENT;
> init.parent_names = parent_name ? &parent_name : NULL;
> init.num_parents = parent_name ? 1 : 0;
> init.ops = ops;
> - init.flags = flags;
>
> cg->regmap = regmap;
> cg->set_ofs = set_ofs;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] clk: mediatek: fix clk-gate flag setting
2019-04-12 3:30 [PATCH v1] clk: mediatek: fix clk-gate flag setting Weiyi Lu
2019-04-12 13:49 ` Matthias Brugger
@ 2019-04-12 16:41 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2019-04-12 16:41 UTC (permalink / raw)
To: Matthias Brugger, Nicolas Boichat, Rob Herring, Weiyi Lu
Cc: James Liao, Fan Chen, linux-arm-kernel, linux-kernel,
linux-mediatek, linux-clk, srv_heupstream, stable, Weiyi Lu
Quoting Weiyi Lu (2019-04-11 20:30:27)
> CLK_SET_RATE_PARENT would be dropped.
> Merge two flag setting together to correct the error.
>
> Fixes: 5a1cc4c27ad2 ("clk: mediatek: Add flags to mtk_gate")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Weiyi Lu <weiyi.lu@mediatek.com>
> ---
Applied to clk-fixes
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-12 16:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-12 3:30 [PATCH v1] clk: mediatek: fix clk-gate flag setting Weiyi Lu
2019-04-12 13:49 ` Matthias Brugger
2019-04-12 16:41 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).